diff options
author | Richard Purdie <richard.purdie@linuxfoundation.org> | 2013-09-16 07:18:34 +0000 |
---|---|---|
committer | Richard Purdie <richard.purdie@linuxfoundation.org> | 2013-09-17 14:09:37 +0100 |
commit | 8ffaba61da7f195d7c3b64dce35b6a56272aecae (patch) | |
tree | 0f4e975ad083a24748acc6074b312fe8d0a5a87f /lib/bb/siggen.py | |
parent | 43a245bde318545ea75ca4ce7894395c1cf9b32a (diff) | |
download | bitbake-8ffaba61da7f195d7c3b64dce35b6a56272aecae.tar.gz |
siggen: Use lookup cache exclusively
All the values we need are already guaranteed to be in the lookupcache
so rather than fetch variables again, just use the cache. This gives a
small performance improvement and simplifies the code.
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
Diffstat (limited to 'lib/bb/siggen.py')
-rw-r--r-- | lib/bb/siggen.py | 15 |
1 files changed, 3 insertions, 12 deletions
diff --git a/lib/bb/siggen.py b/lib/bb/siggen.py index fb8b67850..c15ba28ea 100644 --- a/lib/bb/siggen.py +++ b/lib/bb/siggen.py @@ -91,8 +91,7 @@ class SignatureGeneratorBasic(SignatureGenerator): basehash = {} for task in tasklist: - data = d.getVar(task, False) - lookupcache[task] = data + data = lookupcache[task] if data is None: bb.error("Task %s from %s seems to be empty?!" % (task, fn)) @@ -115,16 +114,8 @@ class SignatureGeneratorBasic(SignatureGenerator): alldeps = sorted(seen) for dep in alldeps: data = data + dep - if dep in lookupcache: - var = lookupcache[dep] - elif dep[-1] == ']': - vf = dep[:-1].split('[') - var = d.getVarFlag(vf[0], vf[1], False) - lookupcache[dep] = var - else: - var = d.getVar(dep, False) - lookupcache[dep] = var - if var: + var = lookupcache[dep] + if var is not None: data = data + str(var) self.basehash[fn + "." + task] = hashlib.md5(data).hexdigest() taskdeps[task] = alldeps |