diff options
| author |   Richard Purdie <richard.purdie@linuxfoundation.org> | 2019-12-15 17:47:59 +0000 |
|---|---|---|
| committer | Richard Purdie <richard.purdie@linuxfoundation.org> | 2019-12-15 22:23:53 +0000 |
| commit | 2cfeb9998a8ad5b1dcda0bb4e192c5e4306dab17 (patch) | |
| tree | 20d20181a5d9b873e55bcd0ec36a8916402c7272 | |
| parent | 105d1f0748edde7753a4063e6fdc758ffc8a8a9e (diff) | |
| download | bitbake-2cfeb9998a8ad5b1dcda0bb4e192c5e4306dab17.tar.gz | |
runqueue: Optimise task filtering
We were seeing this running thousands of times with hashequiv, do
the filtering where it makes more sense and make it persist.
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
| -rw-r--r-- | lib/bb/runqueue.py | 5 |
1 files changed, 2 insertions, 3 deletions
diff --git a/lib/bb/runqueue.py b/lib/bb/runqueue.py index 73775d976..b90ac875e 100644 --- a/lib/bb/runqueue.py +++ b/lib/bb/runqueue.py @@ -148,8 +148,9 @@ class RunQueueScheduler(object): """ Return the id of the first task we find that is buildable """ + # Once tasks are running we don't need to worry about them again + self.buildable.difference_update(self.rq.runq_running) buildable = set(self.buildable) - buildable.difference_update(self.rq.runq_running) buildable.difference_update(self.rq.holdoff_tasks) buildable.intersection_update(self.rq.tasks_covered | self.rq.tasks_notcovered) if not buildable: @@ -207,8 +208,6 @@ class RunQueueScheduler(object): def newbuildable(self, task): self.buildable.add(task) - # Once tasks are running we don't need to worry about them again - self.buildable.difference_update(self.rq.runq_running) def removebuildable(self, task): self.buildable.remove(task) |