diff options
| author |   Richard Purdie <richard.purdie@linuxfoundation.org> | 2023-03-10 21:45:19 +0100 |
|---|---|---|
| committer | Richard Purdie <richard.purdie@linuxfoundation.org> | 2023-03-14 15:05:21 +0000 |
| commit | 2b239555f76e4e98ca704e7ef60e796d0f19463c (patch) | |
| tree | 8f1552138f8f4e6f7aeeb5ae5a2101e5e937cd40 | |
| parent | 4b922345a40f7cc803eb46c4906269691d408940 (diff) | |
| download | bitbake-2b239555f76e4e98ca704e7ef60e796d0f19463c.tar.gz | |
cookerdata: Drop dubious exception handling code
This code appears to be dangerous, it swallows exceptions, turning them into
"handled" versions which then show no errors to the user. This is a pretty
poor user experience and I can't see why this code should be swallowing
such things. Drop the worst bits of code.
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
Signed-off-by: Steve Sakoman <steve@sakoman.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
| -rw-r--r-- | lib/bb/cookerdata.py | 5 |
1 files changed, 0 insertions, 5 deletions
diff --git a/lib/bb/cookerdata.py b/lib/bb/cookerdata.py index 25eea827d..b4bfba335 100644 --- a/lib/bb/cookerdata.py +++ b/lib/bb/cookerdata.py @@ -294,14 +294,9 @@ class CookerDataBuilder(object): bb.event.fire(bb.event.MultiConfigParsed(self.mcdata), self.data) self.data_hash = data_hash.hexdigest() - except (SyntaxError, bb.BBHandledException): - raise bb.BBHandledException() except bb.data_smart.ExpansionError as e: logger.error(str(e)) raise bb.BBHandledException() - except Exception: - logger.exception("Error parsing configuration files") - raise bb.BBHandledException() # Handle obsolete variable names |