diff options
| author |   Scott Murray <scott.murray@konsulko.com> | 2022-02-21 23:21:38 -0500 |
|---|---|---|
| committer |   Richard Purdie <richard.purdie@linuxfoundation.org> | 2022-02-22 08:23:45 +0000 |
| commit | 187ac1ea0a701a5ba9ec92f6aa32f2a67600a584 (patch) | |
| tree | ba017af20f932ef5e3756c4a968324acd2c780b7 /scripts/contrib/convert-variable-renames.py | |
| parent | 4125d86f1d3adc53230c02bce4bab46b8c21116f (diff) | |
| download | openembedded-core-187ac1ea0a701a5ba9ec92f6aa32f2a67600a584.tar.gz | |
scripts: fix file writing in convert-variable-renames
In my test environments (Fedora 35 and Debian 10.10 on AMD 2970WX),
running the convert-variable-renames.py rename script was resulting
in empty files instead of updated ones. From inspection, the new
files are never flushed/closed before moving them into place, which
seems inherently racy. Adding an explicit close to flush the modified
contents out before moving into place fixes the issue for me.
Signed-off-by: Scott Murray <scott.murray@konsulko.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
Diffstat (limited to 'scripts/contrib/convert-variable-renames.py')
| -rwxr-xr-x | scripts/contrib/convert-variable-renames.py | 1 |
1 files changed, 1 insertions, 0 deletions
diff --git a/scripts/contrib/convert-variable-renames.py b/scripts/contrib/convert-variable-renames.py index fca59ca9e1..ed012610db 100755 --- a/scripts/contrib/convert-variable-renames.py +++ b/scripts/contrib/convert-variable-renames.py @@ -84,6 +84,7 @@ def processfile(fn): if re.search(check_word, line, re.IGNORECASE): print("%s needs further work at line %s since it contains %s"% (fn, lineno, check_word)) new_file.write(line) + new_file.close() if modified: print("*** Modified file '%s'" % (fn)) shutil.copymode(fn, abs_path) |