diff options
authorPaul Eggleton <paul.eggleton@linux.intel.com>2017-09-14 08:32:17 +1200
committerPaul Eggleton <paul.eggleton@linux.intel.com>2017-09-14 08:39:25 +1200
commitb7b1380d733f237049296801a665978263edc918 (patch)
parentde70799af1a8bfe2fac22b90401053275d4714ba (diff)
oe-selftest: devtool: fix test_devtool_add hanging on some machinespaule/devtool-edit-recipe-selftest-fix
The code in scriptutils which implements the logic for running the editor used by devtool edit-recipe looks at the VISUAL environment variable before EDITOR, and thus if VISUAL is set in the environment it will override the EDITOR value we are setting here, the editor (usually vim) launches and there's nothing to stop it running forever short of manually killing it. Set VISUAL instead to fix this. Apparently VISUAL is in fact the variable we should really be preferring here - I don't think I knew that but somehow I got it right in the code, just not in the test. Here are the details for the curious: https://unix.stackexchange.com/questions/4859/visual-vs-editor-whats-the-difference Fixes [YOCTO #12074]. Signed-off-by: Paul Eggleton <paul.eggleton@linux.intel.com>
1 files changed, 1 insertions, 1 deletions
diff --git a/meta/lib/oeqa/selftest/cases/devtool.py b/meta/lib/oeqa/selftest/cases/devtool.py
index d5d09186f7..1dfef599e6 100644
--- a/meta/lib/oeqa/selftest/cases/devtool.py
+++ b/meta/lib/oeqa/selftest/cases/devtool.py
@@ -216,7 +216,7 @@ class DevtoolTests(DevtoolBase):
result = runCmd('devtool -q find-recipe %s' % pn)
self.assertEqual(recipepath, result.output.strip())
# Test devtool edit-recipe
- result = runCmd('EDITOR="echo 123" devtool -q edit-recipe %s' % pn)
+ result = runCmd('VISUAL="echo 123" devtool -q edit-recipe %s' % pn)
self.assertEqual('123 %s' % recipepath, result.output.strip())
# Clean up anything in the workdir/sysroot/sstate cache (have to do this *after* devtool add since the recipe only exists then)
bitbake('%s -c cleansstate' % pn)