summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorChangqing Li <changqing.li@windriver.com>2021-03-14 18:03:25 -0700
committerMartin Jansa <Martin.Jansa@gmail.com>2021-05-06 11:03:29 +0200
commitd7f6011d13b132af931d684f74eff70e2bc610a6 (patch)
treedbf9e24cdc4babc2604825a6f6f0f0875f2eace4
parent4d8748d455a84789a1cef97d382d54e6d7f502e8 (diff)
downloadopenembedded-core-contrib-jansa/hardknott.tar.gz
openembedded-core-contrib-jansa/hardknott.tar.bz2
openembedded-core-contrib-jansa/hardknott.zip
report-error.bbclass: replace angle brackets with &lt; and &gt;jansa/hardknott
when we have below content in local.conf or auto.conf: BUILDHISTORY_COMMIT_AUTHOR ?= "Khem Raj <raj.khem@gmail.com>" send-error-report will fail with "HTTP Error 500: OK" error-report-web do rudimentary check on all fields that are passed to the graphs page to avoid any XSS happening, if contains '<', the server will return error(Invalid characters in json). fixed by use escape of <> to replace it. NOTE: with this change, error-report-web need to add filter 'safe' for the string wanted to display to avoid further HTML escaping prior to output. Below is how the content displayed on webpage: with the filter 'safe': BUILDHISTORY_COMMIT_AUTHOR ?= "Khem Raj <raj.khem@gmail.com>" without the filter 'safe': BUILDHISTORY_COMMIT_AUTHOR ?= "Khem Raj &lt;raj.khem@gmail.com&gt;" Another patch for error-report-web will send to yocto mail list. [YOCTO #13252] Signed-off-by: Changqing Li <changqing.li@windriver.com> Signed-off-by: Khem Raj <raj.khem@gmail.com>
-rw-r--r--meta/classes/report-error.bbclass1
1 files changed, 1 insertions, 0 deletions
diff --git a/meta/classes/report-error.bbclass b/meta/classes/report-error.bbclass
index 0ddbab9071..d07aa77c54 100644
--- a/meta/classes/report-error.bbclass
+++ b/meta/classes/report-error.bbclass
@@ -44,6 +44,7 @@ def get_conf_data(e, filename):
continue
else:
jsonstring=jsonstring + line
+ jsonstring = jsonstring.replace("<", "&lt;").replace(">", "&gt;")
return jsonstring
def errorreport_get_user_info(e):