summaryrefslogtreecommitdiffstats
path: root/lib
diff options
context:
space:
mode:
authorPaul Eggleton <paul.eggleton@linux.intel.com>2012-09-21 15:47:23 +0100
committerRichard Purdie <richard.purdie@linuxfoundation.org>2012-09-24 12:12:08 +0100
commitcf0a67d62f631aa48d1afc3fbdd0f73995b1c401 (patch)
treebab42e45917c03631468cc033c2bd7f37614b4cb /lib
parentc366f4314c29b873a486daa9a0a4e29bb4225dd6 (diff)
downloadbitbake-cf0a67d62f631aa48d1afc3fbdd0f73995b1c401.tar.gz
hob: don't show error dialog for errors during building
During building we already report errors in a special tab and indicate when the build has failed; bringing up a dialog was a regression introduced in bitbake revision 5bab81b124087d63d6eb62a861e1241714fcd483. Fixes [YOCTO #3151]. Signed-off-by: Paul Eggleton <paul.eggleton@linux.intel.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
Diffstat (limited to 'lib')
-rw-r--r--lib/bb/ui/crumbs/hobeventhandler.py9
1 files changed, 5 insertions, 4 deletions
diff --git a/lib/bb/ui/crumbs/hobeventhandler.py b/lib/bb/ui/crumbs/hobeventhandler.py
index 8fc1732a8..49db2deb2 100644
--- a/lib/bb/ui/crumbs/hobeventhandler.py
+++ b/lib/bb/ui/crumbs/hobeventhandler.py
@@ -183,10 +183,11 @@ class HobHandler(gobject.GObject):
self.emit("sanity-failed", event._msg)
elif isinstance(event, logging.LogRecord):
- if event.levelno >= logging.ERROR:
- formatter = bb.msg.BBLogFormatter()
- msg = formatter.format(event)
- self.error_msg += msg + '\n'
+ if not self.building:
+ if event.levelno >= logging.ERROR:
+ formatter = bb.msg.BBLogFormatter()
+ msg = formatter.format(event)
+ self.error_msg += msg + '\n'
elif isinstance(event, bb.event.TargetsTreeGenerated):
self.current_phase = "data generation"