diff options
author | Peter Kjellerstedt <peter.kjellerstedt@axis.com> | 2023-09-25 04:18:31 +0200 |
---|---|---|
committer | Steve Sakoman <steve@sakoman.com> | 2023-11-03 16:46:25 -1000 |
commit | e452c6d7ba5bb4f78a1d2bfb742794efdf171dbc (patch) | |
tree | 44157872e61a4e124feee0673f5a72de48c824eb | |
parent | 161ab0d5bab74732e12d490cee50e14295be0a9f (diff) | |
download | bitbake-e452c6d7ba5bb4f78a1d2bfb742794efdf171dbc.tar.gz |
tinfoil: Do not fail when logging is disabled and full config is used
If Tinfoil is initialized with setup_logging = False and
Tinfoil.prepare() is called with config_only = False, then it fails
because self.localhandlers is only initialized when
setup_logging = True.
This is seen with, e.g., `bitbake-getvar -q -r busybox MACHINE`:
Traceback (most recent call last):
File ".../bitbake/bin/bitbake-getvar", line 41, in <module>
tinfoil.prepare(quiet=2)
File ".../bitbake/lib/bb/tinfoil.py", line 390, in prepare
for handler in self.localhandlers:
AttributeError: 'Tinfoil' object has no attribute 'localhandlers'.
Did you mean: 'oldhandlers'?
Signed-off-by: Peter Kjellerstedt <peter.kjellerstedt@axis.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
(cherry picked from commit 616101ddb630e2c9975022068b52a87c4cf647f6)
Signed-off-by: Steve Sakoman <steve@sakoman.com>
-rw-r--r-- | lib/bb/tinfoil.py | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/lib/bb/tinfoil.py b/lib/bb/tinfoil.py index e68a3b879..fa29b930c 100644 --- a/lib/bb/tinfoil.py +++ b/lib/bb/tinfoil.py @@ -324,11 +324,11 @@ class Tinfoil: self.recipes_parsed = False self.quiet = 0 self.oldhandlers = self.logger.handlers[:] + self.localhandlers = [] if setup_logging: # This is the *client-side* logger, nothing to do with # logging messages from the server bb.msg.logger_create('BitBake', output) - self.localhandlers = [] for handler in self.logger.handlers: if handler not in self.oldhandlers: self.localhandlers.append(handler) |