diff options
| author |   Marc Olzheim <zlo@zlo.nu> | 2009-07-30 04:48:31 +0000 |
|---|---|---|
| committer |   Holger Hans Peter Freyther <zecke@selfish.org> | 2010-01-28 14:20:11 +0100 |
| commit | f7314afb56433599c8260546b1346f0c320c8bb9 (patch) | |
| tree | bd5a8c6ab4932a3fa531fef15c13ce6b59544c14 | |
| parent | fd8f496ff497fd24492b24fe9f94be1cf3171ac9 (diff) | |
| download | openembedded-f7314afb56433599c8260546b1346f0c320c8bb9.tar.gz | |
Commit 2e0fa4918d643ce6ec0299cd31cfe1c346e4bce3 breaks libtool's do_configure [PATCH]
On Thu, Jul 30, 2009 at 03:22:19PM +0200, Leon Woestenberg wrote:
> > My /bin/sh is a dash, I should have known, my apologies. I have a patch
> >
> Testing with dash rather than bash is GOOD due to it adhering to POSIX
> without much of the bash-specifics.
Well, I agree, but judging by commit
e0ed375a8dfb292bdd72f5891917ef81f361f15c to classes/sanity.bbclass, I
assumed the policy was to require /bin/bash for /bin/sh instead of
fixing bashisms.
To not be obligated to use bash, I added the attached patch.
> So please do not introduce 'bashisms' (dependencies on bash behaviour).
I agree ;-)
Marc
commit d37e8ae3fb24b589793ae92062d665cc6384151e
Author: Marc Olzheim <marc@iphion.nl>
Date: Thu Jun 11 12:44:34 2009 +0200
Make allowing dash as /bin/sh a configuration option.
| -rw-r--r-- | classes/sanity.bbclass | 11 |
1 files changed, 6 insertions, 5 deletions
diff --git a/classes/sanity.bbclass b/classes/sanity.bbclass index f57d8e47d0..afc1dd3f8a 100644 --- a/classes/sanity.bbclass +++ b/classes/sanity.bbclass @@ -113,11 +113,12 @@ def check_sanity(e): missing = missing.rstrip(',') messages = messages + "Please install following missing utilities: %s\n" % missing - try: - if os.path.basename(os.readlink('/bin/sh')) == 'dash': - messages = messages + "Using dash as /bin/sh causes various subtle build problems, please use bash instead.\n" - except: - pass + if not data.getVar( 'ALLOW_DASH_SH', e.data, True ): + try: + if os.path.basename(os.readlink('/bin/sh')) == 'dash': + messages = messages + "Using dash as /bin/sh causes various subtle build problems, please use bash instead.\n" + except: + pass omask = os.umask(022) if omask & 0755: |