aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorGraham Gower <graham.gower@gmail.com>2009-11-05 12:49:24 +0000
committerHolger Hans Peter Freyther <zecke@selfish.org>2010-01-28 14:21:07 +0100
commit945878c8e4eae9df4cc3e63387debe8d5898205c (patch)
treed060c5830a0a9731c9a5449a15f13281933f0db4
parent4a6efa52d905669cae63d4b57706143b0d590c78 (diff)
downloadopenembedded-945878c8e4eae9df4cc3e63387debe8d5898205c.tar.gz
opkg memory problem?
01234567890123456789012345678901234567890123456789012345678901234567890123456789 When OE does 'opkg-cl install $EVERYTHING', all the memory leaks in opkg start to accumulate. My guess is that somewhere a memory allocation failed but was not checked for failure, then everything started to blow up. Obviously, the memory leaks should be plugged (working on it...) and memory allocations checked for failure (hopefully all sorted in opkg svn now). But there's still a danger that large images will exhaust the supply of memory, causing massive thrashing if nothing else. The following is untested and only reduces that chances of this occuring, but perhaps it makes sense to do something like this?
-rw-r--r--classes/rootfs_ipk.bbclass6
1 files changed, 3 insertions, 3 deletions
diff --git a/classes/rootfs_ipk.bbclass b/classes/rootfs_ipk.bbclass
index 16dd511fcb..58e5f45ef5 100644
--- a/classes/rootfs_ipk.bbclass
+++ b/classes/rootfs_ipk.bbclass
@@ -53,9 +53,9 @@ fakeroot rootfs_ipk_do_rootfs () {
done
fi
fi
- if [ ! -z "${PACKAGE_INSTALL}" ]; then
- opkg-cl ${IPKG_ARGS} install ${PACKAGE_INSTALL}
- fi
+ for i in ${PACKAGE_INSTALL}; do
+ opkg-cl ${IPKG_ARGS} install $i
+ done
export D=${IMAGE_ROOTFS}
export OFFLINE_ROOT=${IMAGE_ROOTFS}