From c574aaf30c82ad397c0a6567b3cb52e7fb5d5829 Mon Sep 17 00:00:00 2001 From: Chen Qi Date: Fri, 12 Apr 2019 09:40:06 +0800 Subject: runqemu: do not check return code of tput The subprocess.run was replaced by subprocess.check_call because of compatibility support down to python 3.4. But we really don't care about whether that command succeeds. Some user reports that in some tmux environment, this command fails and gives some unpleasant traceback output. So we use 'call' instead of 'check_call' to avoid such problem. Signed-off-by: Chen Qi Signed-off-by: Richard Purdie --- scripts/runqemu | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/scripts/runqemu b/scripts/runqemu index c0e569c44c..a4fc606e50 100755 --- a/scripts/runqemu +++ b/scripts/runqemu @@ -1329,7 +1329,8 @@ def main(): logger.info("SIGTERM received") os.kill(config.qemupid, signal.SIGTERM) config.cleanup() - subprocess.check_call(["tput", "smam"]) + # Deliberately ignore the return code of 'tput smam'. + subprocess.call(["tput", "smam"]) signal.signal(signal.SIGTERM, sigterm_handler) config.check_args() @@ -1351,7 +1352,8 @@ def main(): return 1 finally: config.cleanup() - subprocess.check_call(["tput", "smam"]) + # Deliberately ignore the return code of 'tput smam'. + subprocess.call(["tput", "smam"]) if __name__ == "__main__": sys.exit(main()) -- cgit 1.2.3-korg