From 82fe0e8c98244794531f0e24ceb93953fe68dda5 Mon Sep 17 00:00:00 2001 From: Armin Kuster Date: Sat, 16 Jul 2016 16:04:12 -0700 Subject: openssl: Security fix CVE-2016-2178 affects openssl <= 1.0.2h CVSS v2 Base Score: 2.1 LOW Signed-off-by: Armin Kuster Signed-off-by: Ross Burton (cherry picked from commit 5b3df0c5e8885ea34f66b41fcf209a9960fbbf5e) Signed-off-by: Armin Kuster --- .../openssl/openssl/CVE-2016-2178.patch | 51 ++++++++++++++++++++++ .../recipes-connectivity/openssl/openssl_1.0.2h.bb | 1 + 2 files changed, 52 insertions(+) create mode 100644 meta/recipes-connectivity/openssl/openssl/CVE-2016-2178.patch diff --git a/meta/recipes-connectivity/openssl/openssl/CVE-2016-2178.patch b/meta/recipes-connectivity/openssl/openssl/CVE-2016-2178.patch new file mode 100644 index 0000000000..27ade4e7d2 --- /dev/null +++ b/meta/recipes-connectivity/openssl/openssl/CVE-2016-2178.patch @@ -0,0 +1,51 @@ +From 399944622df7bd81af62e67ea967c470534090e2 Mon Sep 17 00:00:00 2001 +From: Cesar Pereida +Date: Mon, 23 May 2016 12:45:25 +0300 +Subject: [PATCH] Fix DSA, preserve BN_FLG_CONSTTIME + +Operations in the DSA signing algorithm should run in constant time in +order to avoid side channel attacks. A flaw in the OpenSSL DSA +implementation means that a non-constant time codepath is followed for +certain operations. This has been demonstrated through a cache-timing +attack to be sufficient for an attacker to recover the private DSA key. + +CVE-2016-2178 + +Reviewed-by: Richard Levitte +Reviewed-by: Matt Caswell + +Upstream-Status: Backport +CVE: CVE-2016-2178 + +Signed-off-by: Armin Kuster + +--- + crypto/dsa/dsa_ossl.c | 9 +++++---- + 1 file changed, 5 insertions(+), 4 deletions(-) + +Index: openssl-1.0.2h/crypto/dsa/dsa_ossl.c +=================================================================== +--- openssl-1.0.2h.orig/crypto/dsa/dsa_ossl.c ++++ openssl-1.0.2h/crypto/dsa/dsa_ossl.c +@@ -248,9 +248,6 @@ static int dsa_sign_setup(DSA *dsa, BN_C + if (!BN_rand_range(&k, dsa->q)) + goto err; + while (BN_is_zero(&k)) ; +- if ((dsa->flags & DSA_FLAG_NO_EXP_CONSTTIME) == 0) { +- BN_set_flags(&k, BN_FLG_CONSTTIME); +- } + + if (dsa->flags & DSA_FLAG_CACHE_MONT_P) { + if (!BN_MONT_CTX_set_locked(&dsa->method_mont_p, +@@ -282,6 +279,11 @@ static int dsa_sign_setup(DSA *dsa, BN_C + } else { + K = &k; + } ++ ++ if ((dsa->flags & DSA_FLAG_NO_EXP_CONSTTIME) == 0) { ++ BN_set_flags(K, BN_FLG_CONSTTIME); ++ } ++ + DSA_BN_MOD_EXP(goto err, dsa, r, dsa->g, K, dsa->p, ctx, + dsa->method_mont_p); + if (!BN_mod(r, r, dsa->q, ctx)) diff --git a/meta/recipes-connectivity/openssl/openssl_1.0.2h.bb b/meta/recipes-connectivity/openssl/openssl_1.0.2h.bb index 4135a312c5..07cb0f9e85 100644 --- a/meta/recipes-connectivity/openssl/openssl_1.0.2h.bb +++ b/meta/recipes-connectivity/openssl/openssl_1.0.2h.bb @@ -39,6 +39,7 @@ SRC_URI += "file://configure-targets.patch \ file://ptest_makefile_deps.patch \ file://parallel.patch \ file://CVE-2016-2177.patch \ + file://CVE-2016-2178.patch \ " SRC_URI[md5sum] = "9392e65072ce4b614c1392eefc1f23d0" -- cgit 1.2.3-korg