From e2412294b6b1d3a80ee97a0706613349edc51d33 Mon Sep 17 00:00:00 2001 From: Markus Lehtonen Date: Wed, 10 Feb 2016 16:15:57 +0200 Subject: sign_rpm.bbclass: do not store key details in signer instance Refactor the LocalSigner class. Do not store keyid or passphrase file in the signer object as they are only needed for some of the methods. For example, the newly added verify() method does not need any key parameters and export_pubkey only uses keyid. Signed-off-by: Markus Lehtonen Signed-off-by: Ross Burton Signed-off-by: Richard Purdie --- meta/recipes-core/meta/signing-keys.bb | 16 ++++++---------- 1 file changed, 6 insertions(+), 10 deletions(-) (limited to 'meta/recipes-core/meta') diff --git a/meta/recipes-core/meta/signing-keys.bb b/meta/recipes-core/meta/signing-keys.bb index d7aa79d49f..d7763c664e 100644 --- a/meta/recipes-core/meta/signing-keys.bb +++ b/meta/recipes-core/meta/signing-keys.bb @@ -26,18 +26,14 @@ python do_export_public_keys () { if d.getVar("RPM_SIGN_PACKAGES", True): # Export public key of the rpm signing key - signer = get_signer(d, - d.getVar('RPM_GPG_BACKEND', True), - d.getVar('RPM_GPG_NAME', True), - d.getVar('RPM_GPG_PASSPHRASE_FILE', True)) - signer.export_pubkey(d.getVar('RPM_GPG_PUBKEY', True)) + signer = get_signer(d, d.getVar('RPM_GPG_BACKEND', True)) + signer.export_pubkey(d.getVar('RPM_GPG_PUBKEY', True), + d.getVar('RPM_GPG_NAME', True)) if d.getVar('PACKAGE_FEED_SIGN', True) == '1': # Export public key of the feed signing key - signer = get_signer(d, - d.getVar('PACKAGE_FEED_GPG_BACKEND', True), - d.getVar('PACKAGE_FEED_GPG_NAME', True), - d.getVar('PACKAGE_FEED_GPG_PASSPHRASE_FILE', True)) - signer.export_pubkey(d.getVar('PACKAGE_FEED_GPG_PUBKEY', True)) + signer = get_signer(d, d.getVar('PACKAGE_FEED_GPG_BACKEND', True)) + signer.export_pubkey(d.getVar('PACKAGE_FEED_GPG_PUBKEY', True), + d.getVar('PACKAGE_FEED_GPG_NAME', True)) } addtask do_export_public_keys before do_build -- cgit 1.2.3-korg