From e6579b4e007ce89000c46c09917fbd3c72f18a73 Mon Sep 17 00:00:00 2001 From: Ed Bartosh Date: Thu, 2 Feb 2017 15:32:58 +0200 Subject: wic: direct: fix creation of work directory It was a typo in current code: mktemp was used instead of mkdtemp to create work directory. This is fixed by using mkdtemp. Create work directory as a subdirectory of output directory to make sure both are on the same partition to make moving of result image faster. This also fixes possible disk space issues as mkdtemp uses TMPDIR, TEMP or TMP environment variables to get default value of its 'dir' parameter. Those variables are usually pointing to /tmp, which is not the best location to create huge images. Signed-off-by: Ed Bartosh Signed-off-by: Ross Burton --- scripts/lib/wic/plugins/imager/direct.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/scripts/lib/wic/plugins/imager/direct.py b/scripts/lib/wic/plugins/imager/direct.py index 4637fbf302..b38e876758 100644 --- a/scripts/lib/wic/plugins/imager/direct.py +++ b/scripts/lib/wic/plugins/imager/direct.py @@ -122,7 +122,7 @@ class DirectImageCreator: """ self.name = name self.outdir = outdir - self.workdir = tempfile.mktemp(prefix='wic') + self.workdir = tempfile.mkdtemp(dir=outdir, prefix='tmp.wic.') self.ks = ksobj self._image = None -- cgit 1.2.3-korg