From 3b806c927504e682ddd159c890a5f243e273b23e Mon Sep 17 00:00:00 2001 From: Andreas Müller Date: Wed, 21 Sep 2016 22:46:38 +0200 Subject: libnewt: link whiptail properly with libnewt MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Configuration failed to detect gold as GNU linker. It was searching for 'GNU ld' but gold returns 'GNU gold (GNU Binutils 2.27.0.20160806) 1.12' which does not match. When not linking by GNU linker Makefile did some magic link target alignment: ifneq ($(GNU_LD),) SHLIBFLAGS= -Wl,--version-script,newt.0.52.ver -Wl,-soname,$(LIBNEWTSONAME) else SHLIBFLAGS= endif which caused: | WARNING: libnewt-0.52.19-r0 do_package_qa: QA Issue: /usr/bin/whiptail contained in package whiptail requires libnewt.so, but no providers found in RDEPENDS_whiptail? [file-rdeps] Signed-off-by: Andreas Müller Signed-off-by: Ross Burton --- .../files/0001-detect-gold-as-GNU-linker-too.patch | 31 ++++++++++++++++++++++ meta/recipes-extended/newt/libnewt_0.52.19.bb | 1 + 2 files changed, 32 insertions(+) create mode 100644 meta/recipes-extended/newt/files/0001-detect-gold-as-GNU-linker-too.patch diff --git a/meta/recipes-extended/newt/files/0001-detect-gold-as-GNU-linker-too.patch b/meta/recipes-extended/newt/files/0001-detect-gold-as-GNU-linker-too.patch new file mode 100644 index 0000000000..a4b3afd959 --- /dev/null +++ b/meta/recipes-extended/newt/files/0001-detect-gold-as-GNU-linker-too.patch @@ -0,0 +1,31 @@ +From 58245b859ffbcb1780575bf1b0a018d55e74e434 Mon Sep 17 00:00:00 2001 +From: =?UTF-8?q?Andreas=20M=C3=BCller?= +Date: Wed, 21 Sep 2016 21:14:40 +0200 +Subject: [PATCH] detect gold as GNU linker too +MIME-Version: 1.0 +Content-Type: text/plain; charset=UTF-8 +Content-Transfer-Encoding: 8bit + +Upstream-Status: Pending + +Signed-off-by: Andreas Müller +--- + configure.ac | 2 +- + 1 file changed, 1 insertion(+), 1 deletion(-) + +diff --git a/configure.ac b/configure.ac +index 03e8bda..c2fce51 100644 +--- a/configure.ac ++++ b/configure.ac +@@ -28,7 +28,7 @@ AC_CHECK_SIZEOF([void *]) + AC_MSG_CHECKING([for GNU ld]) + LD=`$CC -print-prog-name=ld 2>&5` + +-if test `$LD -v 2>&1 | $ac_cv_path_GREP -c "GNU ld"` = 0; then ++if test `$LD -v 2>&1 | $ac_cv_path_GREP -c "GNU "` = 0; then + # Not + GNU_LD="" + AC_MSG_RESULT([no]) +-- +2.5.5 + diff --git a/meta/recipes-extended/newt/libnewt_0.52.19.bb b/meta/recipes-extended/newt/libnewt_0.52.19.bb index 22bdaf5ab1..a26ce1fbe7 100644 --- a/meta/recipes-extended/newt/libnewt_0.52.19.bb +++ b/meta/recipes-extended/newt/libnewt_0.52.19.bb @@ -22,6 +22,7 @@ SRC_URI = "https://fedorahosted.org/releases/n/e/newt/newt-${PV}.tar.gz \ file://cross_ar.patch \ file://Makefile.in-Add-tinfo-library-to-the-linking-librari.patch \ file://pie-flags.patch \ + file://0001-detect-gold-as-GNU-linker-too.patch \ " SRC_URI[md5sum] = "e4aa0f7943edd39c52481a87f68f412a" -- cgit 1.2.3-korg