summaryrefslogtreecommitdiffstats
path: root/meta/recipes-extended
AgeCommit message (Collapse)Author
2019-06-19libnewt: merge libnewt-python recipe into the main recipeAlexander Kanavin
libnewt-python was including libnewt recipe and adding tweaks, which is bad form. It also broke AUH, as it won't update more than one recipe in a single transaction. Signed-off-by: Alexander Kanavin <alex.kanavin@gmail.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
2019-06-18systat: systemd never enables the serviceStefano Babic
Even if SYSTEMD_AUTO_ENABLE is set to "enable", the service is never activated by systemd. The cause is the postinst function in the recipe: pkg_postinst_${PN} () { if [ -n "$D" ]; then exit 0 fi if [ -e /etc/init.d/populate-volatile.sh ]; then /etc/init.d/populate-volatile.sh update fi } This generates with activated systemd the following postinst script: set -e if [ -n "$D" ]; then exit 0 fi if [ -e /etc/init.d/populate-volatile.sh ]; then /etc/init.d/populate-volatile.sh update fi OPTS="" if [ -n "$D" ]; then OPTS="--root=$D" fi if type systemctl >/dev/null 2>/dev/null; then if [ -z "$D" ]; then systemctl daemon-reload fi systemctl $OPTS enable sysstat.service if [ -z "$D" -a "enable" = "enable" ]; then systemctl --no-block restart sysstat.service fi fi Due to the exit statement, systemctl is never called and the service is never enabled in rootfs. Invert the logic for the check to let run the rest of postinst script. Signed-off-by: Stefano Babic <sbabic@denx.de> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
2019-06-18lighttpd: Upgrade 1.4.53 -> 1.4.54Zang Ruochen
Upgrade from lighttpd_1.4.53.bb to lighttpd_1.4.54.bb. Signed-off-by: Zang Ruochen <zangrc.fnst@cn.fujitsu.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
2019-06-18less: upgrade 550 -> 551Yi Zhao
Signed-off-by: Yi Zhao <yi.zhao@windriver.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
2019-06-18shadow: fix configure error with dashYi Zhao
A configure error occurs when /bin/sh -> dash: checking for is_selinux_enabled in -lselinux... yes checking for semanage_connect in -lsemanage... yes configure: 16322: test: yesyes: unexpected operator Use "=" instead of "==" since dash doesn't support the latter. Signed-off-by: Yi Zhao <yi.zhao@windriver.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
2019-06-18libxml-sax-perl: upgrade 1.00 -> 1.02Tim Orling
* Sort ptest dependencies alphabetically Upstream release notes: 1.02 14 Jun 2019 Grant McLean - Spelling fixes (patch from Ville Skyttä) - Add repo location to metadata (patches from Ville Skyttä & Martin McGrath) - Reorganise module files under lib/XML - Regenerate MANIFEST using 'make manifest' to include missing test files Signed-off-by: Tim Orling <timothy.t.orling@linux.intel.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
2019-06-18bash: use setpriv, sed.sed to run ptestsRandy MacLeod
The execscript test in bash fails when run with ptest-runner calling 'su', with the error: bash: cannot set terminal process group (16036): Inappropriate ioctl for device Even with ptest-runner fixed to make a child process use the right process group, 'su' still results in the warning above. Use 'setpriv' instead. 'runuser' was considered and works but depends on pam so it's ruled out. Now that all bash tests are run as a user, the patch: fix-run-coproc-run-heredoc-run-execscript-run-test-f.patch can be removed. Also to create the account 'bashtest' in the 'run-ptest' script the bash-ptest must depend on 'shadow'. Also, in 'run-ptest', ensure that the bash ptests are owned by the 'bashtest' user. Add 'sed' as a dependency for ptests since tests/exp8.sub runs: var=$'x\001y\177z' declare -p var | sed -n l and that results in: sed.busybox: "" sed.sed: declare -- var="x\001y\177z"$ This appears to be a feature that busybox sed has not implemented. With this series of changes, bash-ptest for qemux86-64 passes 79 of 81 tests. The remaining failures are: 1. run-read: # cat tests/read6.sub # test read with a timeout of 0 -- input polling # sleep with fractional seconds argument is not universal echo abcde | { sleep 0.25 2>/dev/null ; read -t 0; } echo $? read -t 0 < $0 echo $? read -t 0 echo $? <-- returns 1, when 0 is expected. I can reproduce this on my workstation but only when using ptest-runner and initially logging into the console as root. That's a little odd and seems like I need to continue to improve ptest-runner. 2. run-trap: # cat tests/trap3.sub PS4='+[$LINENO] ' trap 'echo trap: $LINENO' ERR set -x echo 1 echo 2 echo 3 | cat | false <--- error echo 4 This is a scheduler behaviour difference between the common case on a workstation and the common case in qemu. The test case does warn about the completion order not being deterministic so I plan to ignore it. >From tests/run-trap: UNIX versions number signals and schedule processes differently. If output differing only in line numbers is produced, please do not consider this a test failure. Still, it's notable and slightly odd that the common case output is different. Signed-off-by: Sakib Sajal <sakib.sajal@windriver.com> Signed-off-by: Randy MacLeod <Randy.MacLeod@windriver.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
2019-06-14diffutils/run-ptest: support to run at arbitrary pathHongxu Jia
1. Run run-ptest at arbitrary path 2. Fix large-subopt.in1 not found ... |diff: /lib32-diffutils/3.7-r0/build/../diffutils-3.7/tests/large-subopt.in1: No such file or directory |diff: /lib32-diffutils/3.7-r0/build/../diffutils-3.7/tests/large-subopt.in2: No such file or directory ... Signed-off-by: Hongxu Jia <hongxu.jia@windriver.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
2019-06-12pigz: install pigz, unpigz, pigzcat in native and nativesdk builds againMartin Jansa
* since this commit: commit ad1db93d134db1ec4f6d6598c9741dc13e82e1f3 Author: Anuj Mittal <anuj.mittal@intel.com> Date: Tue May 28 06:32:10 2019 +0800 Subject: Revert "pigz: pigz is not gzip" pigz-native and nativesdk-pigz no longer installs pigz, unpigz, pigzcat, so scripts explicitly depending on pigz-native and calling pigz started to fail. * reverse the logic - all the builds install pigz, unpigz, pigzcat - only the native one installs it as gzip as well * it could be optimized a bit more to create gzip as just a symlink in native case as well, but they are in different directories (pigz in base_bindir and gzip in bindir) and it's only 130kB.. Signed-off-by: Martin Jansa <Martin.Jansa@gmail.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
2019-06-08gawk: ptest fixesRichard Purdie
In minimal images all tests pass due to a missing dependency on make. Add the missing dependecy. The test list created by the run-ptest script is incorrect as it includes entries like "fi". Simplify it and correct it. Some tests are skipped due to mpfr not being enabled. Correctly mark these as SKIP. Some tests need the "../gawk" script, create a link to it so the tests work correctly. Also print more information in the failed test cases. Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
2019-06-08parted: drop patch for linux <2.6.20 supportRoss Burton
We don't really care about kernels this old anymore, so drop the patch. Signed-off-by: Ross Burton <ross.burton@intel.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
2019-06-08parted: swap patches for the commits that landed upstreamRoss Burton
Several of the parted fixes are actually upstream in slightly different form. Signed-off-by: Ross Burton <ross.burton@intel.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
2019-06-07slang: modify an array testJoe Slater
One array test attempts to create an array that is far too large to exist. Different exceptions are thrown for 32 and 64 bit machines, so we account for that when catching them. Signed-off-by: Joe Slater <joe.slater@windriver.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
2019-06-07bash: Replace uninative loader path in ptestJoshua Watt
The Makefile used for bash-ptest can pick up the path to the uninative loader through BUILD_LDFLAGS. This includes the full path to the uninative loader, which is not reproducible. Replace it with /bin/false. It doesn't appear as if these native programs are used in the test suites and if there are likely to be other problems related to building them using the BUILD_* flags. Signed-off-by: Joshua Watt <JPEWhacker@gmail.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
2019-06-07Remove manual RDEPENDS from PN-ptest to PN packageAdrian Bunk
They are now added automatically by the ptest class. Signed-off-by: Adrian Bunk <bunk@stusta.de> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
2019-06-04libidn2: upgrade to 2.2.0Ross Burton
The unistring patch isn't needed anymore (the relevant lines are entirely removed). License checksums updated because of a typo fix, and an added author name. Signed-off-by: Ross Burton <ross.burton@intel.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
2019-06-04libpam: fix upstream version checkAnuj Mittal
Recent upgrade to the recipe moved SRC_URI to github. Fix the version check accordingly. Signed-off-by: Anuj Mittal <anuj.mittal@intel.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
2019-06-04groff: improve reproducibilityHongxu Jia
As said in ${S}/m4/groff.m4 ... 1642 # gdiffmk will attempt to use bash (for option -ef of 'test'). If bash 1643 # is not available it will use /bin/sh. ... So drop hardcode shebang replacement, and pass variable to configure, it also remove build path in gdiffmk to improve reproducibility Signed-off-by: Hongxu Jia <hongxu.jia@windriver.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
2019-06-04zip: Remove build date to improve reproducibilityJoshua Watt
Applies a patch from Debian to remove the build date from zip. Signed-off-by: Joshua Watt <JPEWhacker@gmail.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
2019-06-04libpam: Upgrade 1.3.0 -> 1.3.1Adrian Bunk
Remove patch applied upstream. Upstream tarball location changed. Signed-off-by: Adrian Bunk <bunk@stusta.de> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
2019-06-04tcp-wrappers: Add compile warning fixes from DebianAdrian Bunk
Signed-off-by: Adrian Bunk <bunk@stusta.de> -- v2: Add comment in the patch headers. Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
2019-06-01libxml-sax-perl: Fix module ptest dependenciesRichard Purdie
This fixes runtime errors when running the ptest in a minimal image. Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
2019-06-01libconvert-aan1-perl: Fix module and ptest dependenciesRichard Purdie
This fixes runtime errors when running the ptest in a minimal image. Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
2019-06-01libtimedate-perl: Fix ptest dependenciesRichard Purdie
This fixes runtime errors when running the ptest in a minimal image. Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
2019-06-01sysstat: add UPSTREAM_VERSION_UNKNOWNAlexander Kanavin
We are taking a development version from an odd-even versioned project, so upstream version check reports that the latest version is less than the one the recipe is using. UPSTREAM_VERSION_UNKNOWN avoids a version check failure until there is a new stable series. Signed-off-by: Alexander Kanavin <alex.kanavin@gmail.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
2019-06-01bash: run bash ptest as non-root userSakib Sajal
new-exp ptest fails as it expects non-root user. >From the failed ptest log: < new-exp.tests: the test suite should not be run as root 628c627 < argv[1] = <host(2)[5.0]# > --- > argv[1] = <host(2)[5.0]$ > FAIL: run-new-exp Many of the ptests declare that they should not be run as root and a few fail since the expected result strings are for a user shell. When ptests are run as bash_user (non-root) the glob test fails with error: run-glob-test 59,60d58 < touch: cannot touch 'a?': Permission denied < touch: cannot touch 'aa': Permission denied So ensure that the bash/ptest/tests directory is owned by the bash_user while the tests are being run and return it to root owner afterwards. Signed-off-by: Sakib Sajal <sakib.sajal@windriver.com> Signed-off-by: Randy Macleod <randy.macleod@windriver.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
2019-06-01bash: add big5hkscs gconv RDEPENDS needed by bash-ptest.Sakib Sajal
glob-test failed beacuse it could not convert big5hkscs encoding to perform comparison. Signed-off-by: Sakib Sajal <sakib.sajal@windriver.com> Signed-off-by: Randy Macleod <randy.macleod@windriver.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
2019-05-30bc: use u-a for bc as wellMartin Jansa
* bc can be provided by busybox as well (e.g. if you have your own defconfig and forget to explicitly disable it: ... * * Miscellaneous Utilities * adjtimex (4.7 kb) (ADJTIMEX) [N/y/?] n bbconfig (9.7 kb) (BBCONFIG) [N/y/?] n bc (45 kb) (BC) [Y/n/?] (NEW) dc (36 kb) (DC) [Y/n/?] y Use bc code base for dc (larger, more features) (FEATURE_DC_BIG) [Y] (NEW) y Interactive mode (+4kb) (FEATURE_BC_INTERACTIVE) [Y/n/?] (NEW) Enable bc/dc long options (FEATURE_BC_LONG_OPTIONS) [Y/n] (NEW) beep (2.4 kb) (BEEP) [N/y/?] n chat (6.3 kb) (CHAT) [N/y/?] n conspy (10 kb) (CONSPY) [N/y/?] n ... ), causing conflict in u-a: update-alternatives: Error: not linking /usr/bin/bc to /bin/busybox.nosuid since /usr/bin/bc exists and is not a link and then whole do_rootfs or do_populate_sdk to fail because busybox postinst is failing: do_populate_sdk: Postinstall scriptlets of ['busybox'] have failed. If the intention is to defer them to first boot, then please place them into pkg_postinst_ontarget_${PN} (). Deferring to first boot via 'exit 1' is no longer supported. Signed-off-by: Martin Jansa <Martin.Jansa@gmail.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
2019-05-30Revert "pigz: pigz is not gzip"Anuj Mittal
This reverts commit a54c59f2a24904daffe51582b6863eebd071db0d. The compatibility issues have since been resolved [1][2] and pigz 2.4 annoucement also states that this can be considered as a drop-in replacemment [3] now. [1] https://github.com/madler/pigz/commit/33c140e5fdc5cd639d1e7cc3c5e52ec016aa8a65 [2] https://github.com/madler/pigz/commit/6fda8570f633ec582ba72ea00dad2bbac825bc17 [3] https://zlib.net/pipermail/pigz-announce_zlib.net/2017-December/000028.html Signed-off-by: Anuj Mittal <anuj.mittal@intel.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
2019-05-30packagegroup-core-full-cmdline: Make nfs-utils/rpcbind optionalOliver Stäbler
Consider DISTRO_FEATURES for nfs-utils and rpcbind. This is to prevent the following warning while booting: NFS daemon support not enabled in kernel Signed-off-by: Oliver Stäbler <oliver.staebler@bytesatwork.ch> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
2019-05-30mdadm: Add missing ptest dependencyRichard Purdie
Without this the ptest fails, unable to find mkfs.ext3. Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
2019-05-29bash: add iso8859-1 gconv RDEPENDS needed by bash-ptest.Sakib Sajal
One of the ptests failed for internationalization. >From the failed ptest log: run-intl fr_FR.ISO8859-1: Error Encoding U+00000080 to [ "$'\200'" != "\\u0080" ] (125 similar errors related to same encoding) The test was unable to convert iso8859-1 encoding to perform comparison. Signed-off-by: Sakib Sajal <sakib.sajal@windriver.com> Signed-off-by: Randy Macleod <randy.macleod@windriver.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
2019-05-28ethtool: update to 5.1Oleksandr Kravchuk
Changelog: * Feature: Add support for 200Gbps (50Gbps per lane) link mode * Feature: simplify handling of PHY tunable downshift * Feature: add support for PHY tunable Fast Link Down * Feature: add PHY Fast Link Down tunable to man page * Feature: Add a 'start N' option when specifying the Rx flow hash indirection table. * Feature: Add bash-completion script * Feature: add 10000baseR_FEC link mode name * Fix: qsfp: fix special value comparison * Feature: move option parsing related code into function * Feature: move cmdline_coalesce out of do_scoalesce * Feature: introduce new ioctl for per-queue settings * Feature: support per-queue sub command --show-coalesce * Feature: support per-queue sub command --coalesce * Fix: fix up dump_coalesce output to match actual option names * Feature: fec: add pretty dump Signed-off-by: Oleksandr Kravchuk <open.source@oleksandr-kravchuk.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
2019-05-27chkconfig: fix upstream version checkAlexander Kanavin
Signed-off-by: Alexander Kanavin <alex.kanavin@gmail.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
2019-05-27chkconfig: do not use unstable github archive tarballsAlexander Kanavin
Signed-off-by: Alexander Kanavin <alex.kanavin@gmail.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
2019-05-27texinfo-dummy-native: Rewrite template.py to use argparsePeter Kjellerstedt
The original version of template.py parses the arguments manually. This fails when looking for the -E option if, e.g., an -I option is specified without any space before its argument, and that argument contains the letter 'E'. A minor difference to the original version is that it parsed the arguments in the order they were specified on the command line whereas this version will always handle -E before -o. Signed-off-by: Peter Kjellerstedt <peter.kjellerstedt@axis.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
2019-05-27texinfo-dummy-native: A little clean up of template.pyPeter Kjellerstedt
This is mainly whitespace clean up, plus using the with statement when writing files. Signed-off-by: Peter Kjellerstedt <peter.kjellerstedt@axis.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
2019-05-27mdadm: use ${systemd_unitdir} rather than /lib/systemdLuca Boccassi
Fixes build with usrmerge enabled. Signed-off-by: Luca Boccassi <luca.boccassi@microsoft.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
2019-05-27m4/tar: Remove remove-gets.patchAdrian Bunk
When the original problem was fixed in gnulib the patches were rebased on top of the upstream fix... Signed-off-by: Adrian Bunk <bunk@stusta.de> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
2019-05-22perl/modules: Add various missing ptest perl module dependenciesRichard Purdie
Whilst not complete, this resolves some module dependency failures being seen by various lib*-perl ptests and in quilt. Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
2019-05-22bash: Fix bash-ptest dependenciesRichard Purdie
Bash's ptest needs glibc-utils (for locale), some extra locales for various tests it uses options busybox doesn't support for some tools, hence coreutils and also runs perl for some tests. Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
2019-05-22acpica: upgrade 20190405 -> 20190509Alexander Kanavin
Signed-off-by: Alexander Kanavin <alex.kanavin@gmail.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
2019-05-22gawk: upgrade 4.2.1 -> 5.0.0Alexander Kanavin
Signed-off-by: Alexander Kanavin <alex.kanavin@gmail.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
2019-05-16gettext/flex/m4/bzip2/gzip/parted/slang/attr: Add make to -ptest packagesRichard Purdie
This solves ptest runtime errors where make was missing causing the ptests to fail. Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
2019-05-16mdadm: install the systemd service through MakefileLiwei Song
The original mdadm service may include variable like BINDIR, It should use the real value of it, since the install method "install-systemd" in Makefile can easily do such work, so don't install it in bb file manually, use "make install-systemd" to install all the service of mdadm. Signed-off-by: Liwei Song <liwei.song@windriver.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
2019-05-16sysstat: Add PACKAGECONFIG[cron] for '--enable-install-cron' optionHaiqing Bai
If 'cron' is added into PACKAGECONFIG, for sysvinit, the related cron scripts will be installed; for systemd, the services of data collect and summary will be installed. Signed-off-by: Haiqing Bai <Haiqing.Bai@windriver.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
2019-05-13groff: imporve musl supportHongxu Jia
Drop local fix, backport upstream gnulib fix and translate to tarball groff. Suggested-by: Adrian Bunk <bunk@stusta.de> Signed-off-by: Hongxu Jia <hongxu.jia@windriver.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
2019-05-12ghostscript: 9.26 -> 9.27Hongxu Jia
- Rebase ghostscript-9.02-genarch.patch - Drop backported CVE patches Signed-off-by: Hongxu Jia <hongxu.jia@windriver.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
2019-05-12groff: upgrade 1.22.3 -> 1.22.4Hongxu Jia
- Drop groff-1.22.2-correct-man.local-install-path.patch and 0001-Unset-need_charset_alias-when-building-for-musl.patch - Inherit bbclass pkgcnofig to fix `undefined macro: AC_DEFINE' ... | configure:20010: error: possibly undefined macro: AC_DEFINE ... - Use autotools-brokensep to replace autotools to workaround failure caused by out of tree ... | rm -f lib/alloca.h-t lib/alloca.h && \ | { echo '/* DO NOT EDIT! GENERATED AUTOMATICALLY! */'; \ | cat ../groff-1.22.4/lib/alloca.in.h; \ | } > lib/alloca.h-t && \ | mv -f lib/alloca.h-t lib/alloca.h | /bin/sh: line 4: lib/alloca.h-t: No such file or directory | Makefile:10407: recipe for target 'lib/alloca.h' failed ... - Add `--without-doc' to not use target groff to generate doc at build time, since upstream commit [cfe916e Support of configure option to build the documentation.] - Remove groff depends groff-native, and add DEPENDS bison-native - Add 0001-fix-shebang-for-taget.patch - Add 0001-support-musl.patch Signed-off-by: Hongxu Jia <hongxu.jia@windriver.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
2019-05-12bash: upgrade 4.4.18 -> 5.0Hongxu Jia
- Rebase build-tests.patch and execute_cmd.patch to 5.0 - Drop 0001-help-fix-printf-format-security-warning.patch and pathexp-dep.patch, upstream has fixed them in commit [d233b48 bash-5.0 distribution sources and documentation] Signed-off-by: Hongxu Jia <hongxu.jia@windriver.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>