diff options
| author |   Ulf Magnusson <ulfalizer@gmail.com> | 2016-10-01 04:47:09 +0200 |
|---|---|---|
| committer |   Richard Purdie <richard.purdie@linuxfoundation.org> | 2016-10-03 15:46:21 +0100 |
| commit | de45a7e302fe5a2a08baf26c91e2c788d7285263 (patch) | |
| tree | 71ee6f5fb8254511d988dd1a2e354b6dbd490474 /meta | |
| parent | 8443b6f3f25181f5ac49bc25a1387cd05b814376 (diff) | |
| download | openembedded-core-contrib-de45a7e302fe5a2a08baf26c91e2c788d7285263.tar.gz | |
utility-tasks.bbclass: Use bb.fatal() instead of raising FuncFailed
This sets a good example and avoids unnecessarily contributing to
perceived complexity and cargo culting.
Motivating quote below:
< kergoth> the *original* intent was for the function/task to error via
whatever appropriate means, bb.fatal, whatever, and
funcfailed was what you'd catch if you were calling
exec_func/exec_task. that is, it's what those functions
raise, not what metadata functions should be raising
< kergoth> it didn't end up being used that way
< kergoth> but there's really never a reason to raise it yourself
FuncFailed.__init__ takes a 'name' argument rather than a 'msg'
argument, which also shows that the original purpose got lost.
Signed-off-by: Ulf Magnusson <ulfalizer@gmail.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
Diffstat (limited to 'meta')
| -rw-r--r-- | meta/classes/utility-tasks.bbclass | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/meta/classes/utility-tasks.bbclass b/meta/classes/utility-tasks.bbclass index 7bc584abb9..7ba56e28ae 100644 --- a/meta/classes/utility-tasks.bbclass +++ b/meta/classes/utility-tasks.bbclass @@ -47,7 +47,7 @@ python do_checkuri() { fetcher = bb.fetch2.Fetch(src_uri, d) fetcher.checkstatus() except bb.fetch2.BBFetchException as e: - raise bb.build.FuncFailed(e) + bb.fatal(str(e)) } addtask checkuriall after do_checkuri |