diff options
| author |   Hongxu Jia <hongxu.jia@windriver.com> | 2014-08-11 12:39:53 +0800 |
|---|---|---|
| committer |   Richard Purdie <richard.purdie@linuxfoundation.org> | 2014-08-23 23:01:36 +0100 |
| commit | 2281180499cf3bec5c7e75cb596725dab190f72c (patch) | |
| tree | a497f65d8dd1310863329cbddde34737208677d1 /meta/recipes-sato/puzzles | |
| parent | 20992e8a00c585ab6b0611ca23ccd57e2b86b727 (diff) | |
| download | openembedded-core-contrib-2281180499cf3bec5c7e75cb596725dab190f72c.tar.gz | |
puzzles: fix do_compile failed when DEBUG_BUILD
There were compiling failure with option -g -O
...
././gtk.c: In function 'configure_area':
././gtk.c:397:2: error: 'cr' may be used uninitialized in this function [-Werror=maybe-uninitialized]
cairo_set_source_rgb(cr,
^
././gtk.c:384:14: note: 'cr' was declared here
cairo_t *cr;
^
././gtk.c: In function 'main':
././gtk.c:2911:6: error: 'error' may be used uninitialized in this function [-Werror=maybe-uninitialized]
fprintf(stderr, "%s: %s\n", pname, error);
^
cc1: all warnings being treated as errors
...
Initialized the pointers 'cr' and 'error' with NULL
[YOCTO #6410]
Signed-off-by: Hongxu Jia <hongxu.jia@windriver.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
Diffstat (limited to 'meta/recipes-sato/puzzles')
| -rw-r--r-- | meta/recipes-sato/puzzles/files/fix-compiling-failure-with-option-g-O.patch | 52 | ||||
| -rw-r--r-- | meta/recipes-sato/puzzles/puzzles_r10116.bb | 4 |
2 files changed, 55 insertions, 1 deletions
diff --git a/meta/recipes-sato/puzzles/files/fix-compiling-failure-with-option-g-O.patch b/meta/recipes-sato/puzzles/files/fix-compiling-failure-with-option-g-O.patch new file mode 100644 index 00000000000..d246feeb091 --- /dev/null +++ b/meta/recipes-sato/puzzles/files/fix-compiling-failure-with-option-g-O.patch @@ -0,0 +1,52 @@ +gtk.c: fix compiling failure with option -g -O + +There were compiling failure with option -g -O +... +././gtk.c: In function 'configure_area': +././gtk.c:397:2: error: 'cr' may be used uninitialized in this function [-Werror=maybe-uninitialized] + cairo_set_source_rgb(cr, + ^ +././gtk.c:384:14: note: 'cr' was declared here + cairo_t *cr; + ^ +././gtk.c: In function 'main': +././gtk.c:2911:6: error: 'error' may be used uninitialized in this function [-Werror=maybe-uninitialized] + fprintf(stderr, "%s: %s\n", pname, error); + ^ +cc1: all warnings being treated as errors +... + +Initialized pointer 'cr' and 'error' with NULL + +Upstream-Status: Pending + +Signed-off-by: Hongxu Jia <hongxu.jia@windriver.com> +--- + gtk.c | 4 ++-- + 1 file changed, 2 insertions(+), 2 deletions(-) + +diff --git a/gtk.c b/gtk.c +index a2eba2c..c54bf63 100644 +--- a/gtk.c ++++ b/gtk.c +@@ -381,7 +381,7 @@ static void clear_backing_store(frontend *fe) + + static void setup_backing_store(frontend *fe) + { +- cairo_t *cr; ++ cairo_t *cr = NULL; + int i; + + fe->pixmap = gdk_pixmap_new(fe->area->window, fe->pw, fe->ph, -1); +@@ -2481,7 +2481,7 @@ char *fgetline(FILE *fp) + int main(int argc, char **argv) + { + char *pname = argv[0]; +- char *error; ++ char *error = NULL; + int ngenerate = 0, print = FALSE, px = 1, py = 1; + int time_generation = FALSE, test_solve = FALSE, list_presets = FALSE; + int soln = FALSE, colour = FALSE; +-- +1.9.1 + diff --git a/meta/recipes-sato/puzzles/puzzles_r10116.bb b/meta/recipes-sato/puzzles/puzzles_r10116.bb index ef5392b68f6..6ee4d962b2b 100644 --- a/meta/recipes-sato/puzzles/puzzles_r10116.bb +++ b/meta/recipes-sato/puzzles/puzzles_r10116.bb @@ -7,7 +7,9 @@ MOD_PV = "${@d.getVar('PV',1)[1:]}" LICENSE = "MIT" LIC_FILES_CHKSUM = "file://LICENCE;md5=33bcd4bce8f3c197f2aefbdbd2d299bc" -SRC_URI = "svn://svn.tartarus.org/sgt;module=puzzles;rev=${MOD_PV}" +SRC_URI = "svn://svn.tartarus.org/sgt;module=puzzles;rev=${MOD_PV} \ + file://fix-compiling-failure-with-option-g-O.patch \ +" S = "${WORKDIR}/${BPN}" |