diff options
| author |   Richard Purdie <richard.purdie@linuxfoundation.org> | 2017-11-21 11:42:54 +0000 |
|---|---|---|
| committer | Richard Purdie <richard.purdie@linuxfoundation.org> | 2017-11-21 13:10:13 +0000 |
| commit | 1e87283e92a2765bb5d54d17138b208bc395953b (patch) | |
| tree | 3facb629152e3885e855890cfce4b49233cb272b /meta/lib | |
| parent | 55a0028a961c0ad3c2e5729a9e3919cbbf256fe1 (diff) | |
| download | openembedded-core-contrib-1e87283e92a2765bb5d54d17138b208bc395953b.tar.gz | |
qemurunner: Simplify binary data handling
I have concerns that bad timing of the flow of data from the logger
might corrupt the output due to the way binary strings are handled
in qemurunner.
This simplifies the code to do the same thing it did before but much
more safely.
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
Diffstat (limited to 'meta/lib')
| -rw-r--r-- | meta/lib/oeqa/utils/qemurunner.py | 20 |
1 files changed, 8 insertions, 12 deletions
diff --git a/meta/lib/oeqa/utils/qemurunner.py b/meta/lib/oeqa/utils/qemurunner.py index 82335d84562..0631d43218f 100644 --- a/meta/lib/oeqa/utils/qemurunner.py +++ b/meta/lib/oeqa/utils/qemurunner.py @@ -275,7 +275,7 @@ class QemuRunner: reachedlogin = False stopread = False qemusock = None - bootlog = '' + bootlog = b'' data = b'' while time.time() < endtime and not stopread: try: @@ -292,17 +292,13 @@ class QemuRunner: else: data = data + sock.recv(1024) if data: - try: - data = data.decode("utf-8", errors="surrogateescape") - bootlog += data - data = b'' - if re.search(".* login:", bootlog): - self.server_socket = qemusock - stopread = True - reachedlogin = True - self.logger.debug("Reached login banner") - except UnicodeDecodeError: - continue + bootlog += data + data = b'' + if b' login:' in bootlog: + self.server_socket = qemusock + stopread = True + reachedlogin = True + self.logger.debug("Reached login banner") else: socklist.remove(sock) sock.close() |