diff options
author | Ross Burton <ross.burton@intel.com> | 2019-03-13 00:37:33 +0000 |
---|---|---|
committer | Richard Purdie <richard.purdie@linuxfoundation.org> | 2020-01-27 16:38:54 +0000 |
commit | 91b74ee03ada5d4517a5d8ef3895cc60f87780aa (patch) | |
tree | 54bf18104f55bb7b161c007e46188b34d700015b /meta/classes/meson.bbclass | |
parent | ed223207e0b6e25c18ce90d8e6fb1e5713d4cd0a (diff) | |
download | openembedded-core-contrib-91b74ee03ada5d4517a5d8ef3895cc60f87780aa.tar.gz |
meson.bbclass: warn if cross property defaults are used
The Meson idiom for checks which require running code on the target
(which isn't possible in cross compilation) is to use a cross property,
which the user can set in the cross file:
if cc_can_run
rres = cc.run(test_foo_code)
have_foo = rres.compiled() and rres.returncode() == 0
else
have_foo = meson.get_cross_property('have_foo', false)
endif
The default value may be overly conservative so we should review every
property and explicitly set them as apppropriate. oe-core 669ddaf added
a log message when the default value is used, so look for this message
and emit a warning that the user will see.
Signed-off-by: Ross Burton <ross.burton@intel.com>
Diffstat (limited to 'meta/classes/meson.bbclass')
-rw-r--r-- | meta/classes/meson.bbclass | 9 |
1 files changed, 9 insertions, 0 deletions
diff --git a/meta/classes/meson.bbclass b/meta/classes/meson.bbclass index 1ef34a999c..9c3673ea42 100644 --- a/meta/classes/meson.bbclass +++ b/meta/classes/meson.bbclass @@ -158,6 +158,15 @@ meson_do_configure_prepend_class-native() { export PKG_CONFIG="pkg-config-native" } +python meson_do_qa_configure() { + import re + warn_re = re.compile(r"^WARNING: Cross property (.+) is using default value (.+)$", re.MULTILINE) + log = open(d.expand("${B}/meson-logs/meson-log.txt")).read() + for (prop, value) in warn_re.findall(log): + bb.warn("Meson cross property %s used without explicit assignment, defaulting to %s" % (prop, value)) +} +do_configure[postfuncs] += "meson_do_qa_configure" + do_compile[progress] = "outof:^\[(\d+)/(\d+)\]\s+" meson_do_compile() { ninja -v ${PARALLEL_MAKE} |