diff options
| author |   Ross Burton <ross.burton@intel.com> | 2019-08-01 16:09:44 +0100 |
|---|---|---|
| committer |   Richard Purdie <richard.purdie@linuxfoundation.org> | 2019-08-03 23:56:01 +0100 |
| commit | 89a27680008dbe7a02016afc94fd62a05b0c9ff6 (patch) | |
| tree | 34b05168ae03350bfdb7870e1abef5c844a6412c | |
| parent | 06e36f13bf512e46106ec3769f129e0d4a6d4a78 (diff) | |
| download | openembedded-core-contrib-89a27680008dbe7a02016afc94fd62a05b0c9ff6.tar.gz | |
insane: check if the recipe incorrectly uses DEPENDS_${PN}
Some people mistakenly use DEPENDS_${PN} and wonder why the dependencies don't
work. Check for this and tell the user to use DEPENDS.
(From OE-Core rev: cfaa104955c4ad0aafbe5d59ef85e4a8e3526c69)
Signed-off-by: Ross Burton <ross.burton@intel.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
| -rw-r--r-- | meta/classes/insane.bbclass | 5 |
1 files changed, 5 insertions, 0 deletions
diff --git a/meta/classes/insane.bbclass b/meta/classes/insane.bbclass index 891d3a8421..35c4fdb491 100644 --- a/meta/classes/insane.bbclass +++ b/meta/classes/insane.bbclass @@ -1237,6 +1237,11 @@ python () { if prog.search(pn): package_qa_handle_error("uppercase-pn", 'PN: %s is upper case, this can result in unexpected behavior.' % pn, d) + # Some people mistakenly use DEPENDS_${PN} instead of DEPENDS and wonder + # why it doesn't work. + if (d.getVar(d.expand('DEPENDS_${PN}'))): + package_qa_handle_error("pkgvarcheck", "recipe uses DEPENDS_${PN}, should use DEPENDS", d) + issues = [] if (d.getVar('PACKAGES') or "").split(): for dep in (d.getVar('QADEPENDS') or "").split(): |