diff options
| author |   Robert Yang <liezhi.yang@windriver.com> | 2016-04-26 19:20:26 -0700 |
|---|---|---|
| committer |   Richard Purdie <richard.purdie@linuxfoundation.org> | 2016-05-06 10:30:59 +0100 |
| commit | b7811bbec1ba373d62ace5c4fc56918e53c69d50 (patch) | |
| tree | b070be393b256f7b66f38af8111b4b6a6430b5d2 | |
| parent | 739da8b205067588419303ec2bbb1d92a82cdae9 (diff) | |
| download | openembedded-core-contrib-b7811bbec1ba373d62ace5c4fc56918e53c69d50.tar.gz | |
insane.bbclass: package_qa_check_license -> populate_lic_qa_checksum
The package_qa_check_license() was in do_qa_configure which had a
potential problem, when the recipe sets do_configure[noexec] = "1", then
the license checking won't run, which may hidden license issues. Rename
it to populate_lic_qa_checksum() and run in do_populate_lic[postfuncs] which
is more reasonable (when no populate license, no license checking).
Signed-off-by: Robert Yang <liezhi.yang@windriver.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
| -rw-r--r-- | meta/classes/insane.bbclass | 15 |
1 files changed, 6 insertions, 9 deletions
diff --git a/meta/classes/insane.bbclass b/meta/classes/insane.bbclass index a1d23d055b..097dc3a001 100644 --- a/meta/classes/insane.bbclass +++ b/meta/classes/insane.bbclass @@ -672,7 +672,9 @@ def package_qa_check_symlink_to_sysroot(path, name, d, elf, messages): trimmed = path.replace(os.path.join (d.getVar("PKGDEST", True), name), "") package_qa_add_message(messages, "symlink-to-sysroot", "Symlink %s in %s points to TMPDIR" % (trimmed, name)) -def package_qa_check_license(d): +# Check license variables +do_populate_lic[postfuncs] += "populate_lic_qa_checksum" +python populate_lic_qa_checksum() { """ Check for changes in the license files """ @@ -753,6 +755,7 @@ def package_qa_check_license(d): msg = pn + ": LIC_FILES_CHKSUM is not specified for " + url msg = msg + "\n" + pn + ": The md5 checksum is " + md5chksum package_qa_handle_error("license-checksum", msg, d) +} def package_qa_check_staged(path,d): """ @@ -1208,12 +1211,6 @@ Rerun configure task after fixing this.""") Missing inherit gettext?""" % (gt, config)) ########################################################################### - # Check license variables - ########################################################################### - - package_qa_check_license(d) - - ########################################################################### # Check unrecognised configure options (with a white list) ########################################################################### if bb.data.inherits_class("autotools", d): @@ -1261,8 +1258,8 @@ python do_qa_unpack() { #addtask qa_staging after do_populate_sysroot before do_build do_populate_sysroot[postfuncs] += "do_qa_staging " -# Check broken config.log files, for packages requiring Gettext which don't -# have it in DEPENDS and for correct LIC_FILES_CHKSUM +# Check broken config.log files, for packages requiring Gettext which +# don't have it in DEPENDS. #addtask qa_configure after do_configure before do_compile do_configure[postfuncs] += "do_qa_configure " |