summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorJagadeesh Krishnanjanappa <jkrishnanjanappa@mvista.com>2015-11-28 13:39:54 +0530
committerRichard Purdie <richard.purdie@linuxfoundation.org>2016-03-09 16:54:36 +0000
commita411e96c3989bc9ffbd870b54cd6a7ad2e9f2c61 (patch)
tree52e1445e49a3a57551c8eee6d2e298698be0aad9
parent8adaad7f3a76d527f34d2caa4b032beba7e21840 (diff)
downloadopenembedded-core-contrib-a411e96c3989bc9ffbd870b54cd6a7ad2e9f2c61.tar.gz
openembedded-core-contrib-a411e96c3989bc9ffbd870b54cd6a7ad2e9f2c61.tar.bz2
openembedded-core-contrib-a411e96c3989bc9ffbd870b54cd6a7ad2e9f2c61.zip
license.bbclass: fix host contamination warnings for license files
We get below host contamination warnings of license files for each recipe, when we try to create a separate ${PN}-lic package (which contains license files), by setting LICENSE_CREATE_PACKAGE equal to "1" in local.conf. -- snip -- WARNING: QA Issue: libcgroup: /libcgroup-lic/usr/share/licenses/libcgroup/generic_LGPLv2.1 is owned by uid 5001, which is the same as the user running bitbake. This may be due to host contamination [host-user-contaminated] WARNING: QA Issue: attr: /attr-lic/usr/share/licenses/attr/libattr.c is owned by uid 5001, which is the same as the user running bitbake. This may be due to host contamination [host-user-contaminated] WARNING: QA Issue: bash: /bash-lic/usr/share/licenses/bash/COPYING is owned by uid 5001, which is the same as the user running bitbake. This may be due to host contamination [host-user-contaminated] -- CUT -- Since the license files from source and OE-core, are populated in a normal shell environment rather in pseudo environment (fakeroot); the ownership of these files will be same as host user running bitbake. During the do_package task (which runs in pseudo environment (fakeroot)), os.link preserves the ownership of these license files as host user instead of root user. This causes license files to have UID same as host user id and resulting in above warnings during do_package_qa task. Changing ownership of license files to root user (which has UID and GID as 0) under pseudo environment will solve above warnings, and on exiting pseudo environment the license files will continue to be owned by host user. Perform this manipulation within try/except statements, as tasks which are not exected under pseudo (such as do_populate_lic) result in OSError when trying to change ownership of license files. Signed-off-by: Jagadeesh Krishnanjanappa <jkrishnanjanappa@mvista.com> Signed-off-by: Ross Burton <ross.burton@intel.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
-rw-r--r--meta/classes/license.bbclass10
1 files changed, 10 insertions, 0 deletions
diff --git a/meta/classes/license.bbclass b/meta/classes/license.bbclass
index a7f377361c..ba95c9ac84 100644
--- a/meta/classes/license.bbclass
+++ b/meta/classes/license.bbclass
@@ -350,6 +350,16 @@ def copy_license_files(lic_files_paths, destdir):
os.remove(dst)
if os.access(src, os.W_OK) and (os.stat(src).st_dev == os.stat(destdir).st_dev):
os.link(src, dst)
+ try:
+ os.chown(dst,0,0)
+ except OSError as err:
+ import errno
+ if err.errno == errno.EPERM:
+ # suppress "Operation not permitted" error, as
+ # sometimes this function is not executed under pseudo
+ pass
+ else:
+ raise
else:
shutil.copyfile(src, dst)
except Exception as e: