summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorEd Bartosh <ed.bartosh@linux.intel.com>2016-04-06 17:46:48 +0100
committerRichard Purdie <richard.purdie@linuxfoundation.org>2016-04-06 23:00:11 +0100
commitd056cf40fc55530cb1736aedfb9a3c355884991e (patch)
tree2386a21928c566c958ab956e77cadd60a7c00bf4
parentc39cc463e6d9594bf2c5ac8bb74e834f6f2cf7c8 (diff)
downloadopenembedded-core-contrib-d056cf40fc55530cb1736aedfb9a3c355884991e.tar.gz
toasterui: update build in internal state
buildinfohelper stores current Build object in its internal state. Any changes to Build object will be lost if internal state is not updated as current buildinfohelper code saves Build object from internal state when build is completed. This bug causes incorrect build state when build is cancelled. Updating internal state should fix it. Note, that this commit updates internal state after status of the build is changed to Build.CANCELLED. There are several other places in the code where Build object is updated without updating internal state. They should be carefully analyzed and fixed. Signed-off-by: Ed Bartosh <ed.bartosh@linux.intel.com> Signed-off-by: Michael Wood <michael.g.wood@intel.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
-rw-r--r--lib/bb/ui/buildinfohelper.py1
1 files changed, 1 insertions, 0 deletions
diff --git a/lib/bb/ui/buildinfohelper.py b/lib/bb/ui/buildinfohelper.py
index 9cb2c54067..1473a67222 100644
--- a/lib/bb/ui/buildinfohelper.py
+++ b/lib/bb/ui/buildinfohelper.py
@@ -1420,6 +1420,7 @@ class BuildInfoHelper(object):
logger.info("Build cancelled")
br.build.outcome = Build.CANCELLED
br.build.save()
+ self.internal_state['build'] = br.build
errorcode = 0
if errorcode == 0: