aboutsummaryrefslogtreecommitdiffstats
path: root/meta-oe/recipes-devtools
AgeCommit message (Collapse)Author
2018-12-18flatbuffers: update to 1.10.0Adrian Freihofer
This is in fact an update from 1.7.1 to 1.10.0. (The git hash of the 1.9.0 recipe referred flatbuffers release 1.7.1.) This patch is obsolete, a similar fix has been applied upstream: - 0001-correct-version-for-so-lib.patch These two patches have been applied upstream: - 0001-flatbuffers-Move-EndianSwap-template-to-flatbuffers-.patch - 0002-use-__builtin_bswap16-when-building-with-clang.patch Signed-off-by: Adrian Freihofer <adrian.freihofer@gmail.com> Signed-off-by: Khem Raj <raj.khem@gmail.com>
2018-12-07doxygen: Use SOURCEFORGE_MIRROR for SRC_URIKhem Raj
Signed-off-by: Khem Raj <raj.khem@gmail.com>
2018-12-05tk: Upgrade to 8.6.9Khem Raj
Use tcl8.6 instead of tcl8.5 in confsearch.diff patch Signed-off-by: Khem Raj <raj.khem@gmail.com>
2018-12-04nodejs: 8.12.0 -> 8.14.0Andrej Valek
Update nodejs to latest 8.x stable release 8.14.0. Signed-off-by: Andrej Valek <andrej.valek@siemens.com> Signed-off-by: Khem Raj <raj.khem@gmail.com>
2018-12-02python-pygobject: Tune remove operationNiko Mauno
Drop '-f, --force' operator from rm command as that will hide the fact if the removed artifacts cease to exist in later version of this recipe. Also drop a superfluous slash from artifact path. Signed-off-by: Niko Mauno <niko.mauno@iki.fi> Signed-off-by: Khem Raj <raj.khem@gmail.com>
2018-12-02python-pygobject: Fix style issueNiko Mauno
Add missing space characters around the operator in SRCNAME declaration Signed-off-by: Niko Mauno <niko.mauno@iki.fi> Signed-off-by: Khem Raj <raj.khem@gmail.com>
2018-12-02python-pygobject: Remove duplication in inheritNiko Mauno
Reflect following change in Pythonv3 variant of this recipe http://git.yoctoproject.org/cgit/cgit.cgi/poky/commit/meta?id=a195e0471d0df0ac26e00d6fcb3a2786e080a643 and drop redundant inherit for autotools and pkgconfig also here Signed-off-by: Niko Mauno <niko.mauno@iki.fi> Signed-off-by: Khem Raj <raj.khem@gmail.com>
2018-12-02python-pygobject: Only check for even upstream versionsNiko Mauno
Reflect following change in Pythonv3 variant of this recipe http://git.yoctoproject.org/cgit/cgit.cgi/poky/commit/meta?id=fed093329b504cd46aa758983db6073b70c2af29 and add inherit for upstream-version-is-even.bbclass Signed-off-by: Niko Mauno <niko.mauno@iki.fi> Signed-off-by: Khem Raj <raj.khem@gmail.com>
2018-12-02python-pygobject: Drop redundant dependenciesNiko Mauno
Simplify recipe by reflecting following changes introduced to Pythonv3 variant of this recipe in commits http://git.yoctoproject.org/cgit/cgit.cgi/poky/commit/meta?id=b663374cf41465c6dc94001d6fa73a5523542fb6 http://git.yoctoproject.org/cgit/cgit.cgi/poky/commit/meta?id=521ea98b2c622f5ae7e6d18849a0379fa7ed4e90 in which the gnome-common dependency was left out due to pygobject moving to autoconf-archive, and remaining configure.ac patch file was also deemed unnecessary. Signed-off-by: Niko Mauno <niko.mauno@iki.fi> Signed-off-by: Khem Raj <raj.khem@gmail.com>
2018-12-02python-pygobject: Drop redundant PYTHON* refsNiko Mauno
Remove redundant PYTHON* declarations/references as this recipe builds now correctly without them. Signed-off-by: Niko Mauno <niko.mauno@iki.fi> Signed-off-by: Khem Raj <raj.khem@gmail.com>
2018-12-02python-pygobject: Fix invalid install pathNiko Mauno
http://git.yoctoproject.org/cgit/cgit.cgi/poky/commit/meta?id=1dccb37d89f54d7284b6a81957ab228906f24e1c has replaced PYTHON_PN references with hardcoded 'python' and 'python3' strings in pythonnative.bbclass and python3native.bbclass, respectively. Associated commit message states: "If both are inherited then both native Pythons are available, but the last to be inherited will be the one to set PYTHON." Since after the above-mentioned commit this Pythonv2 recipe installs wrongly into /usr/lib/python3.5/ directory, move inherit of distutils-base.bbclass (which inherits pythonnative.bbclass) to right hand side of gobject-introspection.bbclass (which inherits python3native.bbclass) which changes the install path back to /usr/lib/python2.7/ mitigating the issue. Signed-off-by: Niko Mauno <niko.mauno@iki.fi> Signed-off-by: Khem Raj <raj.khem@gmail.com>
2018-11-27libgee: Upgrade to 0.20.1Khem Raj
Signed-off-by: Khem Raj <raj.khem@gmail.com>
2018-11-27doxygen: new packageBartosz Golaszewski
Doxygen binary is necessary to generate C++ bindings for libsigrok. Signed-off-by: Bartosz Golaszewski <brgl@bgdev.pl> Signed-off-by: Khem Raj <raj.khem@gmail.com>
2018-11-15log4cplus: Upgrade to 2.0.2Mingli Yu
Signed-off-by: Mingli Yu <mingli.yu@windriver.com> Signed-off-by: Khem Raj <raj.khem@gmail.com>
2018-11-14tk: export TK_LIBRARY='${libdir}/tk${VER}'Mingli Yu
As there is below logic in configure.in [snip] test -z "$TK_LIBRARY" && TK_LIBRARY='$(prefix)/lib/tk$(VERSION)' [snip] It can make TK_LIBRARY to be $(prefix)/lib/tk$(VERSION) and then result in some files installed to /usr/lib/tk8.6 even when ${libdir} actually extract as /usr/lib64 and there is also a commit as below adding hack to workaround this. 1ca29d1cd tk: make multilib build compatible and fix library install Export TK_LIBRARY='${libdir}/tk${VER}' to guarantee the files installed to the expected places and also remove the workaround in the previous commit 1ca29d1cd. Signed-off-by: Mingli Yu <Mingli.Yu@windriver.com> Signed-off-by: Khem Raj <raj.khem@gmail.com>
2018-11-14tk: update the parameter for --with-tclMingli Yu
Update the parameter for --with-tcl to fix below do_configure issue: $ bitbake tk-native | checking for Tcl configuration... configure: error: /mybuild/tmp/work/x86_64-linux/tk-native/8.6.8-r0/recipe-sysroot-native/usr/bin directory doesn't contain tclConfig.sh Signed-off-by: Mingli Yu <Mingli.Yu@windriver.com> Signed-off-by: Khem Raj <raj.khem@gmail.com>
2018-11-08tk: extend to nativesdkMingli Yu
After enable tk via PACKAGECONFIG for python3, there comes below error: Missing or unbuildable dependency chain was: ['buildtools-tarball', 'nativesdk-python3', 'nativesdk-tk'] Extend tk to nativesdk to fix this issue. Signed-off-by: Mingli Yu <Mingli.Yu@windriver.com> Signed-off-by: Khem Raj <raj.khem@gmail.com>
2018-11-02rapidjson: Allow empty packageJoshua Watt
Causes the empty base package to be created so that RapidJSON can be sanely included in an SDK via IMAGE_INSTALL, RDEPENDS, and the like. Signed-off-by: Joshua Watt <JPEWhacker@gmail.com> Signed-off-by: Khem Raj <raj.khem@gmail.com>
2018-11-01uftrace: Support x86Yi-Soo An
If TARGET_ARCH is not set to i386 for x86, build will be failed with logs such as "arch/i586: No such file or directory". In this case, TARGET_ARCH is set to i586. To succeed the build, add additional function named set_target_arch. Signed-off-by: Yi-Soo An <yisooan@gmail.com> Signed-off-by: Khem Raj <raj.khem@gmail.com>
2018-10-25rapidjson: Update to newer 1.1.0 + gitJoshua Watt
Bring in a newer version of rapidjson which includes a fixes when running on ARM, specifically 748a652f04 ("Fix SIGBUS due to unaligned access") Also remove the existing patch file as the issue was resolved in the mainline by 4c9a28a28e ("CMake: do not pass -march=native or -mcpu=native when crosscompiling") Signed-off-by: Joshua Watt <JPEWhacker@gmail.com> Signed-off-by: Veselin Georgiev <veselin.georgiev@garmin.com> Signed-off-by: Khem Raj <raj.khem@gmail.com>
2018-10-16ipc-run: 0.99->20180523.0Hong Liu
1.Upgrade ipc-run from 0.99 to 20180523.0 Signed-off-by: Hong Liu <hongl.fnst@cn.fujitsu.com> Signed-off-by: Khem Raj <raj.khem@gmail.com>
2018-10-14cpuid: upgrade 20170122 -> 20180519Tim Orling
- Remove upstreamed patch - Create directory and install file in single install operation Signed-off-by: Tim Orling <timothy.t.orling@linux.intel.com> Signed-off-by: Khem Raj <raj.khem@gmail.com>
2018-10-12nodejs: Enable system ICU supportKhem Raj
Latest Chromium needs it during build Signed-off-by: Khem Raj <raj.khem@gmail.com>
2018-10-12valijson: Add recipeJames Feist
valijson is a header only c++ library for JSON schema validation. Signed-off-by: James Feist <james.feist@linux.intel.com> Signed-off-by: Khem Raj <raj.khem@gmail.com>
2018-10-11nlohmann-json: Add symlink to json.hpp and update to 3.3.0James Feist
nlohmann-json has examples in their repo that refer to the header as json.hpp directly, as such many packages that require nlohmann-json expect json.hpp and not nlohmann/json.hpp as the cmake file installs. Create symlink so that access is available by either option. Also update to release 3.3.0. Signed-off-by: James Feist <james.feist@linux.intel.com> Signed-off-by: Khem Raj <raj.khem@gmail.com>
2018-10-08nodejs: Revert unintended changes (not ready yet)Khem Raj
We need to enable icu with intl support but this was accidentally committed with last umip move patch Signed-off-by: Khem Raj <raj.khem@gmail.com>
2018-10-07umip: fix recipe location typoHongxu Jia
Since `36983fe umip: move to meta-networking' applied, it was moved to invalid location. Fix prior partial move to meta-networking Signed-off-by: Hongxu Jia <hongxu.jia@windriver.com> Signed-off-by: Khem Raj <raj.khem@gmail.com>
2018-10-04nlohmann-json: Add recipeJames Feist
nlohmann-json is a c++ header-only json library. Signed-off-by: James Feist <james.feist@linux.intel.com> Signed-off-by: Khem Raj <raj.khem@gmail.com>
2018-10-04sip: Add python3 version of the sip recipe.Philip Balister
Signed-off-by: Philip Balister <philip@balister.org> Signed-off-by: Khem Raj <raj.khem@gmail.com>
2018-10-04sip: Update to 4.19.13.Philip Balister
* Deleted patch is in new version. Signed-off-by: Philip Balister <philip@balister.org> Signed-off-by: Khem Raj <raj.khem@gmail.com>
2018-10-02yasm: Use 1.3.0 releaseKhem Raj
* latest master might have issues, so revert to using 1.3.0 release * Disable parallel compile Signed-off-by: Khem Raj <raj.khem@gmail.com>
2018-10-02android-tools: refresh patches with devtoolMartin Jansa
* devtool isn't able to regenerate them completely, it generates only top level commit which says that submodules were changed, like this: From c8fa114325e4e532657499b9bb6fd23cb6536eaa Mon Sep 17 00:00:00 2001 From: OpenEmbedded <oe.patch@oe> Date: Tue, 2 Oct 2018 16:46:55 +0000 Subject: [PATCH] Committing changes from do_patch --- external/libselinux | 2 +- system/core | 2 +- system/extras | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) .. but it still creates relatively good commits in each submodule and after small manual cleanup they can be exported with git format-patch --no-numbered --no-signature * rename .gitignore to prevent git ignoring the changes in .patch files in meta-oe already (we want to use it only later during the build) Signed-off-by: Martin Jansa <Martin.Jansa@gmail.com> Signed-off-by: Khem Raj <raj.khem@gmail.com>
2018-10-02android-tools: use patchdir parameter to apply patchesMartin Jansa
* helps to apply the patches for correct git repo * split remove-selinux-android.patch into 2, because devtool modify fails to apply it across 2 different git repositories: ERROR: Command Error: 'sh -c 'PATCHFILE="remove-selinux-android.patch" git -c user.name="OpenEmbedded" -c user.email="oe.patch@oe" commit -F /tmp/tmpvn7yf20j --author="Sergio Schvezov <sergio.schvezov@canonical.com>" --date="Wed, 7 Sep 2016 12:58:47 +0300"'' exited with 0 Output: On branch devtool Changes not staged for commit: modified: system/core (modified content) modified: system/extras (modified content) no changes added to commit ERROR: Function failed: patch_do_patch ERROR: Logfile of failure stored in: /OE/build/owpb/webos-ports/tmp-glibc/work/aarch64-webos-linux/android-tools/5.1.1.r37-r0/devtooltmp-7qrccor9/temp/log.do_patch.8643 NOTE: Tasks Summary: Attempted 3 tasks of which 0 didn't need to be rerun and 1 failed. NOTE: Writing buildhistory ERROR: Extracting source for android-tools failed * similarly with remove-bionic-android.patch Signed-off-by: Martin Jansa <Martin.Jansa@gmail.com> Signed-off-by: Khem Raj <raj.khem@gmail.com>
2018-10-02android-tools: import 2 changes from meta-webos-portsMartin Jansa
* import upstream-able changes from following commits: https://github.com/webOS-ports/meta-webos-ports/commit/9d032e47b5a90846485393095a4fd9b923578f22 https://github.com/webOS-ports/meta-webos-ports/commit/fea52b88281e197482b7412824802c057ec99000 https://github.com/webOS-ports/meta-webos-ports/commit/d8068a7a4722f6203ef16d85c235f86a5a76fa9c https://github.com/webOS-ports/meta-webos-ports/commit/c314b69505343ea959adc9789e0a1fca52a8af67 Signed-off-by: Martin Jansa <Martin.Jansa@gmail.com> Signed-off-by: Khem Raj <raj.khem@gmail.com>
2018-10-02android-tools: depends on openssl10 only for target buildsMartin Jansa
* openssl isn't used by TOOLS enabled for native and nativesdk builds: TOOLS_class-native = "fastboot ext4_utils mkbootimg" TOOLS_class-nativesdk = "fastboot ext4_utils mkbootimg" it's used e.g. by adb which is enabled only for target * with openssl10 it cannot be really used by anything, because openssl.cnf from openssl10-native will conflict with openssl.cnf installed to RSS by openssl-native, causing: DEBUG: Executing python function sstate_task_prefunc DEBUG: Python function sstate_task_prefunc finished DEBUG: Executing python function extend_recipe_sysroot NOTE: Direct dependencies are ['virtual:native:/OE/build/owpb/webos-ports/openembedded-core/meta/recipes-devtools/e2fsprogs/e2fsprogs_1.44.3.bb:do_populate_sysroot', '/OE/build/owpb/webos-ports/openembedded-core/meta/recipes-devtools/quilt/quilt-native_0.65.bb:do_populate_sysroot', '/OE/build/owpb/webos-ports/openembedded-core/meta/recipes-devtools/gcc/gcc-cross_8.2.bb:do_populate_sysroot', '/OE/build/owpb/webos-ports/openembedded-core/meta/recipes-devtools/gcc/gcc-runtime_8.2.bb:do_populate_sysroot', '/OE/build/owpb/webos-ports/openembedded-core/meta/recipes-core/glibc/glibc_2.28.bb:do_populate_sysroot', 'virtual:native:/OE/build/owpb/webos-ports/meta-openembedded/meta-oe/recipes-devtools/android-tools/android-tools_5.1.1.r37.bb:do_populate_sysroot', 'virtual:native:/OE/build/owpb/webos-ports/openembedded-core/meta/recipes-devtools/rpm/rpm_4.14.2.bb:do_populate_sysroot', 'virtual:native:/OE/build/owpb/webos-ports/openembedded-core/meta/recipes-devtools/dwarfsrcfiles/dwarfsrcfiles.bb:do_populate_sysroot', 'virtual:native:/OE/build/owpb/webos-ports/openembedded-core/meta/recipes-devtools/pseudo/pseudo_git.bb:do_populate_sysroot'] ERROR: Error executing a python function in exec_python_func() autogenerated: The stack trace of python calls that resulted in this exception/failure was: File: 'exec_python_func() autogenerated', lineno: 2, function: <module> 0001: *** 0002:extend_recipe_sysroot(d) 0003: File: '/OE/build/owpb/webos-ports/openembedded-core/meta/classes/staging.bbclass', lineno: 553, function: extend_recipe_sysroot 0549: dest = newmanifest[l] 0550: if l.endswith("/"): 0551: staging_copydir(l, targetdir, dest, seendirs) 0552: continue *** 0553: staging_copyfile(l, targetdir, dest, postinsts, seendirs) 0554: 0555: bb.note("Installed into sysroot: %s" % str(msg_adding)) 0556: bb.note("Skipping as already exists in sysroot: %s" % str(msg_exists)) 0557: File: '/OE/build/owpb/webos-ports/openembedded-core/meta/classes/staging.bbclass', lineno: 151, function: staging_copyfile 0147: os.symlink(linkto, dest) 0148: #bb.warn(c) 0149: else: 0150: try: *** 0151: os.link(c, dest) 0152: except OSError as err: 0153: if err.errno == errno.EXDEV: 0154: bb.utils.copyfile(c, dest) 0155: else: Exception: FileExistsError: [Errno 17] File exists: '/OE/build/owpb/webos-ports/tmp-glibc/sysroots-components/x86_64/openssl-native/etc/ssl/openssl.cnf' -> '/OE/build/owpb/webos-ports/tmp-glibc/work/tissot-webos-linux/android-system-image-tissot/20180914-22-r0/recipe-sysroot-native/etc/ssl/openssl.cnf' DEBUG: Python function extend_recipe_sysroot finished ERROR: Function failed: extend_recipe_sysroot Signed-off-by: Martin Jansa <Martin.Jansa@gmail.com> Signed-off-by: Khem Raj <raj.khem@gmail.com>
2018-09-30yasm: Add recipe ( previously in oe-core )Khem Raj
Remove in OE-Core via http://git.openembedded.org/openembedded-core/commit/?id=b7f3f7ecfdf26129c5df2d3ee14e73c4633ea5a3 while apps in OE-core have move to use nasm or other things yasm is still needed by some apps in rest of OE universe e.g. firefox switch to github URI since master has bunch of fixes over 1.3.0 release Signed-off-by: Khem Raj <raj.khem@gmail.com>
2018-09-27php: fix linker errors by setting `ac_cv_func_dlopen=no`Max Kellermann
The autoconf variable `ac_cv_func_dlopen` controls whether `dlopen()` is available without linking `libdl.so`. But that doesn't work: tmp-glibc/work/aarch64-oe-linux/php/7.2.10-r0/recipe-sysroot-native/usr/bin/aarch64-oe-linux/../../libexec/aarch64-oe-linux/gcc/aarch64-oe-linux/8.2.0/ld: ext/sqlite3/libsqlite/sqlite3.o: undefined reference to symbol 'dlsym@@GLIBC_2.17' tmp-glibc/work/aarch64-oe-linux/php/7.2.10-r0/recipe-sysroot-native/usr/bin/aarch64-oe-linux/../../libexec/aarch64-oe-linux/gcc/aarch64-oe-linux/8.2.0/ld: tmp-glibc/work/aarch64-oe-linux/php/7.2.10-r0/recipe-sysroot/lib/libdl.so.2: error adding symbols: DSO missing from command line Leave `ac_cv_lib_dl_dlopen=yes`, because that's the one which controls whether `-ldl` is needed. Signed-off-by: Khem Raj <raj.khem@gmail.com>
2018-09-27php: add "--without-sqlite3 --without-pdo-sqlite"Max Kellermann
Removing "sqlite3" from `PACKAGECONFIG` doesn't actually disable SQLite, because those options default to "yes". It just switches from the system SQLite to PHP's internal SQLite copy. Signed-off-by: Khem Raj <raj.khem@gmail.com>
2018-09-26php5: 5.6.36 -> 5.6.38Hongxu Jia
1. Support openssl 1.1.x 2. 5.6.38 ChangeLog (http://php.net/ChangeLog-5.php#5.6.38) - Fixed bug #76582 (XSS due to the header Transfer-Encoding: chunked). - Fixed bug #76423 (Int Overflow lead to Heap OverFlow in exif_thumbnail_extract of exif.c). (CVE-2018-14883) - Fixed bug #76557 (heap-buffer-overflow (READ of size 48) while reading exif data). (CVE-2018-14851) Signed-off-by: Hongxu Jia <hongxu.jia@windriver.com> Signed-off-by: Khem Raj <raj.khem@gmail.com>
2018-09-25protobuf: make python-protobuf dependency optional and default to offPaul Eggleton
A dependency on python-protobuf was added in commit 5f6fcfd36272768a3ff9078c07c572cf5dc01ccd for the sole purpose of providing a ptest, however python-protobuf is in meta-python and thus this means that meta-oe would depend on meta-python by default (assuming your distro enables ptest by default), and we don't want that - meta-oe isn't supposed to depend upon any layer other than openembedded-core. Luckily we can still have a ptest even without the python support, so add a PACKAGECONFIG and leave it disabled by default. Note: the PACKAGECONFIG here is not particularly useful since it's only about what goes into the -ptest package and thus also the dependency. I contemplated just using LANG_SUPPORT instead, but PACKAGECONFIG does have the advantage that it's introspectable and fairly well understood so in the end I went with it. Signed-off-by: Paul Eggleton <paul.eggleton@linux.intel.com> Signed-off-by: Khem Raj <raj.khem@gmail.com>
2018-09-25nodejs: upgrade to 8.12.0Hong Liu
Upgrade nodejs from 8.11.4 to 8.12.0. Signed-off-by: Hong Liu <hongl.fnst@cn.fujitsu.com> Signed-off-by: Khem Raj <raj.khem@gmail.com>
2018-09-24sip: Fix packaging so python module ends up in the right place.Philip Balister
* The patch is generated by diffing the last release with the sip Hg repo tip. Also have to run the build script to update configure.py. Signed-off-by: Philip Balister <philip@balister.org>
2018-09-24php: Upgrade 7.2.9 -< 7.2.10Changqing Li
1. Upgrade 7.2.9 -> 7.2.10 2. php 5.x not support valgrind config, so move it to php_7.x.bb Signed-off-by: Changqing Li <changqing.li@windriver.com> Signed-off-by: Khem Raj <raj.khem@gmail.com>
2018-09-24xerces-c: split one dpg packageHongxu Jia
Multiple -dbg packages per recipe is not encouraged, and only one is recommended and the code only works properly in some cases for one. Add RPROVIDES_${PN}-dbg to be compatiable with previous dbg packages requiring. Signed-off-by: Hongxu Jia <hongxu.jia@windriver.com> Signed-off-by: Khem Raj <raj.khem@gmail.com>
2018-09-09breakpad: Pass correct type name to sizeof()Khem Raj
memset is clearing memory area address starting at contect.context but it needs the correct size of type 'ucontext_t', currently its getting size of 'ucontext_t*' Signed-off-by: Khem Raj <raj.khem@gmail.com> Cc: Andre McCurdy <armccurdy@gmail.com>
2018-09-09uftrace: Upgrade to 0.8.3Khem Raj
* Deliberately provide a non existing path to with_elfutils so it does not copy libelf.so into its staged install and become a provider for that library while elfutils should be the legit provider and this package should just list it in its rdeps * Fix build with musl Signed-off-by: Khem Raj <raj.khem@gmail.com>
2018-09-08libfribidi: delete recipeOleksandr Kravchuk
Deleted recipe as it is already part of poky. Signed-off-by: Oleksandr Kravchuk <oleksandr.kravchuk@pelagicore.com> Signed-off-by: Khem Raj <raj.khem@gmail.com>
2018-09-08android-tools: Depend on openssl10Khem Raj
Signed-off-by: Khem Raj <raj.khem@gmail.com>
2018-09-08uw-imap: Fix build with openSSL 1.1Khem Raj
Signed-off-by: Khem Raj <raj.khem@gmail.com>
2018-09-08sip: Update from 4.19.8 to 4.19.12.Philip Balister
* This builds the private sip module for building PyQt5. In the future we should split into a -tools and -modules. But lets fix building for now Signed-off-by: Philip Balister <philip@balister.org> Signed-off-by: Khem Raj <raj.khem@gmail.com>