aboutsummaryrefslogtreecommitdiffstats
path: root/meta-networking
AgeCommit message (Collapse)Author
2018-05-18grpc: switch away from github archiveTrevor Woerner
Since we know that github archives which are automatically generated have a tendency to change their checksums[1], switch to using a git clone. [1] http://lists.openembedded.org/pipermail/openembedded-devel/2017-September/114916.html Signed-off-by: Trevor Woerner <twoerner@gmail.com> Signed-off-by: Khem Raj <raj.khem@gmail.com>
2018-05-18vlan: use update-alternatives for vconfigHannu Lounento
Busybox also provides the command 'vconfig' when CONFIG_VCONFIG is enabled. Busybox has a priority of 50. Prior to the patch running bitbake core-image-minimal produced the warnings WARNING: core-image-minimal-1.0-r0 do_rootfs: busybox.postinst returned 1, marking as unpacked only, configuration required on target. WARNING: core-image-minimal-1.0-r0 do_rootfs: Intentionally failing postinstall scriptlets of ['busybox'] to defer them to first boot is deprecated. Please place them into pkg_postinst_ontarget_${PN} (). If deferring to first boot wasn't the intent, then scriptlet failure may mean an issue in the recipe, or a regression elsewhere. Details of the failure are in /path/to/poky/build/tmp-glibc/work/qemux86-oe-linux/core-image-minimal/1.0-r0/temp/log.do_rootfs. WARNING: core-image-minimal-1.0-r0 do_rootfs: [log_check] core-image-minimal: found 1 warning message in the logfile: [log_check] WARNING: Intentionally failing postinstall scriptlets of ['busybox'] to defer them to first boot is deprecated. Please place them into pkg_postinst_ontarget_${PN} (). where log.do_rootfs contained update-alternatives: Error: not linking /path/to/poky/build/tmp-glibc/work/qemux86-oe-linux/core-image-minimal/1.0-r0/rootfs/sbin/vconfig to /bin/busybox.nosuid since /path/to/poky/build/tmp-glibc/work/qemux86-oe-linux/core-image-minimal/1.0-r0/rootfs/sbin/vconfig exists and is not a link when a workspace layer created by devtool contained $ cat workspace/appends/busybox_%.bbappend FILESEXTRAPATHS_prepend := "${THISDIR}/${PN}:" SRC_URI_append = " file://vconfig.cfg" and $ cat workspace/appends/busybox/vconfig.cfg CONFIG_VCONFIG=y and local.conf contained $ tail -n2 conf/local.conf IMAGE_INSTALL_append = " busybox" IMAGE_INSTALL_append = " vlan" Signed-off-by: Hannu Lounento <hannu.lounento@vaisala.com> Signed-off-by: Khem Raj <raj.khem@gmail.com>
2018-05-18chrony: Update to version 3.3Robert Joslyn
Signed-off-by: Robert Joslyn <robert.joslyn@redrectangle.org> Signed-off-by: Armin Kuster <akuster808@gmail.com>
2018-05-18ipsec-tools: Disable gcc8 warningsKhem Raj
Signed-off-by: Khem Raj <raj.khem@gmail.com> Signed-off-by: Armin Kuster <akuster808@gmail.com>
2018-05-18netkit-rusers: Fix build when libc does not have nis builtinKhem Raj
Signed-off-by: Khem Raj <raj.khem@gmail.com> Signed-off-by: Armin Kuster <akuster808@gmail.com>
2018-05-18spice: use latest versionMartin Jansa
Signed-off-by: Martin Jansa <Martin.Jansa@gmail.com> Signed-off-by: Armin Kuster <akuster808@gmail.com>
2018-05-18celt051: make ogg support optionalMartin Jansa
* drop PR * add +git to PV * and support for native and nativesdk needed for spice * the old PACKAGECONFIG didn't work, because both options aren't recognized as shown by do_configure warning: configure: WARNING: unrecognized options: --without-ogg, --disable-oggtest * XIPH_PATH_OGG macro is provided by libogg so we cannot call it without the libogg dependency, so replace it with explicit --enable-tools Signed-off-by: Martin Jansa <Martin.Jansa@gmail.com> Signed-off-by: Armin Kuster <akuster808@gmail.com>
2018-05-18celt051: import from meta-cloud-servicesMartin Jansa
* needed for spice Signed-off-by: Martin Jansa <Martin.Jansa@gmail.com> Signed-off-by: Armin Kuster <akuster808@gmail.com>
2018-05-18usbredir: add new recipeMartin Jansa
* can be used by qemu to redirect usb devices from virt-manager to qemu Signed-off-by: Martin Jansa <Martin.Jansa@gmail.com> Signed-off-by: Armin Kuster <akuster808@gmail.com>
2018-05-18spice: upgrade to 0.13.90 versionMartin Jansa
* 0.13.0 is needed for opengl support, see qemu commit: https://git.qemu.org/?p=qemu.git;a=commitdiff;h=474114b7305cc1be7c2ee8ba5267be159a9d56e3 +# if SPICE_SERVER_VERSION >= 0x000d00 /* release 0.13.0 */ +# define HAVE_SPICE_GL 1 otherwise trying to run qemu with -spice gl=on fails with: qemu-system-x86_64: -spice gl=on: Invalid parameter 'gl' * spice-protocol is built separately since 0.12.6 * spice-protocol submodule has been removed,, spice-protocol must now be installed when building spice-server * celt051 is optional since 0.12.5, use PACKAGECONFIG for it * Added Opus support. Celt support will be obsoleted in a future release. Signed-off-by: Martin Jansa <Martin.Jansa@gmail.com> Signed-off-by: Armin Kuster <akuster808@gmail.com>
2018-05-18spice: fix build with FORTIFY_SOURCES already defined in native gccMartin Jansa
* e.g. on gentoo hosts * use 4 spaces for indentation Signed-off-by: Martin Jansa <Martin.Jansa@gmail.com> Signed-off-by: Armin Kuster <akuster808@gmail.com>
2018-05-18spice: fix dependency on python-pyparsing, add support for native(sdk)Martin Jansa
* drop PR * add +git to PV * drop python-pyparsing dependency, because python-pyparsing is in meta-python * replace dependency on python-pyparsing with python-pyparsing-native which is used to generate client/generated_marshallers.cpp Signed-off-by: Martin Jansa <Martin.Jansa@gmail.com> Signed-off-by: Armin Kuster <akuster808@gmail.com>
2018-05-18spice: import from meta-cloud-servicesMartin Jansa
* http://git.yoctoproject.org/cgit/cgit.cgi/meta-cloud-services/commit/recipes-support/spice/spice_git.bb?id=19f0c979abbc72a300c0b1cb92f9328f96728f5a * will be used by qemu-native to provide a way for headless servers to export accelerated (virglrenderer) graphics to remove clients Signed-off-by: Martin Jansa <Martin.Jansa@gmail.com> Signed-off-by: Armin Kuster <akuster808@gmail.com>
2018-05-18geoip-perl: update 1.50 -> 1.51Trevor Woerner
NOTE: the license checksum changed because the copyright year was changed from "2016" to "2002 - 2017". There are no other changes to the LICENSE otherwise. Signed-off-by: Trevor Woerner <twoerner@gmail.com> Signed-off-by: Armin Kuster <akuster808@gmail.com>
2018-05-18geoip-perl: switch away from github archiveTrevor Woerner
Since we know that github archives which are automatically generated have a tendency to change their checksums[1], switch to using a git clone. [1] http://lists.openembedded.org/pipermail/openembedded-devel/2017-September/114916.html Signed-off-by: Trevor Woerner <twoerner@gmail.com> Signed-off-by: Armin Kuster <akuster808@gmail.com>
2018-05-18ipcalc: switch away from github archiveTrevor Woerner
Since we know that github archives which are automatically generated have a tendency to change their checksums[1], switch to using a git clone. [1] http://lists.openembedded.org/pipermail/openembedded-devel/2017-September/114916.html Signed-off-by: Trevor Woerner <twoerner@gmail.com> Signed-off-by: Armin Kuster <akuster808@gmail.com>
2018-05-18wolfssl: update 3.12.0 -> 3.14.4Trevor Woerner
Signed-off-by: Trevor Woerner <twoerner@gmail.com> Signed-off-by: Armin Kuster <akuster808@gmail.com>
2018-05-18wolfssl: switch away from github archiveTrevor Woerner
Since we know that github archives which are automatically generated have a tendency to change their checksums[1], switch to using a git clone. [1] http://lists.openembedded.org/pipermail/openembedded-devel/2017-September/114916.html Signed-off-by: Trevor Woerner <twoerner@gmail.com> Signed-off-by: Armin Kuster <akuster808@gmail.com>
2018-05-18recipes: Link with libtirpcKhem Raj
glibc no longer provides rpc implementation Signed-off-by: Khem Raj <raj.khem@gmail.com> Signed-off-by: Armin Kuster <akuster808@gmail.com>
2018-05-18postfix: Depend on external libnslKhem Raj
Glibc has dropped libnsl Signed-off-by: Khem Raj <raj.khem@gmail.com> Signed-off-by: Armin Kuster <akuster808@gmail.com>
2018-05-18ippool: Adjust for glibc dropping rpc supportKhem Raj
Signed-off-by: Khem Raj <raj.khem@gmail.com> Signed-off-by: Armin Kuster <akuster808@gmail.com>
2018-05-18openl2tp: Fix build without glibc's rpc/nsl supportKhem Raj
Signed-off-by: Khem Raj <raj.khem@gmail.com> Signed-off-by: Armin Kuster <akuster808@gmail.com>
2018-05-18squid: Upgrade to 3.5.27Khem Raj
Drop upstreamed/backported patches Signed-off-by: Khem Raj <raj.khem@gmail.com> Signed-off-by: Armin Kuster <akuster808@gmail.com>
2018-05-18cpprest: add new recipe based on Debian packagingGianfranco Costamagna
The patches were imported from the Debian repository (https://salsa.debian.org/debian/casablanca) as of commit id 5b58637016a569a5d54714bd151a800028f77532 Signed-off-by: Gianfranco Costamagna <locutusofborg@debian.org> Signed-off-by: Gianfranco Costamagna <gianfranco.costamagna@abinsula.com> Co-developed-by: Cristiano Prato <cristiano.prato@cnhind.com> Signed-off-by: Armin Kuster <akuster808@gmail.com>
2018-05-18websocketpp: add new recipe based on Debian packagingGianfranco Costamagna
The patches were imported from the Debian repository (https://salsa.debian.org/debian/websocketpp) as of commit id afb8d4c64893883e184991ae8ab3680ef1f302b9 Signed-off-by: Gianfranco Costamagna <locutusofborg@debian.org> Signed-off-by: Gianfranco Costamagna <gianfranco.costamagna@abinsula.com> Signed-off-by: Armin Kuster <akuster808@gmail.com>
2018-05-18lftp: Fix useless-rpaths QA issueKhem Raj
Signed-off-by: Khem Raj <raj.khem@gmail.com> Signed-off-by: Armin Kuster <akuster808@gmail.com>
2018-05-18lftp: Upgrade to 4.8.3Khem Raj
Drop libidn packageconfig, this is no more an option in configure.ac Package the icon files Signed-off-by: Khem Raj <raj.khem@gmail.com> Signed-off-by: Armin Kuster <akuster808@gmail.com>
2018-05-18networkmanager-openvpn: fix QA issue error for multilibYi Zhao
When enable multilib build, there is a QA Issue error: ERROR: networkmanager-openvpn-1.2.8-r0 do_package: QA Issue: networkmanager-openvpn: Files/directories were installed but not shipped in any package: /usr/lib /usr/lib/NetworkManager /usr/lib/NetworkManager/VPN /usr/lib/NetworkManager/VPN/nm-openvpn-service.name Please set FILES such that these items are packaged. Alternatively if they are unneeded, avoid installing them or delete them within do_install. networkmanager-openvpn: 4 installed and not shipped files. [installed-vs-shipped] Signed-off-by: Yi Zhao <yi.zhao@windriver.com> Signed-off-by: Armin Kuster <akuster808@gmail.com>
2018-05-18networkmanager: fix QA issue error for multilibYi Zhao
When enable multilib build, there is a QA Issue error: ERROR: networkmanager-1.10.6-r0 do_package: QA Issue: networkmanager: Files/directories were installed but not shipped in any package: /usr/lib/NetworkManager /usr/lib/NetworkManager/VPN /usr/lib/NetworkManager/conf.d Please set FILES such that these items are packaged. Alternatively if they are unneeded, avoid installing them or delete them within do_install. networkmanager: 3 installed and not shipped files. [installed-vs-shipped] Signed-off-by: Yi Zhao <yi.zhao@windriver.com> Signed-off-by: Armin Kuster <akuster808@gmail.com>
2018-05-18opensaf: Fix warnings found with gcc8Khem Raj
Signed-off-by: Khem Raj <raj.khem@gmail.com> Signed-off-by: Armin Kuster <akuster808@gmail.com>
2018-05-18memcached: Upgrade to 1.5.7Khem Raj
Signed-off-by: Khem Raj <raj.khem@gmail.com> Signed-off-by: Armin Kuster <akuster808@gmail.com>
2018-05-18ctdb: Call gnu-configize for getting new config.* filesKhem Raj
Architecture support for riscv64 needs new config.guess Signed-off-by: Khem Raj <raj.khem@gmail.com> Signed-off-by: Armin Kuster <akuster808@gmail.com>
2018-05-18ntp: update to 4.2.8.p11Armin Kuster
This release addresses five security issues in ntpd: LOW/MEDIUM: Sec 3012 / CVE-2016-1549 / VU#961909: Sybil vulnerability: ephemeral association attack INFO/MEDIUM: Sec 3412 / CVE-2018-7182 / VU#961909: ctl_getitem(): buffer read overrun leads to undefined behavior and information leak LOW: Sec 3415 / CVE-2018-7170 / VU#961909: Multiple authenticated ephemeral associations LOW: Sec 3453 / CVE-2018-7184 / VU#961909: Interleaved symmetric mode cannot recover from bad state LOW/MEDIUM: Sec 3454 / CVE-2018-7185 / VU#961909: Unauthenticated packet can reset authenticated interleaved association one security issue in ntpq: MEDIUM: Sec 3414 / CVE-2018-7183 / VU#961909: ntpq:decodearr() can write beyond its buffer limit Signed-off-by: Armin Kuster <akuster@mvista.com>
2018-05-18kea: add new recipeMingli Yu
* Kea is the next generation of DHCP software developed by ISC. It supports both DHCPv4 and DHCPv6 protocols along with their extensions, e.g. prefix delegation and dynamic updates to DNS. * Backport patch to fix issue with boost 1.66 * Add kea-msg-compiler related patch to support cross-compile Signed-off-by: Mingli Yu <Mingli.Yu@windriver.com> Signed-off-by: Armin Kuster <akuster808@gmail.com>
2018-05-18postfix: remove host references from makedefs.outSlater, Joseph
Several -I definitions contain the value of ${STAGING_DIR_TARGET} which should be removed to reference directories on the target. Signed-off-by: Joe Slater <joe.slater@windriver.com>
2018-05-18mosquito: move from oe to networking layerArmin Kuster
mosquito has dependancy on meta-netowrking packages Signed-off-by: Armin Kuster <akuster808@gmail.com>
2018-05-18grpc: move it from oe to networking layerArmin Kuster
grpc has dependancy on meta-networking packages. Signed-off-by: Armin Kuster <akuster808@gmail.com>
2018-05-18miniupnpd: update to 2.0.20180203 and add systemd servicePascal Bach
license checksum changed due to increase in copyright year Signed-off-by: Pascal Bach <pascal.bach@siemens.com> Signed-off-by: Armin Kuster <akuster808@gmail.com>
2018-05-17rdma-core: add new recipeWei Lin Guay
RDMA core is the userspace components for the Linux Kernel's InfiniBand/RoCE subsystem. This component contains the userspace libraries for libibverbs (and its associated providers libraries), librdmacm and libibumad. Besides, it also provides additional service daemons such as ibacm and srp_daemon. Signed-off-by: Wei Lin Guay <wguay@graphcore.ai> Reviewed-by: Harald Høeg <hhoeg@graphcore.ai> Signed-off-by: Armin Kuster <akuster808@gmail.com>
2018-05-01networkmanager: fix prevous commitsAndreas Müller
The wrong patches were applied: commit c5a04600817e0d34dfa151d46073a76b506b4c3d Author: Armin Kuster <akuster808@gmail.com> Date: Fri Mar 30 19:56:03 2018 -0700 networkmanager: Fix many typos in DISTRO_FEATURES PACKAGECONFIG decodes commit 575c14ded56e1e97582a6df0921d19b4da630961 Author: Andreas Müller <schnitzeltony@gmail.com> Date: Thu Mar 22 18:40:52 2018 +0100 networkmanager: fix gobject-introspection/musl and cleanup * musl fixed (tested) * PACKAGECONFIG systemd: Logic was broken by c5a046. To avoid further confusion, the expression was put into one line. * PACKAGECONFIG wifi: The expression 'bb.utils.filter.. ' was perfectly fine. Signed-off-by: Andreas Müller <schnitzeltony@gmail.com> Signed-off-by: Armin Kuster <akuster808@gmail.com>
2018-05-01libtevent: add libtirpc to DEPENDSAndreas Müller
musl build fails with: | Checking for header rpc/rpc.h : no | Checking for header rpc/nettype.h : no | Checking for libtirpc headers : not found | Checking for libntirpc headers : not found | ERROR: No rpc/rpc.h header found, tirpc or libntirpc missing? Signed-off-by: Andreas Müller <schnitzeltony@gmail.com> Signed-off-by: Armin Kuster <akuster808@gmail.com>
2018-05-01iscsitarget: Blacklist compile failedArmin Kuster
Kernel header changes are causing this issues. iscsctarget has been dropping by other distros in favor of tgt. Signed-off-by: Armin Kuster <akuster808@gmail.com>
2018-05-01drbd: BLACKLIST recipeArmin Kuster
[v2] Wrong version sent to list. forgot to refresh fails do to new kernel headers. | ../drbd/9.0.8-1-r0/drbd-9.0.8-1/drbd/drbd_receiver.c:1479:7: error: 'struct bio' has no member named 'bi_bdev'; did you mean 'bi_iter'? | bio->bi_bdev = device->ldev->backing_bdev; | ^~~~~~~ | bi_iter | .../drbd/9.0.8-1-r0/drbd-9.0.8-1/drbd/drbd_receiver.c:1484:17: error: assignment from incompatible pointer type [-Werror=incompatible-pointer-types] | bio->bi_end_io = drbd_peer_request_endio; Signed-off-by: Armin Kuster <akuster808@gmail.com>
2018-04-25mbedtls: upgrade to 2.8.0Johannes Pointner
This also includes a switch to Apache license, because it's the primary license for the project according to their homepage. * Detail release note: - https://tls.mbed.org/tech-updates/releases/mbedtls-2.8.0-2.7.2-and-2.1.11-released Signed-off-by: Johannes Pointner <johannes.pointner@br-automation.com> Signed-off-by: Armin Kuster <akuster808@gmail.com> Signed-off-by: Joe MacDonald <joe_macdonald@mentor.com>
2018-04-25wireshark: update to 2.4.6 and add upstream checkArmin Kuster
[v2] inherit upstream-version-is-even instead of creating my own regex Security fixes: The following vulnerabilities have been fixed: * [1]wnpa-sec-2018-15 The MP4 dissector could crash. ([2]Bug 13777) * [3]wnpa-sec-2018-16 The ADB dissector could crash. ([4]Bug 14460) * [5]wnpa-sec-2018-17 The IEEE 802.15.4 dissector could crash. ([6]Bug 14468) * [7]wnpa-sec-2018-18 The NBAP dissector could crash. ([8]Bug 14471) * [9]wnpa-sec-2018-19 The VLAN dissector could crash. ([10]Bug 14469) * [11]wnpa-sec-2018-20 The LWAPP dissector could crash. ([12]Bug 14467) * [13]wnpa-sec-2018-21 The TCP dissector could crash. ([14]Bug 14472) * [15]wnpa-sec-2018-22 The CQL dissector could to into an infinite loop. ([16]Bug 14530) * [17]wnpa-sec-2018-23 The Kerberos dissector could crash. ([18]Bug 14576) * [19]wnpa-sec-2018-24 Multiple dissectors and other modules could leak memory. The TN3270 ([20]Bug 14480), ISUP ([21]Bug 14481), LAPD ([22]Bug 14482), SMB2 ([23]Bug 14483), GIOP ([24]Bug 14484), ASN.1 ([25]Bug 14485), MIME multipart ([26]Bug 14486), H.223 ([27]Bug 14487), and PCP ([28]Bug 14488) dissectors were susceptible along with Wireshark and TShark Signed-off-by: Armin Kuster <akuster808@gmail.com> Signed-off-by: Joe MacDonald <joe_macdonald@mentor.com>
2018-04-25lowpan-tools: Switch to using github src_uri and fix build with gcc8Khem Raj
Signed-off-by: Khem Raj <raj.khem@gmail.com> Signed-off-by: Armin Kuster <akuster808@gmail.com> Signed-off-by: Joe MacDonald <joe_macdonald@mentor.com>
2018-04-25yp-tools: Upgrade to 4.2.3Khem Raj
Switch to github for SRC_URI Signed-off-by: Khem Raj <raj.khem@gmail.com> Signed-off-by: Armin Kuster <akuster808@gmail.com> Signed-off-by: Joe MacDonald <joe_macdonald@mentor.com>
2018-04-25wpan-tools: Add recipeKhem Raj
lowpan-utils should be removed in favor of this package Signed-off-by: Khem Raj <raj.khem@gmail.com> Signed-off-by: Armin Kuster <akuster808@gmail.com> Signed-off-by: Joe MacDonald <joe_macdonald@mentor.com>
2018-04-25networkmanager: Fix many typos in DISTRO_FEATURES PACKAGECONFIG decodesArmin Kuster
fixes issues found with yocto-check-layer File "/home/akuster/oss/maint/openembedded-core/bitbake/lib/bb/data_smart.py", line 436, in DataSmart.expand(s="nss ifupdown netconfig dhclient dnsmasq ${@bb.utils.contains('DISTRO_FEATURES', 'systemd', 'systemd', '', d)} ${@bb.utils.contains('DISTRO_FEATURES', 'x11', 'consolekit', '', d)} ${@bb.utils.contains('DISTRO_FEATURES', 'bluetooth', '${BLUEZ}', '', d)} ${@bb.utils.contains('DISTRO_FEATURES', 'wifi', '', d)} ", varname='PACKAGECONFIG'): def expand(self, s, varname = None): > return self.expandWithRefs(s, varname).value File "/home/akuster/oss/maint/openembedded-core/bitbake/lib/bb/data_smart.py", line 426, in DataSmart.expandWithRefs(s="nss ifupdown netconfig dhclient dnsmasq ${@bb.utils.contains('DISTRO_FEATURES', 'systemd', 'systemd', '', d)} ${@bb.utils.contains('DISTRO_FEATURES', 'x11', 'consolekit', '', d)} ${@bb.utils.contains('DISTRO_FEATURES', 'bluetooth', 'bluez5', '', d)} ${@bb.utils.contains('DISTRO_FEATURES', 'wifi', '', d)} ", varname='PACKAGECONFIG'): except Exception as exc: > raise ExpansionError(varname, s, exc) from exc bb.data_smart.ExpansionError: Failure expanding variable PACKAGECONFIG, expression was nss ifupdown netconfig dhclient dnsmasq ${@bb.utils.contains('DISTRO_FEATURES', 'systemd', 'systemd', '', d)} ${@bb.utils.contains('DISTRO_FEATURES', 'x11', 'consolekit', '', d)} ${@bb.utils.contains('DISTRO_FEATURES', 'bluetooth', 'bluez5', '', d)} ${@bb.utils.contains('DISTRO_FEATURES', 'wifi', '', d)} which triggered exception TypeError: contains() missing 1 required positional argument: 'd' Signed-off-by: Armin Kuster <akuster808@gmail.com> Signed-off-by: Joe MacDonald <joe_macdonald@mentor.com>
2018-04-25networkmanager: fix gobject-introspection/musl and cleanupAndreas Müller
This adresses the comments for recent patch which updated nm to 1.10.6 and is a follow-up for [1]. * Make gobject-introspection work by skipping creation of gobject-introspection specific documentation. This fixes networkmanager-applet regression. * Cleanup patches: Remove current musl patches completely and re-use those found in void-linux because they do look much cleaner and don't touch glibc build. One nice side effect: In the future when nm is updated we can steal again and don't need to reenvent here. Usually they are much faster than we are (and I know one major contibutor personally from the good old Z80 times..) * Fix typo in PACKAGECONFIG [1] https://patchwork.openembedded.org/patch/149244/ Signed-off-by: Andreas Müller <schnitzeltony@gmail.com> Signed-off-by: Armin Kuster <akuster808@gmail.com> Signed-off-by: Joe MacDonald <joe_macdonald@mentor.com>