aboutsummaryrefslogtreecommitdiffstats
path: root/meta-networking/recipes-protocols
AgeCommit message (Collapse)Author
2016-09-26net-snmp: Fix build issue found with muslKhem Raj
limits.h is needed for PATH_MAX and NAME_MAX Signed-off-by: Khem Raj <raj.khem@gmail.com> Signed-off-by: Martin Jansa <Martin.Jansa@gmail.com>
2016-09-26openl2tp: Obey LDFLAGS in MakefileAdrian Dudau
This avoids a "QA Issue: No GNU_HASH in the elf binary" Signed-off-by: Adrian Dudau <adrian.dudau@enea.com> Signed-off-by: Martin Jansa <Martin.Jansa@gmail.com>
2016-09-05accel-ppp: blacklist, fails to build with new binutils-2.27Martin Jansa
Signed-off-by: Martin Jansa <Martin.Jansa@gmail.com> Signed-off-by: Joe MacDonald <joe_macdonald@mentor.com>
2016-08-22meta-oe: fix indentationMartin Jansa
* remove tabs which sneaked in since last cleanup * meta-oe layers are using consistent indentation with 4 spaces, see http://www.openembedded.org/wiki/Styleguide Signed-off-by: Martin Jansa <Martin.Jansa@gmail.com>
2016-08-16quagga: 0.99.24.1 -> 1.0.20160315Kai Kang
Upgrade quagga from 0.99.24.1 to 1.0.20160315. * babeld was removed from quagga, so remove babeld related code, service file and patch and from recipe * remove Zebra-sync-zebra-routing-table-with-the-kernel-one.patch which is obsoleted that quagga update the logic, see https://github.com/Quagga/quagga/commit/0abf6796c3d8ae8f5ea8624668424bc1554de25e * remove configure options '--enable-ospf-te' and '--enable-opaque-lsa' which are set by default and removed from configure.ac already Signed-off-by: Kai Kang <kai.kang@windriver.com> Signed-off-by: Martin Jansa <Martin.Jansa@gmail.com> Signed-off-by: Joe MacDonald <joe_macdonald@mentor.com>
2016-07-18net-snmp: initscripts are located in net-snmp-server-snmp packageLi Wang
The net-snmp-server package is a meta-package requiring net-snmp-server-snmpd and net-snmp-server-snmptrapd package. The net-snmp-server-snmpd package provides the startup scripts not the meta net-snmp-server package. Signed-off-by: Anders Wallin <anders.wallin@windriver.com> Signed-off-by: Li Wang <li.wang@windriver.com> Signed-off-by: Jackie Huang <jackie.huang@windriver.com> Signed-off-by: Martin Jansa <Martin.Jansa@gmail.com> Signed-off-by: Joe MacDonald <joe_macdonald@mentor.com>
2016-07-18net-snmp: fix snmpd crash via AgentX connectionJackie Huang
backport a patch to fixed snmpd crashing when an AgentX subagent disconnect in the middle of processing of a request. Signed-off-by: Zhu Yanjun <yanjun.zhu@windriver.com> Signed-off-by: Jackie Huang <jackie.huang@windriver.com> Signed-off-by: Martin Jansa <Martin.Jansa@gmail.com> Signed-off-by: Joe MacDonald <joe_macdonald@mentor.com>
2016-05-05meta-networking: use bb.utils.contains() instead of base_contains()Ross Burton
base_contains() is a compatibility wrapper and may warn in the future, so replace all instances with bb.utils.contains(). Signed-off-by: Ross Burton <ross.burton@intel.com> Signed-off-by: Martin Jansa <Martin.Jansa@gmail.com> Signed-off-by: Joe MacDonald <joe_macdonald@mentor.com>
2016-05-05rp-pppoe: Fix rootfs creation errorsLi xin
error: file /usr/share/doc/README from install of rp-pppoe-doc-3.11-* conflicts with file from package dmidecode-doc-2.12* Signed-off-by: Li Xin <lixin.fnst@cn.fujitsu.com> Signed-off-by: Martin Jansa <Martin.Jansa@gmail.com> Signed-off-by: Joe MacDonald <joe_macdonald@mentor.com>
2016-05-05net-snmp: enable ipv6 supportZhu Yanjun
Add packageconfig for ipv6 and enable it when it's defined in distro_features. Signed-off-by: Zhu Yanjun <yanjun.zhu@windriver.com> Signed-off-by: Yue Tao <Yue.Tao@windriver.com> Signed-off-by: Martin Jansa <Martin.Jansa@gmail.com>
2016-04-01pptp-linux: update to 1.8.0Derek Straka
Signed-off-by: Derek Straka <derek@asterius.io> Signed-off-by: Martin Jansa <Martin.Jansa@gmail.com> Signed-off-by: Joe MacDonald <joe_macdonald@mentor.com>
2016-04-01net-snmp: fix some invalid pathsCatalin Enache
Because the package is not built in place @srcdir@ is an absolute path to the source directory instead of ".". Because of this some target scripts like net-snmp-create-v3-user and net-snmp-config that are using thisvariable in their *.in files (NSC_SRCDIR=@srcdir@) contain invalid paths. Signed-off-by: Catalin Enache <catalin.enache@windriver.com> Signed-off-by: Martin Jansa <Martin.Jansa@gmail.com> Signed-off-by: Joe MacDonald <joe_macdonald@mentor.com>
2016-04-01net-snmp: fix invalid paths in target net-snmp-configCatalin Enache
Only net-snmp-config used for sysroot should have sysroot specific paths. Signed-off-by: Catalin Enache <catalin.enache@windriver.com> Signed-off-by: Martin Jansa <Martin.Jansa@gmail.com> Signed-off-by: Joe MacDonald <joe_macdonald@mentor.com>
2016-03-04recipes: Replace "cp -a" with "cp -R --no-dereference --preserve=mode,links"Martin Jansa
* Using "cp -a" leaks UID of user running the builds, causing many QA warnings. * See this thread for details: http://lists.openembedded.org/pipermail/openembedded-core/2015-November/112904.html Signed-off-by: Martin Jansa <Martin.Jansa@gmail.com>
2016-02-22net-snmp: fix cross-compile breakage, add libnl pkgconfig optionStephen Arnold
This patch enhances a previously unapplied patch on jethro, plus adds some flexibility in terms of required deps and a few cleanups. Signed-off-by: Stephen Arnold <stephen.arnold42@gmail.com> Signed-off-by: Martin Jansa <Martin.Jansa@gmail.com> Signed-off-by: Joe MacDonald <joe_macdonald@mentor.com>
2016-02-22pptp-linux: Explicitly set EXTRA_OEMAKE as requiredMike Crowe
This recipe currently relies on EXTRA_OEMAKE having been to set to "-e MAKEFLAGS=" in bitbake.conf to operate. It is necessary to make this explicit so that the default in bitbake.conf can be changed. Signed-off-by: Mike Crowe <mac@mcrowe.com> Signed-off-by: Martin Jansa <Martin.Jansa@gmail.com> Signed-off-by: Joe MacDonald <joe_macdonald@mentor.com>
2016-01-20xl2tpd: modify recipes to avoid forced internet accessJoe Slater
We should always specify a commit id for git SRCREV or we will try to access the upstream repo when fetching. In addition, if our PV is just "git" we will access upstream when doing archiver functions, so we should specify PV for xyz_git.bb recipes. Signed-off-by: Joe Slater <jslater@windriver.com> Signed-off-by: Martin Jansa <Martin.Jansa@gmail.com> Signed-off-by: Joe MacDonald <joe_macdonald@mentor.com>
2016-01-20rp-pppoe: 3.11 -> 3.12Dai Caiyun
Upgrade rp-pppoe from 3.11 to 3.12. Signed-off-by: Dai Caiyun <daicy.fnst@cn.fujitsu.com> Signed-off-by: Martin Jansa <Martin.Jansa@gmail.com> Signed-off-by: Joe MacDonald <joe_macdonald@mentor.com>
2016-01-05net-snmp: fix the replacement in net-snmp-configRoy Li
when net-snmp-config is used to configure by other package, and fail since /libnl3 is not found, in fact, it should be -I/usr/include/libnl3, and is modified as /libnl3 incorrectly. instead of modify the net-snmp-config for target, the one under ${bindir_crossscripts} should be replaced with ${TAGING_INCDIR} Signed-off-by: Roy Li <rongqing.li@windriver.com> Signed-off-by: Martin Jansa <Martin.Jansa@gmail.com> Signed-off-by: Joe MacDonald <joe_macdonald@mentor.com>
2016-01-05xl2tpd: fix warnings with gcc 5Kai Kang
When compile with gcc 5.x, xl2tpd complains warnings: | misc.h:68:20: warning: inline function 'swaps' declared but never defined | extern inline void swaps (void *, int); | ^ Backport patch to fix it. Signed-off-by: Kai Kang <kai.kang@windriver.com> Signed-off-by: Martin Jansa <Martin.Jansa@gmail.com> Signed-off-by: Joe MacDonald <joe_macdonald@mentor.com>
2016-01-04quagga: fix segment fault when stopping ospf6dQi.Chen@windriver.com
In ospf6_clean, the variable ospf6 might be NULL causing segment fault when stopping ospf6d. Check the variable before referencing it. Signed-off-by: Chen Qi <Qi.Chen@windriver.com> Signed-off-by: Martin Jansa <Martin.Jansa@gmail.com> Signed-off-by: Joe MacDonald <joe_macdonald@mentor.com>
2016-01-04net-snmp: apply patch for cross-compilationRafaël Carré
7fb5479 added the patch but did not apply it Rename patch to explicit it differentiate it from other patches Signed-off-by: Martin Jansa <Martin.Jansa@gmail.com> Signed-off-by: Joe MacDonald <joe_macdonald@mentor.com>
2016-01-04net-snmp: apply patch for cross-compilationRafaël Carré
7fb5479 added the patch but did not apply it Signed-off-by: Joe MacDonald <joe_macdonald@mentor.com>
2015-11-30net-snmp: fix cross compilationRafaël Carré
Signed-off-by: Martin Jansa <Martin.Jansa@gmail.com> Signed-off-by: Joe MacDonald <joe_macdonald@mentor.com>
2015-11-30net-snmp: Modify snmpd.serviceLi Xin
Add "-a" parameter in snmpd.service,it is needed to address logs. Signed-off-by: Li Xin <lixin.fnst@cn.fujitsu.com> Signed-off-by: Martin Jansa <Martin.Jansa@gmail.com> Signed-off-by: Joe MacDonald <joe_macdonald@mentor.com>
2015-11-24xl2tpd: Update git recipe and add release recipeJoe MacDonald
The previous xl2tpd was significantly out of date, so update the git recipe and add in a release recipe for anyone looking to use the latest stable release. Signed-off-by: Joe MacDonald <joe_macdonald@mentor.com>
2015-11-16xl2tpd: set MACHINE_ARCH, because it depends on kernelMartin Jansa
* see: http://lists.openembedded.org/pipermail/openembedded-devel/2015-September/103271.html * fixes: ERROR: xl2tpd different signature for task do_configure.sigdata between qemux86copy and qemux86 runtaskdeps changed from ['gccgcc-cross_5.2.bb.do_populate_sysroot', 'gccgcc-runtime_5.2.bb.do_populate_sysroot', 'glibcglibc_2.22.bb.do_populate_sysroot', 'linuxlinux-yocto_4.1.bb.do_populate_sysroot', 'pppppp_2.4.7.bb.do_populate_sysroot', 'update-rc.dupdate-rc.d_0.7.bb.do_populate_sysroot', 'update-rc.dupdate-rc.d_0.7.bb.do_populate_sysroot:virtual:native', 'xl2tpdxl2tpd_1.3.6.bb.do_patch'] to ['gccgcc-cross_5.2.bb.do_populate_sysroot', 'gccgcc-runtime_5.2.bb.do_populate_sysroot', 'glibcglibc_2.22.bb.do_populate_sysroot', 'linuxlinux-yocto_4.1.bb.do_populate_sysroot', 'pppppp_2.4.7.bb.do_populate_sysroot', 'update-rc.dupdate-rc.d_0.7.bb.do_populate_sysroot', 'update-rc.dupdate-rc.d_0.7.bb.do_populate_sysroot:virtual:native', 'xl2tpdxl2tpd_1.3.6.bb.do_patch'] openembedded-core/meta/recipes-kernel/linux/linux-yocto_4.1.bb.do_populate_sysroot with hash 1a8aa7a50a6cf3ebf5401af43dd6bf3b changed to openembedded-core/meta/recipes-kernel/linux/linux-yocto_4.1.bb.do_populate_sysroot with hash 143d2686a37f592891fb2aa6fa9b752e Hash for dependent task linuxlinux-yocto_4.1.bb.do_populate_sysroot changed from 1a8aa7a50a6cf3ebf5401af43dd6bf3b to 143d2686a37f592891fb2aa6fa9b752e Signed-off-by: Martin Jansa <Martin.Jansa@gmail.com>
2015-10-21net-snmp: Fix build with gcc5Khem Raj
Fix errors seen with gcc5 Change-Id: I9c4361f3a9c25342f5c740263f551c162dce8faf Signed-off-by: Khem Raj <raj.khem@gmail.com> Signed-off-by: Martin Jansa <Martin.Jansa@gmail.com> Signed-off-by: Joe MacDonald <joe_macdonald@mentor.com>
2015-10-21tsocks: Add tsocks to meta-network/recipes-protocolsJason Wessel
The tsocks program is frequently used to easily wrap any generic program such as telnet, ssh, wget or any other tcp socket program using an LD_PRELOAD library. One might use an ssh tunnel and wget for example. Example of tunnel via ssh to remote url: ssh -N -D 1080 $REMOTE_HOST_TUNNEL_ENDPOINT & cat<<EOF>tsocks.conf server_port = 1080 server = 127.0.0.1 EOF TSOCKS_CONF_FILE=$PWD/tsocks.conf tsocks curl $REMOTE_URL Signed-off-by: Jason Wessel <jason.wessel@windriver.com> Signed-off-by: Martin Jansa <Martin.Jansa@gmail.com> Signed-off-by: Joe MacDonald <joe_macdonald@mentor.com>
2015-09-11net-snmp: upgrade 5.7.2.1 -> 5.7.3Li xin
* Dropped backported patches --ifmib.patch --0001-Added-checks-for-printing-variables-with-wrong-types.patch --0001-Fix-CVE-2014-2285.patch --net-snmp-5.7.2-fix-mib-timeout-values.patch * Update patches --dont-return-incompletely-parsed-varbinds.patch --systemd-support.patch * Add a new patch to avoid build Errors. --0001-config_os_headers-Error-Fix.patch Signed-off-by: Li Xin <lixin.fnst@cn.fujitsu.com> Signed-off-by: Martin Jansa <Martin.Jansa@gmail.com> Signed-off-by: Joe MacDonald <joe_macdonald@mentor.com>
2015-09-11rp-pppoe:3.8->3.11leimaohui
-deleted use-ldflags.patch that not needed. -modified patches for 3.11 Signed-off-by: Lei Maohui <leimaohui@cn.fujitsu.com> Signed-off-by: Martin Jansa <Martin.Jansa@gmail.com> Signed-off-by: Joe MacDonald <joe_macdonald@mentor.com>
2015-08-06quagga: upgrade 0.99.23 -> 0.99.24.1Li xin
Remove "--enable-ipv6" to avoid build warning like this: WARNING: QA Issue: quagga: configure was passed unrecognised options: --enable-ipv6 [unknown-configure-option] Signed-off-by: Li Xin <lixin.fnst@cn.fujitsu.com> Signed-off-by: Martin Jansa <Martin.Jansa@gmail.com> Signed-off-by: Joe MacDonald <joe_macdonald@mentor.com>
2015-08-06net-snmp: fix mib representation of timeout valuesRoy Li
Fix mib representation of timeout values,correct conversion factor from microseconds to centiseconds. Signed-off-by: Wenlin Kang <wenlin.kang@windriver.com> Signed-off-by: Roy Li <rongqing.li@windriver.com> Signed-off-by: Martin Jansa <Martin.Jansa@gmail.com> Signed-off-by: Joe MacDonald <joe_macdonald@mentor.com>
2015-07-16net-snmp: don't return incompletely parsed varbindsJian Liu
the snmp_pdu_parse() function could leave incompletely parsed varBind variables in the list of variables in case the parsing of the SNMP PDU failed. If later processing tries to operate on the stale and incompletely processed varBind (e.g. when printing the variables), this can lead to e.g. crashes or, possibly, execution of arbitrary code. The snmp_pdu_parse() function stores varBind variables in a list of netsnmp_variable_list structures. Each time the function parses a new varBind, a new netsnmp_variable_list item is allocated on the heap and linked to the list of variables. The problem is that this item is not removed from the list, even if snmp_pdu_parse() fails to complete the parsing. The "type" member of the stale netsnmp_variable_list is not properly initialized in case snmp_pdu_parse() returns early from the parsing. However, the "type" member is used to determine later code paths, which is why we see crashes in a variety of functions, although the root cause for all of these is the same. This patch come from http://sourceforge.net/p/net-snmp/code/ci/f23bcd3ac6ddee5d0a48f9703007ccc738914791/ Written-by: Robert Story Signed-off-by: Jian Liu <jian.liu@windriver.com> Signed-off-by: Martin Jansa <Martin.Jansa@gmail.com> Signed-off-by: Joe MacDonald <joe_macdonald@mentor.com>
2015-07-06quagga: bug fixLi xin
The bug is: after the service stopped,the pid file still exists. So modidy the service files. Signed-off-by: Li Xin <lixin.fnst@cn.fujitsu.com> Signed-off-by: Martin Jansa <Martin.Jansa@gmail.com> Signed-off-by: Joe MacDonald <joe_macdonald@mentor.com>
2015-06-05meta-networking: standardize SECTION valuesJoe MacDonald
SECTION has been used inconsistently throughout the recipes in this layer. Convert them to all use the same convention. Signed-off-by: Joe MacDonald <joe_macdonald@mentor.com>
2015-06-05rp-pppoe: add systemd support and fix error in the step of do_configure.Li xin
The error is as follows: error: unrecognized command line option '-V' conftest.c:9:28: fatal error: ac_nonexistent.h: No such file or directory #include <ac_nonexistent.h>. Signed-off-by: Li Xin <lixin.fnst@cn.fujitsu.com> Signed-off-by: Martin Jansa <Martin.Jansa@gmail.com> Signed-off-by: Joe MacDonald <joe_macdonald@mentor.com>
2015-05-08net-snmp: fix CVE-2014-2285Junling Zheng
The perl_trapd_handler function in perl/TrapReceiver/TrapReceiver.xs in Net-SNMP 5.7.3.pre3 and earlier, when using certain Perl versions, allows remote attackers to cause a denial of service (snmptrapd crash) via an empty community string in an SNMP trap, which triggers a NULL pointer dereference within the newSVpv function in Perl. Refer to: https://bugzilla.redhat.com/show_bug.cgi?id=1072044 Signed-off-by: Junling Zheng <zhengjunling@huawei.com> Signed-off-by: Joe MacDonald <joe_macdonald@mentor.com>
2015-03-13openflow: add libcrypto to static openflow libraryJoe MacDonald
An update in OpenSSL removed the -lcrypto from libssl's pkg-config options. The old behaviour always linked it with -lssl, so revert to that for now. Signed-off-by: Joe MacDonald <joe_macdonald@mentor.com>
2015-03-11net-snmp: add ptest packageJackie Huang
Issue: TA79430 - Change to use append for PACKAGES so that: * ptest package is added from ptest bbcalss * the PN is back, allow empty and add rdepends on net-snmp-client in case the user try to add net-snmp to the image - Add a patch to fix the output format for ptest - Add run-ptest - Add rdepends on perl for ptest (LOCAL REV: NOT UPSTREAM) -- Sent to meta-networking on 20150114 Signed-off-by: Jackie Huang <jackie.huang@windriver.com> Signed-off-by: Joe MacDonald <joe_macdonald@mentor.com>
2015-03-11net-snmp: move net-snmp-config to client packageJackie Huang
Since net-snmp-config is a common tool, move it from dev package to client package. Signed-off-by: yzhu1 <yanjun.zhu@windriver.com> Signed-off-by: Jackie Huang <jackie.huang@windriver.com> Signed-off-by: Joe MacDonald <joe_macdonald@mentor.com>
2015-03-11net-snmp: init script fixesJackie Huang
Changes: 1. Add source function and status command. 2. make it possible to change the start arguments with a default file in the same way as debian. 3. change the default INITSCRIPT_PARAMS 4. Add PIDFILE and fix restart 5. remove the postrm sicne we use the one from update-rc.d Signed-off-by: Jackie Huang <jackie.huang@windriver.com> Signed-off-by: Joe MacDonald <joe_macdonald@mentor.com>
2015-03-11net-snmp: fix "libtool --finish"Jackie Huang
LIB_LDCONFIG_CMD failed since it is using a host dir $(libdir) which is /usr/lib64 does not exist on host when compile 64bit image. In fact, configuring dynamic linker run-time bindings is meaningless at this step, If it is needed, Poky would write ldconfig scripts to rpm-postinst for each recipe while do_package, in package.bbclass. Signed-off-by: Roy.Li <rongqing.li@windriver.com> Signed-off-by: Jackie Huang <jackie.huang@windriver.com> Signed-off-by: Joe MacDonald <joe_macdonald@mentor.com>
2015-03-11net-snmp: move persistent dir to /var/lib/net-snmpJackie Huang
Move persistent dir to /var/lib/net-snmp and fix security contexts for them. Signed-off-by: Wenzong Fan <wenzong.fan@windriver.com> Signed-off-by: Jackie Huang <jackie.huang@windriver.com> Signed-off-by: Joe MacDonald <joe_macdonald@mentor.com>
2015-03-11net-snmp: have mib-modules=smux enabledJackie Huang
According to the following commit, net-snmp needs to have mib-modules=smux enabled: commit f64db3011c04ada0a8ac04b9eddde05b67d21eec Author: Aws Ismail <aws.ismail@windriver.com> Date: Mon Mar 25 11:30:06 2013 -0400 Quagga has no snmp support, unrecognized options --enable-tcp-md5 1. Quagga's tcp-md5 has been renamed to linux24-tcp-md5 2. net-snmp needs to have mib-modules=smux enabled to enable quagga to support snmp. Make the net-snmp option dependent on the DISTRO_FEATURE snmp. 3. Misc: install the sample conf files for quagga. Also, Make sure that the post install script is being run on the target rather than during the rootfs creation stage. Signed-off-by: Amy Fong <amy.fong@windriver.com> Signed-off-by: Aws Ismail <aws.ismail@windriver.com> Signed-off-by: Joe MacDonald <joe.macdonald@windriver.com> Signed-off-by: Jackie Huang <jackie.huang@windriver.com> Signed-off-by: Joe MacDonald <joe_macdonald@mentor.com>
2015-03-11net-snmp: add knob whether nlist.h are checkedChong.Lu@windriver.com
Previously, it still was checked when there was no nlish.h in sysroots directory. Add knob to decide whether nlist.h are checked or not. Fixed by using PACKAGECONFIG to check elf, with default disabled set. Signed-off-by: Chong Lu <Chong.Lu@windriver.com> Signed-off-by: Joe MacDonald <joe_macdonald@mentor.com>
2015-02-11snmpd: instead option -LS by -LsBian Naimeng
Option -LS does not work, we should instead it by -Ls as usage said. Deprecated options: -l FILE use -Lf <FILE> instead -P use -p instead -s use -Lsd instead -S d|i|0-7 use -Ls <facility> instead Signed-off-by: Bian Naimeng <biannm@cn.fujitsu.com> Signed-off-by: Martin Jansa <Martin.Jansa@gmail.com> Signed-off-by: Joe MacDonald <joe_macdonald@mentor.com>
2015-02-11quagga: fix typo in systemd service fileKang Kai
Fix typo in systemd service file ripngd.service. Signed-off-by: Kai Kang <kai.kang@windriver.com> Signed-off-by: Martin Jansa <Martin.Jansa@gmail.com> Signed-off-by: Joe MacDonald <joe_macdonald@mentor.com>
2015-01-26openl2tp: add new recipeLi xin
OpenL2TP is an open source L2TP client / server, written specifically for Linux. It has been designed for use as an enterprise L2TP VPN server or in commercial, Linux-based, embedded networking products and is able to support hundreds of sessions, each with different configuration. It is used by several ISPs to provide L2TP services and by corporations to implement L2TP VPNs. Signed-off-by: Li Xin <lixin.fnst@cn.fujitsu.com> Signed-off-by: Joe MacDonald <joe_macdonald@mentor.com> Signed-off-by: Martin Jansa <Martin.Jansa@gmail.com>
2015-01-07radiusclient-ng: use BPN in SRC_URIRobert Yang
Signed-off-by: Robert Yang <liezhi.yang@windriver.com> Signed-off-by: Martin Jansa <Martin.Jansa@gmail.com> Signed-off-by: Joe MacDonald <joe_macdonald@mentor.com>