From db2abcd6416608054d66e11e17a9f2204999750e Mon Sep 17 00:00:00 2001 From: Saul Wold Date: Wed, 9 Feb 2011 14:30:29 -0800 Subject: fetch2: Correct the clean() mechanism for the fetcher2 code This create a clean() method in each of the fetcher modules and correctly cleans the .done stamp file and lock files (From Poky rev: 14dea89521c0c648e8e543388096a6dcd6d4f2e0) Signed-off-by: Saul Wold Signed-off-by: Richard Purdie --- lib/bb/fetch2/__init__.py | 34 ++++++++++++++++++++++++++++++++++ lib/bb/fetch2/cvs.py | 12 ++++++++++++ lib/bb/fetch2/git.py | 6 ++++++ lib/bb/fetch2/local.py | 4 ++++ lib/bb/fetch2/svn.py | 7 +++++++ 5 files changed, 63 insertions(+) (limited to 'lib') diff --git a/lib/bb/fetch2/__init__.py b/lib/bb/fetch2/__init__.py index ef9d75f3f..1ec42717f 100644 --- a/lib/bb/fetch2/__init__.py +++ b/lib/bb/fetch2/__init__.py @@ -491,6 +491,7 @@ class FetchData(object): """ def __init__(self, url, d): # localpath is the location of a downloaded result. If not set, the file is local. + self.donestamp = None self.localfile = "" self.localpath = None self.lockfile = None @@ -717,6 +718,12 @@ class FetchMethod(object): return + def clean(self, urldata, d): + """ + Clean any existing full or partial download + """ + bb.utils.remove(urldata.localpath) + def try_premirror(self, url, urldata, d): """ Should premirrors be used? @@ -958,6 +965,33 @@ class Fetch(object): if ud.lockfile: bb.utils.unlockfile(lf) + def clean(self, urls = []): + """ + Clean files that the fetcher gets or places + """ + + if len(urls) == 0: + urls = self.urls + + for url in urls: + if url not in self.ud: + self.ud[url] = FetchData(url, d) + ud = self.ud[url] + ud.setup_localpath(self.d) + + if not ud.localfile or self.localpath is None: + continue + + if ud.lockfile: + lf = bb.utils.lockfile(ud.lockfile) + + ud.method.clean(ud, self.d) + if ud.donestamp: + bb.utils.remove(ud.donestamp) + + if ud.lockfile: + bb.utils.unlockfile(lf) + from . import cvs from . import git from . import local diff --git a/lib/bb/fetch2/cvs.py b/lib/bb/fetch2/cvs.py index 3cd28b1fd..ae03daf23 100644 --- a/lib/bb/fetch2/cvs.py +++ b/lib/bb/fetch2/cvs.py @@ -167,3 +167,15 @@ class Cvs(FetchMethod): runfetchcmd(cmd, d, cleanup = [ud.localpath]) + def clean(self, ud, d): + """ Clean CVS Files and tarballs """ + + pkg = data.expand('${PN}', d) + localdata = data.createCopy(d) + data.setVar('OVERRIDES', "cvs:%s" % data.getVar('OVERRIDES', localdata), localdata) + data.update_data(localdata) + pkgdir = os.path.join(data.expand('${CVSDIR}', localdata), pkg) + + bb.utils.remove(pkgdir, True) + bb.utils.remove(ud.localpath) + diff --git a/lib/bb/fetch2/git.py b/lib/bb/fetch2/git.py index 6d9940677..6d82bdc88 100644 --- a/lib/bb/fetch2/git.py +++ b/lib/bb/fetch2/git.py @@ -172,6 +172,12 @@ class Git(FetchMethod): runfetchcmd("%s checkout-index -q -f -a" % ud.basecmd, d) return True + def clean(self, ud, d): + """ clean the git directory """ + + bb.utils.remove(ud.localpath, True) + bb.utils.remove(ud.fullmirror) + def supports_srcrev(self): return True diff --git a/lib/bb/fetch2/local.py b/lib/bb/fetch2/local.py index d77d39375..77a296ec6 100644 --- a/lib/bb/fetch2/local.py +++ b/lib/bb/fetch2/local.py @@ -74,3 +74,7 @@ class Local(FetchMethod): if os.path.exists(urldata.localpath): return True return False + + def clean(self, urldata, d): + return + diff --git a/lib/bb/fetch2/svn.py b/lib/bb/fetch2/svn.py index 4ab643bcf..d05dc0276 100644 --- a/lib/bb/fetch2/svn.py +++ b/lib/bb/fetch2/svn.py @@ -138,6 +138,13 @@ class Svn(FetchMethod): # tar them up to a defined filename runfetchcmd("tar %s -czf %s %s" % (tar_flags, ud.localpath, ud.module), d, cleanup = [ud.localpath]) + def clean(self, ud, d): + """ Clean SVN specific files and dirs """ + + bb.utils.remove(ud.localpath) + bb.utils.remove(ud.moddir, True) + + def supports_srcrev(self): return True -- cgit 1.2.3-korg