From cf864cd84172f605b0e1777c3defc000fa3a7379 Mon Sep 17 00:00:00 2001 From: Richard Purdie Date: Wed, 29 Sep 2021 22:57:11 +0800 Subject: process: Don't include logs in error message if piping them If the caller is piping the logs, they likely don't want them in the error exception as well. This removes duplicate output from the build output allowing the UI level controls on whether to show logs to work correctly. Signed-off-by: Richard Purdie (cherry picked from commit fc58ad84a9deb2620ad90611684dad65dafedb11) Signed-off-by: Anuj Mittal Signed-off-by: Richard Purdie --- lib/bb/process.py | 3 +++ 1 file changed, 3 insertions(+) (limited to 'lib') diff --git a/lib/bb/process.py b/lib/bb/process.py index 7c3995cce..d5a1775fc 100644 --- a/lib/bb/process.py +++ b/lib/bb/process.py @@ -181,5 +181,8 @@ def run(cmd, input=None, log=None, extrafiles=None, **options): stderr = stderr.decode("utf-8") if pipe.returncode != 0: + if log: + # Don't duplicate the output in the exception if logging it + raise ExecutionError(cmd, pipe.returncode, None, None) raise ExecutionError(cmd, pipe.returncode, stdout, stderr) return stdout, stderr -- cgit 1.2.3-korg