From c7b506d11df78cfc4610db6578745eaa6220b13a Mon Sep 17 00:00:00 2001 From: Joshua Watt Date: Thu, 9 Sep 2021 09:25:33 +0800 Subject: server: Fix early parsing errors preventing zombie bitbake If the client process never sends cooker data, the server timeout will be 0.0, not None. This will prevent the server from exiting, as it is waiting for a new client. In particular, the client will disconnect with a bad "INHERIT" line, such as: INHERIT += "this-class-does-not-exist" Instead of checking explicitly for None, check for a false value, which means either 0.0 or None. Signed-off-by: Joshua Watt Signed-off-by: Richard Purdie (cherry picked from commit 13e2855bff6a6ead6dbd33c5be4b988aafcd4afa) Signed-off-by: Anuj Mittal Signed-off-by: Richard Purdie --- lib/bb/server/process.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'lib/bb') diff --git a/lib/bb/server/process.py b/lib/bb/server/process.py index 155e8d131..a0955722e 100644 --- a/lib/bb/server/process.py +++ b/lib/bb/server/process.py @@ -147,7 +147,7 @@ class ProcessServer(): conn = newconnections.pop(-1) fds.append(conn) self.controllersock = conn - elif self.timeout is None and not ready: + elif not self.timeout and not ready: serverlog("No timeout, exiting.") self.quit = True -- cgit 1.2.3-korg