From 4e4a2ee2f05f8741b2e09263e328420363975b02 Mon Sep 17 00:00:00 2001 From: Alexandru DAMIAN Date: Fri, 6 Mar 2015 14:47:28 +0000 Subject: xmlrpcserver: do not connect client on error We roll back the client connection if some error happens, like during setFeatures, as to leave the server accessible to other clients. Signed-off-by: Alexandru DAMIAN --- lib/bb/server/xmlrpc.py | 2 ++ 1 file changed, 2 insertions(+) (limited to 'lib/bb/server') diff --git a/lib/bb/server/xmlrpc.py b/lib/bb/server/xmlrpc.py index 4205a4c35..afe3dfe5d 100644 --- a/lib/bb/server/xmlrpc.py +++ b/lib/bb/server/xmlrpc.py @@ -299,6 +299,8 @@ class BitBakeXMLRPCServerConnection(BitBakeBaseServerConnection): _, error = self.connection.runCommand(["setFeatures", self.featureset]) if error: + # disconnect the client, we can't make the setFeature work + self.connection.removeClient() # no need to log it here, the error shall be sent to the client raise BaseException(error) -- cgit 1.2.3-korg