From eeeed7693710e4a78fec639b8050d8efe4ea3c33 Mon Sep 17 00:00:00 2001 From: Patrick Ohly Date: Fri, 17 Mar 2017 10:20:23 +0100 Subject: taskdata.py: include more information in error message about broken task depends This is what was reported when variable expansion in the 'depends' varflag of a task was broken: ERROR: Error for .../refkit-image-common.bb, dependency ${@ does not contain exactly one ':' character. Task 'depends' should be specified in the form 'packagename:task' It's not clear which task had this broken 'depends' and while one can guess that variable expansion failed, the full expression isn't printed either. This is more useful: ERROR: Error for .../refkit-image-common.bb:do_stage_swupd_inputs[depends], dependency ${@ in ' virtual/fakeroot-native:do_populate_sysroot ${@ ' '.join(['bundle-refkit-image-common-%s:do_swupd_list_bundle' % x for x in '${SWUPD_BUNDLES}'.split()]) } ' does not contain exactly one ':' character. Task 'depends' should be specified in the form 'packagename:task' The 'depends' part gets repeated intentionally, to ensure that it doesn't get overlooked. Signed-off-by: Patrick Ohly Signed-off-by: Richard Purdie --- lib/bb/taskdata.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/bb/taskdata.py b/lib/bb/taskdata.py index 1f3b24c84..8c96a5628 100644 --- a/lib/bb/taskdata.py +++ b/lib/bb/taskdata.py @@ -97,7 +97,7 @@ class TaskData: if dep: parts = dep.split(":") if len(parts) != 2: - bb.msg.fatal("TaskData", "Error for %s, dependency %s does not contain exactly one ':' character.\n Task '%s' should be specified in the form 'packagename:task'" % (fn, dep, dep_name)) + bb.msg.fatal("TaskData", "Error for %s:%s[%s], dependency %s in '%s' does not contain exactly one ':' character.\n Task '%s' should be specified in the form 'packagename:task'" % (fn, task, dep_name, dep, task_deps[dep_name][task], dep_name)) ids.append((parts[0], parts[1])) seen(parts[0]) depends.extend(ids) -- cgit 1.2.3-korg