From a29ffcc12df24737e702e198aeb8f6892884932b Mon Sep 17 00:00:00 2001 From: Richard Purdie Date: Fri, 10 Mar 2023 21:46:01 +0100 Subject: cookerdata: Drop dubious exception handling code This code appears to be dangerous, it swallows exceptions, turning them into "handled" versions which then show no errors to the user. This is a pretty poor user experience and I can't see why this code should be swallowing such things. Drop the worst bits of code. Signed-off-by: Richard Purdie Signed-off-by: Steve Sakoman Signed-off-by: Richard Purdie --- lib/bb/cookerdata.py | 5 ----- 1 file changed, 5 deletions(-) diff --git a/lib/bb/cookerdata.py b/lib/bb/cookerdata.py index e2dbb3b21..ec3741cc1 100644 --- a/lib/bb/cookerdata.py +++ b/lib/bb/cookerdata.py @@ -293,14 +293,9 @@ class CookerDataBuilder(object): bb.event.fire(bb.event.MultiConfigParsed(self.mcdata), self.data) self.data_hash = data_hash.hexdigest() - except (SyntaxError, bb.BBHandledException): - raise bb.BBHandledException() except bb.data_smart.ExpansionError as e: logger.error(str(e)) raise bb.BBHandledException() - except Exception: - logger.exception("Error parsing configuration files") - raise bb.BBHandledException() # Handle obsolete variable names -- cgit 1.2.3-korg