From 879fe20f47ba75f4afb3484d4398d5fd60431e12 Mon Sep 17 00:00:00 2001 From: Richard Purdie Date: Thu, 8 Jan 2015 10:35:16 +0000 Subject: ast: Add error when trying to use dash in sh function names A dash character is illegal in function names in sh (but not bash). Since our shell tasks run under sh and the shell parser is sh based, EXPORT_FUNCTIONS won't work with class names containing a dash. We can't change sh, we can ensure the user is warned about the problem straight away though. [YOCTO #7006] Signed-off-by: Richard Purdie --- lib/bb/parse/ast.py | 2 ++ 1 file changed, 2 insertions(+) diff --git a/lib/bb/parse/ast.py b/lib/bb/parse/ast.py index 4e5a06e76..4b10ee701 100644 --- a/lib/bb/parse/ast.py +++ b/lib/bb/parse/ast.py @@ -226,6 +226,8 @@ class ExportFuncsNode(AstNode): if data.getVarFlag(calledfunc, "python"): data.setVar(func, " bb.build.exec_func('" + calledfunc + "', d)\n") else: + if "-" in self.classname: + bb.fatal("The classname %s contains a dash character and is calling an sh function %s using EXPORT_FUNCTIONS. Since a dash is illegal in sh function names, this cannot work, please rename the class or don't use EXPORT_FUNCTIONS." % (self.classname, calledfunc)) data.setVar(func, " " + calledfunc + "\n") data.setVarFlag(func, 'export_func', '1') -- cgit 1.2.3-korg