From 51bdd6cb3bd9e2c02e261fb578bb945b86b82c75 Mon Sep 17 00:00:00 2001 From: Richard Purdie Date: Tue, 7 Sep 2021 12:14:29 +0100 Subject: runqueue: Avoid deadlock avoidance task graph corruption If the deferred task deadlock avoidance code triggers, it could mark an executed task as failed which leads to "covered and not covered" error messages. Improve the logic so if the deadlock code is triggered, it doesn't cause the errors. Signed-off-by: Richard Purdie --- lib/bb/runqueue.py | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/lib/bb/runqueue.py b/lib/bb/runqueue.py index 25e012125..f5f25c5b7 100644 --- a/lib/bb/runqueue.py +++ b/lib/bb/runqueue.py @@ -2180,7 +2180,8 @@ class RunQueueExecute: if self.sq_deferred: tid = self.sq_deferred.pop(list(self.sq_deferred.keys())[0]) logger.warning("Runqeueue deadlocked on deferred tasks, forcing task %s" % tid) - self.sq_task_failoutright(tid) + if tid not in self.runq_complete: + self.sq_task_failoutright(tid) return True if len(self.failed_tids) != 0: -- cgit 1.2.3-korg