aboutsummaryrefslogtreecommitdiffstats
path: root/lib
AgeCommit message (Collapse)Author
2011-10-05fetch2: Export additional variables to the fetchersMatthew McClintock
git could need these environment variables when working behind a proxy Signed-off-by: Matthew McClintock <msm@freescale.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
2011-10-03fetch2/git: Make git fetch run with -f so rebased branches don't failMatthew McClintock
git fetches can fail (or at least return failed) when trying to fetch and prune rebased branches. This patch simply adds a -f to the git fetch command so these failure are ignore Generally, if some SHA was rebased away it's not coming back so there is no point in not doing this force Signed-off-by: Matthew McClintock <msm@freescale.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
2011-09-25bitbake/lib/bb/msg.py: fix setting debug and verbosity levelsPaul Eggleton
The debug and verbosity levels (as set by the -D and -v command line options respectively) were not being passed through within msg.py since bitbake revision 45aad2f9647df14bcfa5e755b57e1ddab377939a due to incorrect variable names. Fixes [YOCTO #1513]. Signed-off-by: Paul Eggleton <paul.eggleton@linux.intel.com>
2011-09-23hob: store recipe path at load timeJoshua Lock
This fixes the internal dirtiness tracking such that if the Save menu item is selected after loading a recipe the existing file is updated rather than the user being prompted for the path to create a recipe at. Signed-off-by: Joshua Lock <josh@linux.intel.com>
2011-09-23hob: fix building with current selections after reparseJoshua Lock
After the reparse we were setting the model to reflect the values before the reparse was triggered but clearing the internal variables used to test whether these values are set, leading to the UI erroneously reporting that selections had not been made. Signed-off-by: Joshua Lock <josh@linux.intel.com>
2011-09-23ui/crumbs/hobeventhandler: fix variable name typoJoshua Lock
Signed-off-by: Joshua Lock <josh@linux.intel.com>
2011-09-23ui/crumbs/hobeventhandler: move remaining getVariable calls to initJoshua Lock
Instead of calling getVariable commands each time the BBPATH and BBFILES entries need testing cache the results as a member variable at object instantiation. Fixes [YOCTO #1521] Signed-off-by: Joshua Lock <josh@linux.intel.com>
2011-09-21Fix mercurial fetcher in fetch2Julian Pidancet
The _build_revision method in Hg class gets called with the wrong number of arguments. This tiny patch adds a 5th argument to the method declaration to prevent python from throwing an exception. Signed-off-by: Julian Pidancet <julian.pidancet@gmail.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
2011-09-20hob: fix opening of image output dir on image build completionJoshua Lock
Firstly, rather than polling the DEPLOY_DIR_IMAGE directory each time an image is built store the variable as a member of the hobeventhandler. Secondly emit the generic "build-complete" signal *after* the specialised "build-failed" or "build-succeeded" signals such that the appropriate state variables are set before we try and use them. Signed-off-by: Joshua Lock <josh@linux.intel.com>
2011-09-20ui/crumbs/runningbuild: fix log messages right-click menuJoshua Lock
Pass the correct callback name to the connect method. Signed-off-by: Joshua Lock <josh@linux.intel.com>
2011-09-19hob: enable package only builds even if an image has been builtJoshua Lock
Once an image build has been performed the selected_image variable would prevent the package only build choice being triggered - by setting the variable to None on reset we are able to perform package only builds after an image build. Signed-off-by: Joshua Lock <josh@linux.intel.com>
2011-09-19hob: fix build again when building packages onlyJoshua Lock
The different code paths for package vs image builds have lead to some bit rot in the package only build and an incompatability between package only builds and the build again mechanism. This patch unifies the code paths and fixes build again for package only builds. Fixes [YOCTO #1480] Signed-off-by: Joshua Lock <josh@linux.intel.com>
2011-09-19ui/crumbs/hobprefs: re-enable reloading of data after prefs changesJoshua Lock
When disabling the toolchain w/ headers checkbox in an early commit I accidentally disabled too much code. This re-enables adding the custom response handler to the Preferences dialog which triggeres a reparse of the metadata when appropriate preference changes are made. Fixes [YOCTO #1479] Signed-off-by: Joshua Lock <josh@linux.intel.com>
2011-09-19fetch2/git: fix subpath destination directoryPaul Eggleton
Make the git fetcher's subpath (path within the git repo to fetch) option set the destsuffix (destination directory) option by default. This reverts the behaviour of subpath to the same as when it was introduced. Based on a patch by Dmitry Eremin-Solenikov <dbaryshkov@gmail.com> Signed-off-by: Paul Eggleton <paul.eggleton@linux.intel.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
2011-09-19fetch2/git: be more carefull in _contains_ref when checking git log outputMartin Jansa
* in some cases there could be output like this ERROR: ld.so: object 'libpseudo.so' from LD_PRELOAD cannot be preloaded: ignored. before wc -l output and returned 'output.split()[0] != 0' is always True Signed-off-by: Martin Jansa <Martin.Jansa@gmail.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
2011-09-19fetch2/git: fix logger.debugMartin Jansa
* logging/logger typo was fixed in 38a598731b49c8a0ba0ede570adc33eb1e848235 but debug level is still missing Signed-off-by: Martin Jansa <Martin.Jansa@gmail.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
2011-09-19fetch2/wget: make checkstatus() quieterJoshua Lock
Change the wget fetcher to not emit the commands output when calling checkstatus, this matches the behaviour of the git fetchers checkstatus() method. Signed-off-by: Joshua Lock <josh@linux.intel.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
2011-09-19cooker.py: Fix key expansion issues in showVersionsRichard Purdie
bitbake -s was not displaying correct version information when the PREFERRED_VERSION string contains other variables. The actual built versions would differ since the providers.py functions were called with expanded keys at this point. This patch expands keys for showVersions bringing everything into sync correctly. [YOCTO #1493] Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
2011-09-19git.py: Fix logging vs logger typoRichard Purdie
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
2011-09-14taskdata: fix string formatting of an error messageChristopher Larson
Signed-off-by: Christopher Larson <kergoth@gmail.com>
2011-09-13hob: correctly set the selected image when loading a recipeJoshua Lock
When the user saves their recipe based on an existing image type, loads it in a newly run hob instance and clicks bake they should not be asked about building packages vs an empty image up. Partially addresses [YOCTO #1468] Signed-off-by: Joshua Lock <josh@linux.intel.com>
2011-09-13hob: correctly handle an exceptionJoshua Lock
It doesn't matter if we can't remove the temprorary file, for some reason, so catch the exception and ignore it. Partially addresses [YOCTO #1468] Signed-off-by: Joshua Lock <josh@linux.intel.com>
2011-09-13ui/crumbs/hobeventhandler: don't check BBPATH and BBFILES each buildJoshua Lock
There's no need to check the BBPATH and BBFILES are set correctly each build when running multiple builds for one launch of the UI. Partially addresses [YOCTO #1468] Signed-off-by: Joshua Lock <josh@linux.intel.com>
2011-09-13ui/crumbs/hobeventhandler: fix test for BBFILESJoshua Lock
It seems we have a race whereby the image_dir variable may not be set before it's tested for, since the variable is always the same set it in the initialiser. Partially addresses [YOCTO #1468] Signed-off-by: Joshua Lock <josh@linux.intel.com>
2011-09-09runqueue.py: Ensure fakeroot variables are reflected in the datastoreRichard Purdie
Without this, variables can be set to one thing in one part of the environment and something different in another part. This change ensures the datastore and the environment are consistent. Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
2011-09-09runqueue: Ensure task environment is correctRichard Purdie
This fixes two problems: a) Variables which were in the parent environment but not set as "export" variables in the datastore could end up in the task environment b) oe.environ.update() can't cope with the generator returned by bb.data.exported_vars() Whilst the updated code isn't as neat, it does do the expected thing, sets the environment correctly and stops unwanted values leaking into the task environment. Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
2011-09-05lib/bb/siggen.py: return a string from noop get_taskhashDmitry Eremin-Solenikov
OpenEmbedded is expecting to get a string from get_taskhash, but noop siggen returns just 0 (number), so OE classes/sstate.bbclass barfs badly. Fix that. Signed-off-by: Dmitry Eremin-Solenikov <dbaryshkov@gmail.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
2011-09-05hob: fix segfault on second buildPaul Eggleton
Some internal lists were not being cleared, resulting in incorrect program flow on the second build, causing a structure to be accessed incorrectly which resulted in a segfault. Fixes [YOCTO #1332] Signed-off-by: Paul Eggleton <paul.eggleton@linux.intel.com> Signed-off-by: Joshua Lock <josh@linux.intel.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
2011-09-05hob: clear out temporary file list after deletingPaul Eggleton
If you don't clear out files_to_clean after the files get deleted and then you run a second build, it will try to delete the files from the first build and you will get a "No such file or directory" error. Signed-off-by: Paul Eggleton <paul.eggleton@linux.intel.com> Signed-off-by: Joshua Lock <josh@linux.intel.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
2011-09-05hob: disable removal of packagesJoshua Lock
It's felt that the stability of package deselection is not sufficient for the upcoming release and thus package removal should be disabled. I'd actually like to see this patch, or its effects, reverted as soon as the release bits have been frozen so that this issue can continue to be worked on. Signed-off-by: Joshua Lock <josh@linux.intel.com>
2011-09-05ui/crumbs/runningbuild: mask run_buildstats failureJoshua Lock
The buildstats handler causes an exception with: "'NoneType' object has no attribute 'startswith'" early a build via hob, leaving a glaring red row which means nothing to the user. Mask this error until such a time as we have opportunity to correctly diagnose and fix the root problem. Workaround fix for [YOCTO #1433] Signed-off-by: Joshua Lock <josh@linux.intel.com>
2011-09-05ui/crumbs/hobprefs: disable 'build toolchain with headers'Joshua Lock
The generic meta-toolchain-sdk we are currently building when this option is enabled is likely unsuitable for the majority of images built with hob. Remove this option from the Preferences UI until such a time as we can correctly implement this feature to include the library headers for the selected packages. Addresses [YOCTO #1302] Signed-off-by: Joshua Lock <josh@linux.intel.com>
2011-09-05hob: add a test to ensure hob is run with the required pre and post filesJoshua Lock
hob requires pre and post configuration files to store configuration values in, whilst this should (and will) be fixed long-term for so long as we require these files we should alert the user should they run without them. Fixes [YOCTO #1383] Signed-off-by: Joshua Lock <josh@linux.intel.com>
2011-09-05hob: reflect defaultsetup being default distroJoshua Lock
If no value is set for DISTRO the defaultsetup policy is used, reflect this in the UI by having defaultsetup selected in the Distribution combo when no other DISTRO is set. Signed-off-by: Joshua Lock <josh@linux.intel.com>
2011-09-05hob: use both pre and post files for hob configurationJoshua Lock
We need to set various variables *before* parse begins, the simplest way to ensure this is to use a pre configuration file for the relevant configuration entries. This series adapts hob to use both pre and post files to store its configuration. Any variables which affect initial parse are set in the pre file and all others in the post file. Unfortunately this requires hob related code to have even more hard-coded data as to what is relevant but this is the simplest way to solve issues with variables and parse order at this time. Addresses [YOCTO #1281] Signed-off-by: Joshua Lock <josh@linux.intel.com>
2011-09-02bitbake/event: Allow event handlers to quietly raise SkipPackage eventsRichard Purdie
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
2011-09-02fetch2/git: Allow to specify the name of the checkout directoryHolger Hans Peter Freyther
Signed-off-by: Holger Hans Peter Freyther <holger@moiji-mobile.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
2011-08-31bitbake/fetch2/git: Ensure .gitconfig file is ignoredRichard Purdie
If a user has a ~/.gitconfig file, git fetch --all will reference it. To avoid this we should run git fetch with an explicit url telling it to fetch all references (which includes tags). I'm assured this means git won't reference the file, see the discussion on the git mailing list (subject Overriding ~/.gitconfig using GIT_CONFIG). [YOCTO #1134] Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
2011-08-31bitbake: Correctly handle multiline comments including whitespaceRichard Purdie
If metadata contains: """ FOO = "bar" """ The variable FOO should get set to "bar" but doesn't due to the empty lines be swallowed by the parser and FOO becomming part of the multiline comment. This patch corrects that behaviour so FOO is set as expected. [YOCTO #1377] This patch fixes parsing of multiline comments so lines ending with \ behave consistently and we warn users where there is something happening they likely don't expect. Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
2011-08-30ui/crumbs/tasklistmodel: don't add empty entries to COL_BINBJoshua Lock
Signed-off-by: Joshua Lock <josh@linux.intel.com>
2011-08-30ui/crumbs/tasklistmodel: loop optimisation in include_item()Joshua Lock
Rather than trying to iterate the model to find whether the item is already included and then iterate the model again to find the items path attempt to find the path first and if the path is found test whether the COL_INC of the row is set. Signed-off-by: Joshua Lock <josh@linux.intel.com>
2011-08-30ui/crumbs/tasklistmodel: remove unnecessary checkJoshua Lock
Cheaper to set COL_INC to True regardless of whether it's already set. Signed-off-by: Joshua Lock <josh@linux.intel.com>
2011-08-30ui/crumbs/tasklistmodel: optimise find_path_for_item()Joshua Lock
Rather than calling get_path() for each iterated value use the get_value() method to lookup the COL_NAME value and only call get_path() for a match. This should save some time by potentially removing N-1 calls to get_path() from the loop. Signed-off-by: Joshua Lock <josh@linux.intel.com>
2011-08-30ui/crumbs/tasklistmodel: prevent packages depending on each otherJoshua Lock
Don't add y to x's COL_BINB if x is in y's COL_BINB - prevent circular dependencies. Further this patch improves the variable naming to make this code easier to follow. Fixes [YOCTO #1423] Signed-off-by: Joshua Lock <josh@linux.intel.com>
2011-08-29ui/crumbs/tasklistmodel: don't add same item to binb column more than onceJoshua Lock
In the same vein as a similar, earlier, patch where I missed the second loop which modifies the binb column. Fixes [YOCTO #1420] Signed-off-by: Joshua Lock <josh@linux.intel.com>
2011-08-29data_smart.py: make use of expand cache in getVar()Dongxiao Xu
Currently if passing expand=True to getVar() function, it will pass the handling to getVarFlag(), which doesn't get any benefit from the expand cache. Call the expand() function separately in getVar() to make use of the expand cache, which can decrease the parsing time by 40%. (from current 49s to 27s) Signed-off-by: Dongxiao Xu <dongxiao.xu@intel.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
2011-08-26ui/crumbs/runningbuild: add a 'Copy' item to the messages right-click menuJoshua Lock
Add another item to the right-click menu enabled for log messages to copy the message to the clipboard. Signed-off-by: Joshua Lock <josh@linux.intel.com>
2011-08-26ui/crumbs/tasklistmodel: don't add same item to binb column more than onceJoshua Lock
Signed-off-by: Joshua Lock <josh@linux.intel.com>
2011-08-24hob: disable some menu entries whilst build is in progressJoshua Lock
It doesn't make sense to be able to modify the preferences and add/remove layers whilst a build is in progress - disable the relevant menu items once the build has started and re-enable them once the user has returned to the creation view. Signed-off-by: Joshua Lock <josh@linux.intel.com>
2011-08-24bb/ui/crumbs/tasklistmodel: fix find_reverse_depends methodJoshua Lock
This fixes an embarassing typo which meant the method actually returned a list of packages which didn't depend on the passed pn. Signed-off-by: Joshua Lock <josh@linux.intel.com>