diff options
author | Richard Purdie <richard.purdie@linuxfoundation.org> | 2021-11-18 13:48:04 +0000 |
---|---|---|
committer | Richard Purdie <richard.purdie@linuxfoundation.org> | 2021-11-19 12:51:05 +0000 |
commit | 63baf3440b16e41ac6601de21ced94a94bdf1509 (patch) | |
tree | 97d61cabfec5d93e53f65a22eecb22cbbaed4b48 /lib/bb/utils.py | |
parent | add5d488e1d6607a98441836075d01cb1dc9c0fa (diff) | |
download | bitbake-63baf3440b16e41ac6601de21ced94a94bdf1509.tar.gz |
utils: Handle lockfile filenames that are too long for filesystems
The fetcher mirror code can go crazy creating lock filenames which exceed the
filesystem limits. When this happens, the code will loop/hang.
Handle the filename too long exception correctly but also truncate lockfile
lengths to under 256 since the worst case situation is lockfile overlap
and lack of parallelism.
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
Diffstat (limited to 'lib/bb/utils.py')
-rw-r--r-- | lib/bb/utils.py | 6 |
1 files changed, 5 insertions, 1 deletions
diff --git a/lib/bb/utils.py b/lib/bb/utils.py index 70634910f..d890ea832 100644 --- a/lib/bb/utils.py +++ b/lib/bb/utils.py @@ -451,6 +451,10 @@ def lockfile(name, shared=False, retry=True, block=False): consider the possibility of sending a signal to the process to break out - at which point you want block=True rather than retry=True. """ + if len(name) > 255: + root, ext = os.path.splitext(name) + name = root[:255 - len(ext)] + ext + dirname = os.path.dirname(name) mkdirhier(dirname) @@ -487,7 +491,7 @@ def lockfile(name, shared=False, retry=True, block=False): return lf lf.close() except OSError as e: - if e.errno == errno.EACCES: + if e.errno == errno.EACCES or e.errno == errno.ENAMETOOLONG: logger.error("Unable to acquire lock '%s', %s", e.strerror, name) sys.exit(1) |