aboutsummaryrefslogtreecommitdiffstats
path: root/lib/bb/siggen.py
diff options
context:
space:
mode:
authorRichard Purdie <richard.purdie@linuxfoundation.org>2020-11-01 11:53:57 +0000
committerRichard Purdie <richard.purdie@linuxfoundation.org>2020-11-02 11:37:26 +0000
commit7ae2b73d131491ab5bf09fd6055e1fdb67a560c6 (patch)
tree5aeeb165230b7cc41bf68d4e7ee45e651339a210 /lib/bb/siggen.py
parentf3f5d6d0ceae79da5e5ee46ac79dfa86eb391e97 (diff)
downloadbitbake-7ae2b73d131491ab5bf09fd6055e1fdb67a560c6.tar.gz
siggen: Remove broken optimisation
When a single signature is locked, dependent task checksum calculations fail. This in turn is because get_unihash cannot be cached correctly by this function. Remove that has turned out to be a poor optimisation to avoid that bug. Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
Diffstat (limited to 'lib/bb/siggen.py')
-rw-r--r--lib/bb/siggen.py8
1 files changed, 1 insertions, 7 deletions
diff --git a/lib/bb/siggen.py b/lib/bb/siggen.py
index 86e0e16f3..0ac395246 100644
--- a/lib/bb/siggen.py
+++ b/lib/bb/siggen.py
@@ -311,13 +311,7 @@ class SignatureGeneratorBasic(SignatureGenerator):
data = self.basehash[tid]
for dep in self.runtaskdeps[tid]:
- if dep in self.unihash:
- if self.unihash[dep] is None:
- data = data + self.taskhash[dep]
- else:
- data = data + self.unihash[dep]
- else:
- data = data + self.get_unihash(dep)
+ data = data + self.get_unihash(dep)
for (f, cs) in self.file_checksum_values[tid]:
if cs: