diff options
| author |   Paul Eggleton <paul.eggleton@linux.intel.com> | 2016-08-11 15:37:00 +1200 |
|---|---|---|
| committer |   Richard Purdie <richard.purdie@linuxfoundation.org> | 2016-08-17 10:23:01 +0100 |
| commit | 49502685df3e616023df352823156381b1f79cd3 (patch) | |
| tree | a25a9bce96437d0e4866550fa66f919205e8a3b0 /lib/bb/siggen.py | |
| parent | bedbd46ece8d1285b5cd2ea07dc64b4875b479aa (diff) | |
| download | bitbake-49502685df3e616023df352823156381b1f79cd3.tar.gz | |
siggen: properly close files rather than opening them inline
If you don't do this, with Python 3 you get a warning on exit under some
circumstances.
Signed-off-by: Paul Eggleton <paul.eggleton@linux.intel.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
Diffstat (limited to 'lib/bb/siggen.py')
| -rw-r--r-- | lib/bb/siggen.py | 15 |
1 files changed, 9 insertions, 6 deletions
diff --git a/lib/bb/siggen.py b/lib/bb/siggen.py index 5d8a253a1..9b2f658a4 100644 --- a/lib/bb/siggen.py +++ b/lib/bb/siggen.py @@ -363,10 +363,12 @@ def clean_basepaths_list(a): def compare_sigfiles(a, b, recursecb = None): output = [] - p1 = pickle.Unpickler(open(a, "rb")) - a_data = p1.load() - p2 = pickle.Unpickler(open(b, "rb")) - b_data = p2.load() + with open(a, 'rb') as f: + p1 = pickle.Unpickler(ff) + a_data = p1.load() + with open(b, 'rb') as f: + p2 = pickle.Unpickler(f) + b_data = p2.load() def dict_diff(a, b, whitelist=set()): sa = set(a.keys()) @@ -563,8 +565,9 @@ def calc_taskhash(sigdata): def dump_sigfile(a): output = [] - p1 = pickle.Unpickler(open(a, "rb")) - a_data = p1.load() + with open(a, 'rb') as f: + p1 = pickle.Unpickler(f) + a_data = p1.load() output.append("basewhitelist: %s" % (a_data['basewhitelist'])) |