diff options
| author |   Richard Purdie <richard.purdie@linuxfoundation.org> | 2011-05-27 15:03:51 +0100 |
|---|---|---|
| committer | Richard Purdie <richard.purdie@linuxfoundation.org> | 2011-05-27 17:24:12 +0100 |
| commit | 0a4d857aabc86b973170ba9ce32b6b449a4e2165 (patch) | |
| tree | 3cf728ad05f898b13a3ba5f9f45f957eaad54ac4 /lib/bb/runqueue.py | |
| parent | 97e8adf03e5fab1fd40c3d53c48f7b333bc2e145 (diff) | |
| download | bitbake-0a4d857aabc86b973170ba9ce32b6b449a4e2165.tar.gz | |
bitbake/runqueue.py: Ensure existing setscene stamp files are taken into account
JaMa reported issues where bitbake would rebuild things instead of using the
existing built tasks. This was tracked to a case where:
a) rm_work is uses
b) A depends on B
c) B has a version change (e.g. PR bump)
and A *and* B would then rebuild.
It turns out that rm_work was correctly turning stamp files into the correct
_setscene varients but bitbake was then ignoring them during setscene processing.
If the correct sstate checksumed files didn't exist, everything would seemingly
rebuild.
The fix is to check for existing *_setscene stamps and if present, honour them.
If "basichash" is enabled, the hash is included with the stamps so everything
should then function as intended.
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
Diffstat (limited to 'lib/bb/runqueue.py')
| -rw-r--r-- | lib/bb/runqueue.py | 11 |
1 files changed, 10 insertions, 1 deletions
diff --git a/lib/bb/runqueue.py b/lib/bb/runqueue.py index deebe6002..1729365f5 100644 --- a/lib/bb/runqueue.py +++ b/lib/bb/runqueue.py @@ -1414,16 +1414,25 @@ class RunQueueExecuteScenequeue(RunQueueExecute): sq_taskname = [] sq_task = [] noexec = [] + stamppresent = [] for task in xrange(len(self.sq_revdeps)): realtask = self.rqdata.runq_setscene[task] fn = self.rqdata.taskData.fn_index[self.rqdata.runq_fnid[realtask]] taskname = self.rqdata.runq_task[realtask] taskdep = self.rqdata.dataCache.task_deps[fn] + if 'noexec' in taskdep and taskname in taskdep['noexec']: noexec.append(task) self.task_skip(task) bb.build.make_stamp(taskname + "_setscene", self.rqdata.dataCache, fn) continue + + if self.rq.check_stamp_task(realtask, taskname + "_setscene"): + logger.debug(2, 'Setscene stamp current for task %s(%s)', task, self.rqdata.get_user_idstring(realtask)) + stamppresent.append(task) + self.task_skip(task) + continue + sq_fn.append(fn) sq_hashfn.append(self.rqdata.dataCache.hashfn[fn]) sq_hash.append(self.rqdata.runq_hash[realtask]) @@ -1433,7 +1442,7 @@ class RunQueueExecuteScenequeue(RunQueueExecute): locs = { "sq_fn" : sq_fn, "sq_task" : sq_taskname, "sq_hash" : sq_hash, "sq_hashfn" : sq_hashfn, "d" : self.cooker.configuration.data } valid = bb.utils.better_eval(call, locs) - valid_new = [] + valid_new = stamppresent for v in valid: valid_new.append(sq_task[v]) |