diff options
author | Richard Purdie <richard.purdie@linuxfoundation.org> | 2018-10-14 16:04:35 +0100 |
---|---|---|
committer | Richard Purdie <richard.purdie@linuxfoundation.org> | 2018-10-16 17:17:23 +0100 |
commit | 11722c989077a8751a5d0653c523760bf91e6efa (patch) | |
tree | ae1e10f149865f2cc4c385eb433af1e46b3cc3b6 /lib/bb/data_smart.py | |
parent | ac15028391fdcc3fec2dd0e64a4f763ce63e5449 (diff) | |
download | bitbake-11722c989077a8751a5d0653c523760bf91e6efa.tar.gz |
data_smart: Preserve history when renaming variables
Currently when a variable is renamed, all the variable history is lost.
This makes it hard for users to understand/debug where values came from.
Improve the code so that history is preserved across renamed variables.
(Expanded variable key names are a special case of variable renaming)
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
Diffstat (limited to 'lib/bb/data_smart.py')
-rw-r--r-- | lib/bb/data_smart.py | 11 |
1 files changed, 11 insertions, 0 deletions
diff --git a/lib/bb/data_smart.py b/lib/bb/data_smart.py index 7b09af5cf..4434142a0 100644 --- a/lib/bb/data_smart.py +++ b/lib/bb/data_smart.py @@ -267,6 +267,16 @@ class VariableHistory(object): return self.variables[var].append(loginfo.copy()) + def rename_variable_hist(self, oldvar, newvar): + if not self.dataroot._tracking: + return + if oldvar not in self.variables: + return + if newvar not in self.variables: + self.variables[newvar] = [] + for i in self.variables[oldvar]: + self.variables[newvar].append(i.copy()) + def variable(self, var): remote_connector = self.dataroot.getVar('_remote_data', False) if remote_connector: @@ -619,6 +629,7 @@ class DataSmart(MutableMapping): val = self.getVar(key, 0, parsing=True) if val is not None: + self.varhistory.rename_variable_hist(key, newkey) loginfo['variable'] = newkey loginfo['op'] = 'rename from %s' % key loginfo['detail'] = val |