diff options
| author |   Paul Eggleton <paul.eggleton@linux.intel.com> | 2012-09-07 16:22:54 +0100 |
|---|---|---|
| committer |   Richard Purdie <richard.purdie@linuxfoundation.org> | 2012-09-10 13:14:00 +0100 |
| commit | 675b237a284dff84e972546774b69e2f89afb360 (patch) | |
| tree | 6321d07885f9564ed00c2e29a9afcefaff432980 /lib/bb/cooker.py | |
| parent | 9d4150d99051d24ff218e8a43664ceaf524b19c7 (diff) | |
| download | bitbake-675b237a284dff84e972546774b69e2f89afb360.tar.gz | |
cooker: fix handling of exceptions during exception handling
If an exception occurs during handling another exception we were
getting a useless traceback such as the following, after which
BitBake froze:
ERROR: Command execution failed: Traceback (most recent call last):
File "/home/user/poky/poky/bitbake/lib/bb/command.py", line 84, in runAsyncCommand
self.cooker.updateCache()
File "/home/user/poky/poky/bitbake/lib/bb/cooker.py", line 1207, in updateCache
if not self.parser.parse_next():
File "/home/user/poky/poky/bitbake/lib/bb/cooker.py", line 1694, in parse_next
logger.error('Unable to parse %s', value.recipe,
AttributeError: 'exceptions.TypeError' object has no attribute 'recipe'
Fix this to print an actual traceback of the exception and exit
gracefully (well, as gracefully as possible under the circumstances).
The general fix for [YOCTO #2977].
Signed-off-by: Paul Eggleton <paul.eggleton@linux.intel.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
Diffstat (limited to 'lib/bb/cooker.py')
| -rw-r--r-- | lib/bb/cooker.py | 9 |
1 files changed, 7 insertions, 2 deletions
diff --git a/lib/bb/cooker.py b/lib/bb/cooker.py index 1b3bb8401..19173ae7b 100644 --- a/lib/bb/cooker.py +++ b/lib/bb/cooker.py @@ -1691,8 +1691,13 @@ class CookerParser(object): except Exception as exc: self.error += 1 etype, value, tb = sys.exc_info() - logger.error('Unable to parse %s', value.recipe, - exc_info=(etype, value, exc.traceback)) + if hasattr(value, "recipe"): + logger.error('Unable to parse %s', value.recipe, + exc_info=(etype, value, exc.traceback)) + else: + # Most likely, an exception occurred during raising an exception + import traceback + logger.error('Exception during parse: %s' % traceback.format_exc()) self.shutdown(clean=False) return False |