summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorPascal Bach <pascal.bach@siemens.com>2022-09-28 22:25:54 +0200
committerRichard Purdie <richard.purdie@linuxfoundation.org>2022-09-29 21:23:29 +0100
commitd599af48635fab587e5b913591b95daf87b40080 (patch)
treeb2dd2aec2f17c6f2d8eedbe45e9214ff679eaaf2
parent3f23140f3b26d81452e345f56ed67d2928ae3a12 (diff)
downloadbitbake-d599af48635fab587e5b913591b95daf87b40080.tar.gz
fetch2/ssh.py: fix checkstatus
The output of runfetchcmd is always empty in this case, as the test doesn't produce any output. SSH either returns 0 or 1, which is handled via exceptions. This means the current check is not only unnecessary but prevents the function from working. We can just assume that if we reach the end of the function that the file exists and return True. Signed-off-by: Pascal Bach <pascal.bach@siemens.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
-rw-r--r--lib/bb/fetch2/ssh.py6
1 files changed, 2 insertions, 4 deletions
diff --git a/lib/bb/fetch2/ssh.py b/lib/bb/fetch2/ssh.py
index 8d082b38c..0cbb2a6f2 100644
--- a/lib/bb/fetch2/ssh.py
+++ b/lib/bb/fetch2/ssh.py
@@ -150,8 +150,6 @@ class SSH(FetchMethod):
)
check_network_access(d, cmd, urldata.url)
+ runfetchcmd(cmd, d)
- if runfetchcmd(cmd, d):
- return True
-
- return False
+ return True