diff options
| author |   Neil Horman <nhorman@gmail.com> | 2022-08-30 07:44:45 -0400 |
|---|---|---|
| committer |   Steve Sakoman <steve@sakoman.com> | 2022-09-28 06:47:55 -1000 |
| commit | bb5c43220f5f1c3d82334c65aff1ce13008db8d9 (patch) | |
| tree | b16d6b74282be9613b37ffaf0f038424ea17a56b | |
| parent | e591325b2bd901c381003deb96a7b32a7148e93e (diff) | |
| download | bitbake-bb5c43220f5f1c3d82334c65aff1ce13008db8d9.tar.gz | |
Fix npm to use https rather than http
Hit this error while building nlf-native recently:
{
"error": {
"summary": "URI malformed",
"detail": ""
}
}
Some poking about led me to discover that:
1) The npm.py tool replaces npm:// with http://, not https://
2) Some versions of the npm tool don't handle 301 redirects properly,
choosing to display the above error instead when using the default
nodejs registry
It would be good to go fix npm to handle the redirect properly, but it
seems like it would also be good to assume secure http when contacting a
registry, hence, this patch
Signed-off-by: Neil Horman <nhorman@gmail.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
(cherry picked from commit 2cd76e8aabe4e803c760e60f06cfe1f470714ec7)
Signed-off-by: Steve Sakoman <steve@sakoman.com>
| -rw-r--r-- | lib/bb/fetch2/npm.py | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/lib/bb/fetch2/npm.py b/lib/bb/fetch2/npm.py index 8f7c10ac9..8a179a339 100644 --- a/lib/bb/fetch2/npm.py +++ b/lib/bb/fetch2/npm.py @@ -156,7 +156,7 @@ class Npm(FetchMethod): raise ParameterError("Invalid 'version' parameter", ud.url) # Extract the 'registry' part of the url - ud.registry = re.sub(r"^npm://", "http://", ud.url.split(";")[0]) + ud.registry = re.sub(r"^npm://", "https://", ud.url.split(";")[0]) # Using the 'downloadfilename' parameter as local filename # or the npm package name. |