diff options
| author |   Richard Purdie <richard.purdie@linuxfoundation.org> | 2023-03-10 21:46:01 +0100 |
|---|---|---|
| committer | Richard Purdie <richard.purdie@linuxfoundation.org> | 2023-03-14 15:05:00 +0000 |
| commit | a29ffcc12df24737e702e198aeb8f6892884932b (patch) | |
| tree | 9e542837deda192bc51e83291e1eafb669cdbfd5 | |
| parent | e66012bfda60ffe1658473e25879aa67909ae65f (diff) | |
| download | bitbake-a29ffcc12df24737e702e198aeb8f6892884932b.tar.gz | |
cookerdata: Drop dubious exception handling code
This code appears to be dangerous, it swallows exceptions, turning them into
"handled" versions which then show no errors to the user. This is a pretty
poor user experience and I can't see why this code should be swallowing
such things. Drop the worst bits of code.
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
Signed-off-by: Steve Sakoman <steve@sakoman.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
| -rw-r--r-- | lib/bb/cookerdata.py | 5 |
1 files changed, 0 insertions, 5 deletions
diff --git a/lib/bb/cookerdata.py b/lib/bb/cookerdata.py index e2dbb3b21..ec3741cc1 100644 --- a/lib/bb/cookerdata.py +++ b/lib/bb/cookerdata.py @@ -293,14 +293,9 @@ class CookerDataBuilder(object): bb.event.fire(bb.event.MultiConfigParsed(self.mcdata), self.data) self.data_hash = data_hash.hexdigest() - except (SyntaxError, bb.BBHandledException): - raise bb.BBHandledException() except bb.data_smart.ExpansionError as e: logger.error(str(e)) raise bb.BBHandledException() - except Exception: - logger.exception("Error parsing configuration files") - raise bb.BBHandledException() # Handle obsolete variable names |