summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorOla x Nilsson <ola.x.nilsson@axis.com>2019-12-20 15:23:19 +0100
committerArmin Kuster <akuster808@gmail.com>2020-01-02 20:23:09 -0800
commite731f72ca86629eb935bb1c4f7323421a125aace (patch)
treebd976172dd447a84bc40c01eec851e5850ba5adb
parent4c7d689341f471efdf8ab7c2a7c6a19d2d370f5c (diff)
downloadbitbake-e731f72ca86629eb935bb1c4f7323421a125aace.tar.gz
prserv/serv: Use with while reading pidfile
Signed-off-by: Ola x Nilsson <olani@axis.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org> (cherry picked from commit 6fa8a18ea4994031fdd1253fe363c5d8eeeba456) Signed-off-by: Armin Kuster <akuster808@gmail.com>
-rw-r--r--lib/prserv/serv.py12
1 files changed, 5 insertions, 7 deletions
diff --git a/lib/prserv/serv.py b/lib/prserv/serv.py
index 6d8142fcc..446e1fe12 100644
--- a/lib/prserv/serv.py
+++ b/lib/prserv/serv.py
@@ -292,10 +292,9 @@ class PRServer(SimpleXMLRPCServer):
logger.addHandler(streamhandler)
# write pidfile
- pid = str(os.getpid())
- pf = open(self.pidfile, 'w')
- pf.write("%s\n" % pid)
- pf.close()
+ pid = str(os.getpid())
+ with open(self.pidfile, 'w') as pf:
+ pf.write("%s\n" % pid)
self.work_forever()
self.delpid()
@@ -353,9 +352,8 @@ def start_daemon(dbfile, host, port, logfile):
ip = socket.gethostbyname(host)
pidfile = PIDPREFIX % (ip, port)
try:
- pf = open(pidfile,'r')
- pid = int(pf.readline().strip())
- pf.close()
+ with open(pidfile) as pf:
+ pid = int(pf.readline().strip())
except IOError:
pid = None