diff options
| author |   Gavin Li <gavin@matician.com> | 2019-11-11 14:17:39 -0800 |
|---|---|---|
| committer |   Armin Kuster <akuster808@gmail.com> | 2019-11-23 07:53:19 -0800 |
| commit | cd970c9efa805ec3e7ba952df1701b347441ec7b (patch) | |
| tree | df48b6b8fd73e5cc520201fb62554824556af289 | |
| parent | c61c8356cce4d7307f74147dcf2b2cf103db84a8 (diff) | |
| download | bitbake-cd970c9efa805ec3e7ba952df1701b347441ec7b.tar.gz | |
prserv: fix ResourceWarning due to unclosed socket
With PRSERV_HOST = "localhost:0", this message would occasionally pop up
during the initial cache read:
WARNING: /home/matic/ambayocto/poky/bitbake/lib/bb/cache.py:446: ResourceWarning: unclosed <socket.socket fd=10, family=AddressFamily.AF_INET, type=SocketKind.SOCK_STREAM, proto=0, laddr=('127.0.0.1', 45655)>
value = pickled.load()
The file location stated is irrelevant; it just happens to be wherever
CPython decides to run the garbage collector. The issue is that after we
fork off a PRServer, self.socket is also duplicated. The parent side of
it also needs to be closed.
Signed-off-by: Gavin Li <gavin@matician.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
Signed-off-by: Armin Kuster <akuster808@gmail.com>
| -rw-r--r-- | lib/prserv/serv.py | 1 |
1 files changed, 1 insertions, 0 deletions
diff --git a/lib/prserv/serv.py b/lib/prserv/serv.py index be3acec36..1d9148b81 100644 --- a/lib/prserv/serv.py +++ b/lib/prserv/serv.py @@ -243,6 +243,7 @@ class PRServer(SimpleXMLRPCServer): try: pid = os.fork() if pid > 0: + self.socket.close() # avoid ResourceWarning in parent return pid except OSError as e: raise Exception("%s [%d]" % (e.strerror, e.errno)) |