summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorMichael Wood <michael.g.wood@intel.com>2016-09-26 13:59:37 +0300
committerRichard Purdie <richard.purdie@linuxfoundation.org>2016-09-28 10:45:10 +0100
commit0b8d3ac48b5a0984963d664ff5630e3b02c4ecd1 (patch)
tree8175cf2b49fef1dd05216ec96f23a87ecb0f425a
parent19aee3dd7fa290e12216f9a5cf25a8b2c8d80d20 (diff)
downloadbitbake-0b8d3ac48b5a0984963d664ff5630e3b02c4ecd1.tar.gz
toaster: layerdetails Update implementation of delete imported layer
Update the implementation of delete an imported layer so that it is consistent with the other delete messages and wording. Also use the new libtoaster way of setting a notification that the delete was successful. Signed-off-by: Michael Wood <michael.g.wood@intel.com> Signed-off-by: Ed Bartosh <ed.bartosh@linux.intel.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
-rw-r--r--lib/toaster/toastergui/api.py2
-rw-r--r--lib/toaster/toastergui/static/js/layerdetails.js7
-rw-r--r--lib/toaster/toastergui/templates/layerdetails.html9
3 files changed, 12 insertions, 6 deletions
diff --git a/lib/toaster/toastergui/api.py b/lib/toaster/toastergui/api.py
index 149abf7a5..3a05d6638 100644
--- a/lib/toaster/toastergui/api.py
+++ b/lib/toaster/toastergui/api.py
@@ -221,7 +221,7 @@ class XhrLayer(View):
return JsonResponse({
"error": "ok",
- "redirect": reverse('project', args=(kwargs['pid'],))
+ "gotoUrl": reverse('project', args=(kwargs['pid'],))
})
diff --git a/lib/toaster/toastergui/static/js/layerdetails.js b/lib/toaster/toastergui/static/js/layerdetails.js
index 8165bad5d..4c0d0426e 100644
--- a/lib/toaster/toastergui/static/js/layerdetails.js
+++ b/lib/toaster/toastergui/static/js/layerdetails.js
@@ -391,7 +391,9 @@ function layerDetailsPageInit (ctx) {
});
$("#layer-delete-confirmed").click(function(){
- $.cookie("layer-deleted", ctx.layerVersion.name, { path: '/'});
+
+ var message = $('<span>You have deleted <strong>1</strong> layer from your project: <strong id="deleted-layer-name"></strong>');
+ message.find("#deleted-layer-name").text(ctx.layerVersion.name);
$.ajax({
type: "DELETE",
@@ -401,7 +403,8 @@ function layerDetailsPageInit (ctx) {
if (data.error != "ok") {
console.warn(data.error);
} else {
- window.location = data.redirect + "?notify=layer-deleted";
+ libtoaster.setNotification("layer-deleted", message.html());
+ window.location.replace(data.gotoUrl);
}
},
error: function(data) {
diff --git a/lib/toaster/toastergui/templates/layerdetails.html b/lib/toaster/toastergui/templates/layerdetails.html
index 0594b551a..f1569bd63 100644
--- a/lib/toaster/toastergui/templates/layerdetails.html
+++ b/lib/toaster/toastergui/templates/layerdetails.html
@@ -6,14 +6,16 @@
{% block title %} {{layerversion.layer.name}} - {{project.name}} - Toaster {% endblock %}
{% block pagecontent %}
-<div id="delete-layer-modal" class="modal fade" tabindex="-1" role="dialog">
+<div id="delete-layer-modal" class="modal fade" tabindex="-1" role="dialog"
+ data-keyboard="false" data-backdrop="static">
<div class="modal-dialog" role="document">
<div class="modal-content">
<div class="modal-body">
Are you sure you want to delete the <strong>{{layerversion.layer.name}}</strong> layer?
</div>
<div class="modal-footer">
- <button type="button" id="layer-delete-confirmed" class="btn btn-primary">Delete</button>
+ <button type="button" id="layer-delete-confirmed" class="btn
+ btn-primary">Delete layer</button>
<button type="button" class="btn btn-default btn-link" data-dismiss="modal">Cancel</button>
</div>
</div>
@@ -358,7 +360,8 @@
{# Only show delete link for imported layers #}
{% if layerversion.layer_source == layer_source.TYPE_IMPORTED %}
<i class="icon-trash text-danger"></i>
- <a href="#delete-layer-modal" role="button" class="text-danger" data-toggle="modal" data-target="#delete-layer-modal">Delete {{layerversion.layer.name}}</a>
+ <a href="#delete-layer-modal" role="button" class="text-danger"
+ data-toggle="modal" data-target="#delete-layer-modal">Delete layer</a>
{% endif %}
</div>
</div>