summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorJoshua Lock <joshua.g.lock@intel.com>2016-10-04 11:03:55 +0100
committerRichard Purdie <richard.purdie@linuxfoundation.org>2016-11-08 23:43:26 +0000
commit775888307dc2917ef4b52799cc1600a6b3a01abe (patch)
tree0b983fcc9638557c079c37f6a6c8746376af8577
parentc4029c4f00197804511fc71e1190d34eb120212a (diff)
downloadbitbake-775888307dc2917ef4b52799cc1600a6b3a01abe.tar.gz
event: prevent unclosed file warning in print_ui_queue
Use logger.addHandler(), rather than assigning an array of Handlers to the loggers handlers property directly, to avoid a warning from Python 3 about unclosed files: $ bitbake Nothing to do. Use 'bitbake world' to build everything, or run 'bitbake --help' for usage information. WARNING: /home/joshuagl/Projects/poky/bitbake/lib/bb/event.py:143: ResourceWarning: unclosed file <_io.TextIOWrapper name='/home/joshuagl/Projects/poky/build/tmp/log/cooker/qemux86/20161004094928.log' mode='a' encoding='UTF-8'> logger.handlers = [stdout] Signed-off-by: Joshua Lock <joshua.g.lock@intel.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
-rw-r--r--lib/bb/event.py6
1 files changed, 3 insertions, 3 deletions
diff --git a/lib/bb/event.py b/lib/bb/event.py
index 2cac074a0..4b133a7c1 100644
--- a/lib/bb/event.py
+++ b/lib/bb/event.py
@@ -129,16 +129,16 @@ def print_ui_queue():
if isinstance(event, logging.LogRecord):
if event.levelno > logging.DEBUG:
if event.levelno >= logging.WARNING:
- logger.handlers = [stderr]
+ logger.addHandler(stderr)
else:
- logger.handlers = [stdout]
+ logger.addHandler(stdout)
logger.handle(event)
msgprint = True
if msgprint:
return
# Nope, so just print all of the messages we have (including debug messages)
- logger.handlers = [stdout]
+ logger.addHandler(stdout)
for event in ui_queue:
if isinstance(event, logging.LogRecord):
logger.handle(event)