diff options
| author |   Richard Purdie <richard.purdie@linuxfoundation.org> | 2015-06-25 17:53:23 +0100 |
|---|---|---|
| committer | Richard Purdie <richard.purdie@linuxfoundation.org> | 2015-06-29 09:49:01 +0100 |
| commit | ac66fac162e68b568f986fe1917772e61c982f8e (patch) | |
| tree | 05ccab01f3e8cd0bb4629580d5f43deacff2d562 | |
| parent | e14873d6847fae8abd3baf4bdc804d52d3b0c4f5 (diff) | |
| download | bitbake-ac66fac162e68b568f986fe1917772e61c982f8e.tar.gz | |
cooker: Fire BuildCompleted before finishing the command
Some handlers hook on BuildComplete so it avoids certain event races
to finish the command after the BuildComplete event is sent out.
This means the UI is available to handle events until the command
completes.
What appears to be a race on one of the sanity tests for event handlers
triggered this change although the failure is hard to reproduce.
[YOCTO #7921]
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
| -rw-r--r-- | lib/bb/cooker.py | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/lib/bb/cooker.py b/lib/bb/cooker.py index 9c101f2e7..f32dae0f5 100644 --- a/lib/bb/cooker.py +++ b/lib/bb/cooker.py @@ -1303,8 +1303,8 @@ class BBCooker: return False if not retval: - self.command.finishAsyncCommand(msg) bb.event.fire(bb.event.BuildCompleted(len(rq.rqdata.runq_fnid), buildname, item, failures), self.expanded_data) + self.command.finishAsyncCommand(msg) return False if retval is True: return True @@ -1336,8 +1336,8 @@ class BBCooker: return False if not retval: - self.command.finishAsyncCommand(msg) bb.event.fire(bb.event.BuildCompleted(len(rq.rqdata.runq_fnid), buildname, targets, failures), self.data) + self.command.finishAsyncCommand(msg) return False if retval is True: return True |